Page 1 of 2
Planning a new OC 3.0.x.x release
Posted: Sun Feb 18, 2024 2:07 am
by JNeuhoff
The
OpenCart 3.0.x.x branch, which is based on 3.0.3.9, has gone through a number of further bugfixes. Mostly for making it pass PHPstan level 1 checks, but it also has updates for Opayo and Paypal.
I am thinking about asking Daniel to make a new release now, but need your feedback on what new version number to use:
3.0.3.10 or 3.0.4.0 ?
While it's more like a 3.0.3.10 I am hesitant to use double digits for the lowest level because some extension may use
strmp instead of
version_compare for supported OC version checks.
Any feedback?
Re: Planning a new OC 3.0.x.x release
Posted: Sun Feb 18, 2024 2:16 am
by xxvirusxx
3.0.4.0
Re: Planning a new OC 3.0.x.x release
Posted: Sun Feb 18, 2024 2:35 pm
by OSWorX
Would be also more for 3.0.4.0 because the changes are bigger than for sub-patch release.
Re: Planning a new OC 3.0.x.x release
Posted: Mon Feb 19, 2024 5:39 pm
by ADD Creative
It would be nice if
https://github.com/opencart/opencart?ta ... versioning was followed for once. Since Opayo has been added it should be 3.0.4.0. But going by that 3.0.4.0 should have been used long ago.
There are some security issues I have been working on, which would be nice if fixes could be included if needed before a release. I will send you a private message about them to get your opinion.
Re: Planning a new OC 3.0.x.x release
Posted: Mon Feb 19, 2024 6:45 pm
by JNeuhoff
ADD Creative wrote: ↑Mon Feb 19, 2024 5:39 pm
It would be nice if
https://github.com/opencart/opencart?ta ... versioning was followed for once. Since Opayo has been added it should be 3.0.4.0. But going by that 3.0.4.0 should have been used long ago.
There are some security issues I have been working on, which would be nice if fixes could be included if needed before a release. I will send you a private message about them to get your opinion.
Thanks for your link to the versioning docs. So the 4 levels are
major.minor.feature.patch, in which case 3.0.4.0 would make sense indeed, because of added or deleted payment extensions. As regards security patches: Looking forward to your details.
Re: Planning a new OC 3.0.x.x release
Posted: Tue Feb 20, 2024 11:25 am
by khnaz35
3.0.4.0
Re: Planning a new OC 3.0.x.x release
Posted: Tue Feb 20, 2024 5:05 pm
by WaxedPerfection
3.0.4.0 please
Re: Planning a new OC 3.0.x.x release
Posted: Tue Feb 20, 2024 5:41 pm
by ADD Creative
JNeuhoff wrote: ↑Mon Feb 19, 2024 6:45 pm
Thanks for your link to the versioning docs. So the 4 levels are
major.minor.feature.patch, in which case 3.0.4.0 would make sense indeed, because of added or deleted payment extensions. As regards security patches: Looking forward to your details.
I've sent you a private message.
Re: Planning a new OC 3.0.x.x release
Posted: Tue Feb 20, 2024 9:06 pm
by paulfeakins
JNeuhoff wrote: ↑Sun Feb 18, 2024 2:07 am
a number of further bugfixes. Mostly for making it pass PHPstan level 1 checks, but it also has updates for Opayo and Paypal.
I am thinking about asking Daniel to make a new release now, but need your feedback on what new version number to use:
3.0.3.10 or 3.0.4.0 ?
Version numbers should stick to the rules here:
https://github.com/opencart/opencart
OpenCart wrote:
Versioning
The version is broken down into 4 points e.g 1.2.3.4 We use MAJOR.MINOR.FEATURE.PATCH to describe the version numbers.
A MAJOR is very rare, it would only be considered if the source was effectively re-written or a clean break was desired for other reasons. This increment would likely break most 3rd party modules.
A MINOR is when there are significant changes that affect core structures. This increment would likely break some 3rd party modules.
A FEATURE version is when new extensions or features are added (such as a payment gateway, shipping module etc). Updating a feature version is at a low risk of breaking 3rd party modules.
A PATCH version is when a fix is added, it should be considered safe to update patch versions e.g 1.2.3.4 to 1.2.3.5
Seeing as "it also has updates for Opayo and Paypal", (and bearing in mind OpenCart has only ever used single digits) it seems that 3.0.4.0 is the logical choice.
Re: Planning a new OC 3.0.x.x release
Posted: Tue Feb 20, 2024 9:15 pm
by JNeuhoff
Thanks to all for your feedback. The index.php and admin/index.php now are set to use
define('VERSION', '3.0.4.0');
Will wait for AddCreative for some security patches, and after that we can ask Daniel for a release.
Re: Planning a new OC 3.0.x.x release
Posted: Tue Feb 20, 2024 10:26 pm
by xxvirusxx
And TimeZone fix
Re: Planning a new OC 3.0.x.x release
Posted: Tue Feb 20, 2024 11:20 pm
by JNeuhoff
xxvirusxx wrote: ↑Tue Feb 20, 2024 10:26 pm
And TimeZone fix
Ah yes, thanks for the reminder.
@AddCreative, when you have a spare moment, could you create a pull-request, based on what was discussed at
https://github.com/opencart/opencart/pull/13390 ?
Re: Planning a new OC 3.0.x.x release
Posted: Wed Feb 21, 2024 6:05 pm
by ADD Creative
On testing this was the absolute minimum of changes needed to fix the time zone affecting the session and API.
https://github.com/opencart/opencart/pull/13704
Re: Planning a new OC 3.0.x.x release
Posted: Wed Feb 21, 2024 6:59 pm
by paulfeakins
JNeuhoff wrote: ↑Tue Feb 20, 2024 9:15 pm
Will wait for AddCreative for some security patches, and after that we can ask Daniel for a release.
Very good work, thank you!
Re: Planning a new OC 3.0.x.x release
Posted: Thu Feb 22, 2024 1:06 pm
by Joe1234
xxvirusxx wrote: ↑Tue Feb 20, 2024 10:26 pm
And TimeZone fix
Quick unrelated interjection. By this do you mean the timezone can be changed in the admin now without any problems? If so, it is still not working. Still have to go in and manually set the default.php in system/config, otherwise you're locked out the admin.
Re: Planning a new OC 3.0.x.x release
Posted: Thu Feb 22, 2024 1:56 pm
by by mona
paulfeakins wrote: ↑Wed Feb 21, 2024 6:59 pm
Very good work, thank you!
ditto - with many thanks to all
Re: Planning a new OC 3.0.x.x release
Posted: Thu Feb 22, 2024 5:53 pm
by JNeuhoff
Joe1234 wrote: ↑Thu Feb 22, 2024 1:06 pm
xxvirusxx wrote: ↑Tue Feb 20, 2024 10:26 pm
And TimeZone fix
Quick unrelated interjection. By this do you mean the timezone can be changed in the admin now without any problems? If so, it is still not working. Still have to go in and manually set the default.php in system/config, otherwise you're locked out the admin.
Please provide more details. What is your timezone? What's your OS? What browser? What session timeout in your php.ini and/or .user.ini ? Did you do a fresh install?
Re: Planning a new OC 3.0.x.x release
Posted: Thu Feb 22, 2024 10:54 pm
by Joe1234
America/ny, Linux, chrome, if you mean the gc_maxlifetime that's 1440, other than that I don't see a session timeout, it is a new install but if you mean if I'm making this change after I have installed extensions.
Re: Planning a new OC 3.0.x.x release
Posted: Thu Feb 22, 2024 11:07 pm
by ADD Creative
Joe1234 wrote: ↑Thu Feb 22, 2024 10:54 pm
America/ny, Linux, chrome, if you mean the gc_maxlifetime that's 1440, other than that I don't see a session timeout, it is a new install but if you mean if I'm making this change after I have installed extensions.
What version (or when did you download using the 3.0.x.x)? Does it have this change?
https://github.com/opencart/opencart/pull/13704
Re: Planning a new OC 3.0.x.x release
Posted: Fri Feb 23, 2024 12:54 am
by labeshops
3.0.4.0 for sure. Is there a release date for this? I just downloaded 3.0.3.9 planning to upgrade to it so I can use PHP 8 when I saw this post so now want to wait for the latest version.