Post by JNeuhoff » Sun Feb 18, 2024 2:07 am

The OpenCart 3.0.x.x branch, which is based on 3.0.3.9, has gone through a number of further bugfixes. Mostly for making it pass PHPstan level 1 checks, but it also has updates for Opayo and Paypal.

I am thinking about asking Daniel to make a new release now, but need your feedback on what new version number to use:

3.0.3.10 or 3.0.4.0 ?

While it's more like a 3.0.3.10 I am hesitant to use double digits for the lowest level because some extension may use strmp instead of version_compare for supported OC version checks.

Any feedback?

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by OSWorX » Sun Feb 18, 2024 2:35 pm

Would be also more for 3.0.4.0 because the changes are bigger than for sub-patch release.

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by ADD Creative » Mon Feb 19, 2024 5:39 pm

It would be nice if https://github.com/opencart/opencart?ta ... versioning was followed for once. Since Opayo has been added it should be 3.0.4.0. But going by that 3.0.4.0 should have been used long ago.

There are some security issues I have been working on, which would be nice if fixes could be included if needed before a release. I will send you a private message about them to get your opinion.

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by JNeuhoff » Mon Feb 19, 2024 6:45 pm

ADD Creative wrote:
Mon Feb 19, 2024 5:39 pm
It would be nice if https://github.com/opencart/opencart?ta ... versioning was followed for once. Since Opayo has been added it should be 3.0.4.0. But going by that 3.0.4.0 should have been used long ago.

There are some security issues I have been working on, which would be nice if fixes could be included if needed before a release. I will send you a private message about them to get your opinion.
Thanks for your link to the versioning docs. So the 4 levels are major.minor.feature.patch, in which case 3.0.4.0 would make sense indeed, because of added or deleted payment extensions. As regards security patches: Looking forward to your details.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by khnaz35 » Tue Feb 20, 2024 11:25 am

3.0.4.0

Got an urgent question that’s keeping you up at night? There might just be a magical inbox ready to help: khnaz35@gmail.com
Enjoy nature ;) :) :-*


User avatar
Active Member

Posts

Joined
Mon Aug 27, 2018 11:30 pm
Location - Malaysia

Post by WaxedPerfection » Tue Feb 20, 2024 5:05 pm

3.0.4.0 please

https://www.waxedperfection.co.uk/ Car Detailing Product Blog's and Review's


Active Member

Posts

Joined
Sun Mar 26, 2017 8:23 pm

Post by ADD Creative » Tue Feb 20, 2024 5:41 pm

JNeuhoff wrote:
Mon Feb 19, 2024 6:45 pm
Thanks for your link to the versioning docs. So the 4 levels are major.minor.feature.patch, in which case 3.0.4.0 would make sense indeed, because of added or deleted payment extensions. As regards security patches: Looking forward to your details.
I've sent you a private message.

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by paulfeakins » Tue Feb 20, 2024 9:06 pm

JNeuhoff wrote:
Sun Feb 18, 2024 2:07 am
a number of further bugfixes. Mostly for making it pass PHPstan level 1 checks, but it also has updates for Opayo and Paypal.

I am thinking about asking Daniel to make a new release now, but need your feedback on what new version number to use:

3.0.3.10 or 3.0.4.0 ?
Version numbers should stick to the rules here:
https://github.com/opencart/opencart
OpenCart wrote: Versioning
The version is broken down into 4 points e.g 1.2.3.4 We use MAJOR.MINOR.FEATURE.PATCH to describe the version numbers.

A MAJOR is very rare, it would only be considered if the source was effectively re-written or a clean break was desired for other reasons. This increment would likely break most 3rd party modules.

A MINOR is when there are significant changes that affect core structures. This increment would likely break some 3rd party modules.

A FEATURE version is when new extensions or features are added (such as a payment gateway, shipping module etc). Updating a feature version is at a low risk of breaking 3rd party modules.

A PATCH version is when a fix is added, it should be considered safe to update patch versions e.g 1.2.3.4 to 1.2.3.5
Seeing as "it also has updates for Opayo and Paypal", (and bearing in mind OpenCart has only ever used single digits) it seems that 3.0.4.0 is the logical choice.

UK OpenCart Hosting | OpenCart Audits | OpenCart Support - please email info@antropy.co.uk


User avatar
Legendary Member
Online

Posts

Joined
Mon Aug 22, 2011 11:01 pm
Location - London Gatwick, United Kingdom

Post by JNeuhoff » Tue Feb 20, 2024 9:15 pm

Thanks to all for your feedback. The index.php and admin/index.php now are set to use

define('VERSION', '3.0.4.0');

Will wait for AddCreative for some security patches, and after that we can ask Daniel for a release.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by xxvirusxx » Tue Feb 20, 2024 10:26 pm

And TimeZone fix :)

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by JNeuhoff » Tue Feb 20, 2024 11:20 pm

xxvirusxx wrote:
Tue Feb 20, 2024 10:26 pm
And TimeZone fix :)
Ah yes, thanks for the reminder.

@AddCreative, when you have a spare moment, could you create a pull-request, based on what was discussed at https://github.com/opencart/opencart/pull/13390 ?

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by ADD Creative » Wed Feb 21, 2024 6:05 pm

JNeuhoff wrote:
Tue Feb 20, 2024 11:20 pm
xxvirusxx wrote:
Tue Feb 20, 2024 10:26 pm
And TimeZone fix :)
Ah yes, thanks for the reminder.

@AddCreative, when you have a spare moment, could you create a pull-request, based on what was discussed at https://github.com/opencart/opencart/pull/13390 ?
On testing this was the absolute minimum of changes needed to fix the time zone affecting the session and API.
https://github.com/opencart/opencart/pull/13704

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by paulfeakins » Wed Feb 21, 2024 6:59 pm

JNeuhoff wrote:
Tue Feb 20, 2024 9:15 pm
Will wait for AddCreative for some security patches, and after that we can ask Daniel for a release.
Very good work, thank you!

UK OpenCart Hosting | OpenCart Audits | OpenCart Support - please email info@antropy.co.uk


User avatar
Legendary Member
Online

Posts

Joined
Mon Aug 22, 2011 11:01 pm
Location - London Gatwick, United Kingdom

Post by Joe1234 » Thu Feb 22, 2024 1:06 pm

xxvirusxx wrote:
Tue Feb 20, 2024 10:26 pm
And TimeZone fix :)
Quick unrelated interjection. By this do you mean the timezone can be changed in the admin now without any problems? If so, it is still not working. Still have to go in and manually set the default.php in system/config, otherwise you're locked out the admin.

v3.0.4.0 php 8.1
I'm here for a reason, if your response is contact a/the developer, just don't reply.


Active Member

Posts

Joined
Sat Jan 01, 2022 5:47 am

Post by by mona » Thu Feb 22, 2024 1:56 pm

paulfeakins wrote:
Wed Feb 21, 2024 6:59 pm
Very good work, thank you!
ditto - with many thanks to all

DISCLAIMER:
You should not modify core files .. if you would like to donate a cup of coffee I will write it in a modification for you.


https://www.youtube.com/watch?v=zXIxDoCRc84


User avatar
Expert Member

Posts

Joined
Mon Jun 10, 2019 9:31 am

Post by JNeuhoff » Thu Feb 22, 2024 5:53 pm

Joe1234 wrote:
Thu Feb 22, 2024 1:06 pm
xxvirusxx wrote:
Tue Feb 20, 2024 10:26 pm
And TimeZone fix :)
Quick unrelated interjection. By this do you mean the timezone can be changed in the admin now without any problems? If so, it is still not working. Still have to go in and manually set the default.php in system/config, otherwise you're locked out the admin.
Please provide more details. What is your timezone? What's your OS? What browser? What session timeout in your php.ini and/or .user.ini ? Did you do a fresh install?

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by Joe1234 » Thu Feb 22, 2024 10:54 pm

America/ny, Linux, chrome, if you mean the gc_maxlifetime that's 1440, other than that I don't see a session timeout, it is a new install but if you mean if I'm making this change after I have installed extensions.

v3.0.4.0 php 8.1
I'm here for a reason, if your response is contact a/the developer, just don't reply.


Active Member

Posts

Joined
Sat Jan 01, 2022 5:47 am

Post by ADD Creative » Thu Feb 22, 2024 11:07 pm

Joe1234 wrote:
Thu Feb 22, 2024 10:54 pm
America/ny, Linux, chrome, if you mean the gc_maxlifetime that's 1440, other than that I don't see a session timeout, it is a new install but if you mean if I'm making this change after I have installed extensions.
What version (or when did you download using the 3.0.x.x)? Does it have this change? https://github.com/opencart/opencart/pull/13704

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by labeshops » Fri Feb 23, 2024 12:54 am

3.0.4.0 for sure. Is there a release date for this? I just downloaded 3.0.3.9 planning to upgrade to it so I can use PHP 8 when I saw this post so now want to wait for the latest version.

Running Opencart v3.0.3.9 with multi-stores and the default template from https://www.labeshops.com which has links to all my stores.


User avatar
Expert Member

Posts

Joined
Thu Aug 04, 2011 4:41 am
Location - Florida, USA
Who is online

Users browsing this forum: No registered users and 49 guests