I am thinking about asking Daniel to make a new release now, but need your feedback on what new version number to use:
3.0.3.10 or 3.0.4.0 ?
While it's more like a 3.0.3.10 I am hesitant to use double digits for the lowest level because some extension may use strmp instead of version_compare for supported OC version checks.
Any feedback?
Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
There are some security issues I have been working on, which would be nice if fixes could be included if needed before a release. I will send you a private message about them to get your opinion.
Thanks for your link to the versioning docs. So the 4 levels are major.minor.feature.patch, in which case 3.0.4.0 would make sense indeed, because of added or deleted payment extensions. As regards security patches: Looking forward to your details.ADD Creative wrote: ↑Mon Feb 19, 2024 5:39 pmIt would be nice if https://github.com/opencart/opencart?ta ... versioning was followed for once. Since Opayo has been added it should be 3.0.4.0. But going by that 3.0.4.0 should have been used long ago.
There are some security issues I have been working on, which would be nice if fixes could be included if needed before a release. I will send you a private message about them to get your opinion.
Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig
Got an urgent question that’s keeping you up at night? There might just be a magical inbox ready to help: khnaz35@gmail.com
Enjoy nature
I've sent you a private message.
Version numbers should stick to the rules here:JNeuhoff wrote: ↑Sun Feb 18, 2024 2:07 ama number of further bugfixes. Mostly for making it pass PHPstan level 1 checks, but it also has updates for Opayo and Paypal.
I am thinking about asking Daniel to make a new release now, but need your feedback on what new version number to use:
3.0.3.10 or 3.0.4.0 ?
https://github.com/opencart/opencart
Seeing as "it also has updates for Opayo and Paypal", (and bearing in mind OpenCart has only ever used single digits) it seems that 3.0.4.0 is the logical choice.OpenCart wrote: Versioning
The version is broken down into 4 points e.g 1.2.3.4 We use MAJOR.MINOR.FEATURE.PATCH to describe the version numbers.
A MAJOR is very rare, it would only be considered if the source was effectively re-written or a clean break was desired for other reasons. This increment would likely break most 3rd party modules.
A MINOR is when there are significant changes that affect core structures. This increment would likely break some 3rd party modules.
A FEATURE version is when new extensions or features are added (such as a payment gateway, shipping module etc). Updating a feature version is at a low risk of breaking 3rd party modules.
A PATCH version is when a fix is added, it should be considered safe to update patch versions e.g 1.2.3.4 to 1.2.3.5
UK OpenCart Hosting | OpenCart Audits | OpenCart Support - please email info@antropy.co.uk
define('VERSION', '3.0.4.0');
Will wait for AddCreative for some security patches, and after that we can ask Daniel for a release.
Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig
Ah yes, thanks for the reminder.
@AddCreative, when you have a spare moment, could you create a pull-request, based on what was discussed at https://github.com/opencart/opencart/pull/13390 ?
Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig
On testing this was the absolute minimum of changes needed to fix the time zone affecting the session and API.JNeuhoff wrote: ↑Tue Feb 20, 2024 11:20 pmAh yes, thanks for the reminder.
@AddCreative, when you have a spare moment, could you create a pull-request, based on what was discussed at https://github.com/opencart/opencart/pull/13390 ?
https://github.com/opencart/opencart/pull/13704
Very good work, thank you!
UK OpenCart Hosting | OpenCart Audits | OpenCart Support - please email info@antropy.co.uk
Quick unrelated interjection. By this do you mean the timezone can be changed in the admin now without any problems? If so, it is still not working. Still have to go in and manually set the default.php in system/config, otherwise you're locked out the admin.
v3.0.4.0 php 8.1
I'm here for a reason, if your response is contact a/the developer, just don't reply.
ditto - with many thanks to all
DISCLAIMER:
You should not modify core files .. if you would like to donate a cup of coffee I will write it in a modification for you.
https://www.youtube.com/watch?v=zXIxDoCRc84
Please provide more details. What is your timezone? What's your OS? What browser? What session timeout in your php.ini and/or .user.ini ? Did you do a fresh install?
Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig
v3.0.4.0 php 8.1
I'm here for a reason, if your response is contact a/the developer, just don't reply.
What version (or when did you download using the 3.0.x.x)? Does it have this change? https://github.com/opencart/opencart/pull/13704
Running Opencart v3.0.3.9 with multi-stores and the default template from https://www.labeshops.com which has links to all my stores.
Users browsing this forum: No registered users and 49 guests