But in admin/system/settings edit the store there is a missing label text in general tab( see attached)
Also you cant go past the Local tab, the Option,Image,Mail and server tabs do nothing
Attachments
missing-label.JPG (27.56 KiB) Viewed 5495 times
Fixed.ADD Creative wrote: ↑Sun Jun 07, 2020 7:02 amThe escaping of {{ thumb }} and {{ target }} sill missing on lines 103 and 107 of admin/view/template/common/filemanager.twig.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Ok, I will reverse the changes for the next update. It seem JS is not responding more than once for these particular calls. Perhaps it's a Bootstrap version thing which is why the master branch now uses .card with it. We'll see later on.
Can somebody confirm if the totals are showing accordingly, whether it's from the admin API, cart page or at the end of checkout and on the invoice, since the last update? Note: I am NOT talking about the free checkout nor the master branch lookup for the totals - only on the pre-release version!.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
- Restored admin settings and store pages to its original state.
- Completed integration with currency fixer.
- Fixed {{ thumb }} and {{ target }} (both) in common/filemanager.twig
- Removed config_download_status_id from admin localisation/order_status controller and language.
- Still awaiting inputs on this topic for order totals.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Now, that was embarrassing. Ok, re-uploaded and included the fix from the previous post in the install/opencart.sql and in the 1009.php upgrade file.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Code: Select all
'text' => $this->language->get('extension_heading_title'),
Code: Select all
'text' => $this->language->get('extension')->get('heading_title'),
Code: Select all
if (!$this->request->post['config_limit_admin']) {
$this->error['limit_admin'] = $this->language->get('error_limit');
}
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
- Completed removal of old currency refresh.
- Cleaned code structure in controllers, installation and system/library/cache folder.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
- Cleaned service provider images.
- Removed config_currency_auto from install/opencart.sql and added the removal query in upgrade/1009.php file.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
At lines
1293
1326
1356
1389
1418
1460
Plus you cannot edit any of the four information pages in Catalog/information (About Us, Delivery etc) as it comes up with this error
Code: Select all
Notice: Undefined property: Proxy::getInformationDescriptions in C:\xampp\htdocs\oc3.0.3.4\admin\controller\catalog\information.php on line 76
Ok, all fixed.cyclops12 wrote: ↑Tue Jun 09, 2020 1:41 amAdmin/controller/sale/order.php there are 6 missing closing curly brackets }
At lines
1293
1326
1356
1389
1418
1460
Plus you cannot edit any of the four information pages in Catalog/information (About Us, Delivery etc) as it comes up with this errorCode: Select all
Notice: Undefined property: Proxy::getInformationDescriptions in C:\xampp\htdocs\oc3.0.3.4\admin\controller\catalog\information.php on line 76
Package re-uploaded.
- Standardized all code structures with missing parentheses spaces (not that it really matters but to keep the Opencart code clean).
- Fixed validations from the admin/controller/catalog, common, and customer folder (most of them at least).
- Removed refresh() method from the original admin/model/localisation/currency since two extensions from the master branch have been integrated.
- Still awaiting inputs from testers on this topic about the order totals.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
viewtopic.php?f=202&t=217379.
Full Stack Web Developer :: Send a PM for Custom Work.
Backup and learn how to recover before you make any changes!
I replied to the mentioned topic.sw!tch wrote: ↑Tue Jun 09, 2020 7:01 pmMaybe put a Max version of PHP 7.3 in the release notes. Seems to be a lot of issues with PHP 7.4 that still need to be resolved.
viewtopic.php?f=202&t=217379.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
- Fixed custom fields validation from admin and catalog.
- Added download reports from master branch.
- Moved model review to mail review as an event as per the master branch.
- Fixed leftover conventional method names being called from specific controllers.
- Fixed all order totals from the catalog. All totals from the core should appear accordingly.
- Fixed all $json['redirect'] by adding str_replace to checkout/cart and checkout/checkout routes as per the master branch.
- Fixed all elseif validation from admin to capture database arrays rather than validating the passed ID from URL to capture values from database (master).
- Fixed image database outputs by adding html_entity_decode($var, ENT_QUOTES, 'UTF-8') as per the master branch.
- Modified upgrade/1009.php by fixing the $currency_info with $event_info for the events and added mail_review in the oc_event as a new event_field.
- Added download_report database table as a new table in the install/opencart.sql and upgrade/1009.php file.
- Modified catalog/controller/common/footer.php for alternate ways to track IP addresses as per the master branch.
- Modified parentheses with ternary operators to close at the end of the line instead of before the true case as part of best practices.
- Modified = mt_rand() to = token() as per the master branch.
- Removed duplicated $this->load->model('tool/image') from admin settings controller.
- Trimmed all alert emails.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Users browsing this forum: Majestic-12 [Bot] and 5 guests