Post by ADD Creative » Sun Jun 07, 2020 7:02 am

The escaping of {{ thumb }} and {{ target }} sill missing on lines 103 and 107 of admin/view/template/common/filemanager.twig.

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by cyclops12 » Sun Jun 07, 2020 12:40 pm

Ok just downloaded latest and loads ok now
But in admin/system/settings edit the store there is a missing label text in general tab( see attached)
Also you cant go past the Local tab, the Option,Image,Mail and server tabs do nothing

Attachments

missing-label.JPG

missing-label.JPG (27.56 KiB) Viewed 5500 times


Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Sun Jun 07, 2020 5:08 pm

ADD Creative wrote:
Sun Jun 07, 2020 7:02 am
The escaping of {{ thumb }} and {{ target }} sill missing on lines 103 and 107 of admin/view/template/common/filemanager.twig.
Fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun Jun 07, 2020 5:12 pm

cyclops12 wrote:
Sun Jun 07, 2020 12:40 pm
Ok just downloaded latest and loads ok now
But in admin/system/settings edit the store there is a missing label text in general tab( see attached)
Also you cant go past the Local tab, the Option,Image,Mail and server tabs do nothing
Ok, I will reverse the changes for the next update. It seem JS is not responding more than once for these particular calls. Perhaps it's a Bootstrap version thing which is why the master branch now uses .card with it. We'll see later on.

Can somebody confirm if the totals are showing accordingly, whether it's from the admin API, cart page or at the end of checkout and on the invoice, since the last update? Note: I am NOT talking about the free checkout nor the master branch lookup for the totals - only on the pre-release version!.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun Jun 07, 2020 6:43 pm

Found another confirmed bug on Github: https://github.com/opencart/opencart/pull/7980 . This fix has now been added in the pre-release.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun Jun 07, 2020 6:51 pm

Package re-uploaded.

- Restored admin settings and store pages to its original state.
- Completed integration with currency fixer.
- Fixed {{ thumb }} and {{ target }} (both) in common/filemanager.twig
- Removed config_download_status_id from admin localisation/order_status controller and language.

- Still awaiting inputs on this topic for order totals.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Sun Jun 07, 2020 8:53 pm

You havent emptied the two config files in tar and zip folders

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Sun Jun 07, 2020 9:34 pm

Added fix as per this post: viewtopic.php?f=201&t=218359&p=790088#p790078 .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun Jun 07, 2020 9:39 pm

cyclops12 wrote:
Sun Jun 07, 2020 8:53 pm
You havent emptied the two config files in tar and zip folders
Now, that was embarrassing. Ok, re-uploaded and included the fix from the previous post in the install/opencart.sql and in the 1009.php upgrade file.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Mon Jun 08, 2020 12:45 am

Admin/controller/setting/setting.php line 353 you have

Code: Select all

'text'  => $this->language->get('extension_heading_title'),
Should this be

Code: Select all

'text'  => $this->language->get('extension')->get('heading_title'),
Also lines 942-944 you have

Code: Select all

if (!$this->request->post['config_limit_admin']) {
			$this->error['limit_admin'] = $this->language->get('error_limit');
		}
Should this still be there ?

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Mon Jun 08, 2020 3:40 am

Fixed. Package re-uploaded.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Mon Jun 08, 2020 4:00 am

Found a small wrong variable name in setting. Package re-uploaded. It should be good now.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Mon Jun 08, 2020 9:03 am

- Fixed duplicated $this->load->model('customer/customer') as per this pull request: https://github.com/opencart/opencart/pu ... a9789b8b92 .

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Mon Jun 08, 2020 7:12 pm

Package re-uploaded.

- Completed removal of old currency refresh.
- Cleaned code structure in controllers, installation and system/library/cache folder.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Mon Jun 08, 2020 8:31 pm

Package re-uploaded.

- Cleaned service provider images.
- Removed config_currency_auto from install/opencart.sql and added the removal query in upgrade/1009.php file.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by cyclops12 » Tue Jun 09, 2020 1:41 am

Admin/controller/sale/order.php there are 6 missing closing curly brackets }
At lines
1293
1326
1356
1389
1418
1460
Plus you cannot edit any of the four information pages in Catalog/information (About Us, Delivery etc) as it comes up with this error

Code: Select all

Notice: Undefined property: Proxy::getInformationDescriptions in C:\xampp\htdocs\oc3.0.3.4\admin\controller\catalog\information.php on line 76

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by straightlight » Tue Jun 09, 2020 5:41 am

cyclops12 wrote:
Tue Jun 09, 2020 1:41 am
Admin/controller/sale/order.php there are 6 missing closing curly brackets }
At lines
1293
1326
1356
1389
1418
1460
Plus you cannot edit any of the four information pages in Catalog/information (About Us, Delivery etc) as it comes up with this error

Code: Select all

Notice: Undefined property: Proxy::getInformationDescriptions in C:\xampp\htdocs\oc3.0.3.4\admin\controller\catalog\information.php on line 76
Ok, all fixed.

Package re-uploaded.

- Standardized all code structures with missing parentheses spaces (not that it really matters but to keep the Opencart code clean).
- Fixed validations from the admin/controller/catalog, common, and customer folder (most of them at least).
- Removed refresh() method from the original admin/model/localisation/currency since two extensions from the master branch have been integrated.

- Still awaiting inputs from testers on this topic about the order totals.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by sw!tch » Tue Jun 09, 2020 7:01 pm

Maybe put a Max version of PHP 7.3 in the release notes. Seems to be a lot of issues with PHP 7.4 that still need to be resolved.

viewtopic.php?f=202&t=217379.

Full Stack Web Developer :: Send a PM for Custom Work.
Backup and learn how to recover before you make any changes!


Active Member

Posts

Joined
Sat Apr 28, 2012 2:32 pm

Post by straightlight » Tue Jun 09, 2020 7:36 pm

sw!tch wrote:
Tue Jun 09, 2020 7:01 pm
Maybe put a Max version of PHP 7.3 in the release notes. Seems to be a lot of issues with PHP 7.4 that still need to be resolved.

viewtopic.php?f=202&t=217379.
I replied to the mentioned topic.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Wed Jun 10, 2020 10:43 am

Package re-uploaded.

- Fixed custom fields validation from admin and catalog.
- Added download reports from master branch.
- Moved model review to mail review as an event as per the master branch.
- Fixed leftover conventional method names being called from specific controllers.
- Fixed all order totals from the catalog. All totals from the core should appear accordingly.
- Fixed all $json['redirect'] by adding str_replace to checkout/cart and checkout/checkout routes as per the master branch.
- Fixed all elseif validation from admin to capture database arrays rather than validating the passed ID from URL to capture values from database (master).
- Fixed image database outputs by adding html_entity_decode($var, ENT_QUOTES, 'UTF-8') as per the master branch.
- Modified upgrade/1009.php by fixing the $currency_info with $event_info for the events and added mail_review in the oc_event as a new event_field.
- Added download_report database table as a new table in the install/opencart.sql and upgrade/1009.php file.
- Modified catalog/controller/common/footer.php for alternate ways to track IP addresses as per the master branch.
- Modified parentheses with ternary operators to close at the end of the line instead of before the true case as part of best practices.
- Modified = mt_rand() to = token() as per the master branch.
- Removed duplicated $this->load->model('tool/image') from admin settings controller.
- Trimmed all alert emails.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 6 guests