I am trying to make a function that will collect all category ids back to root for a given category id

Code: Select all

	public function getCategoryPath($category_id) {
		$query = $this->db->query("SELECT parent_id FROM " . DB_PREFIX . "category WHERE category_id = '" . (int)$category_id . "'");
		if($query->row['category_id']){ //if this category exists start the path with it
			$CategoryPath = (string)$query->row['category_id'];
			//get current Category's parrents and add them to the begining of the path till we hit root
			while($query->row['parent_id'] > 0) { //If we just added the root to the path we are done
				$query = $this->db->query("SELECT parent_id FROM " . DB_PREFIX . "category WHERE category_id = '" . (int)$query->row['parent_id'] . "'");
				$CategoryPath = $query->row['parent_id'] . "_" . $CategoryPath;
			}
			return $CategoryPath;
		}
		return false;
	}

Code: Select all

							$canonical_path = this->getCategoryPath(265);
							$this->log = new \Log('MyCatalogPath.log');
							$this->log->write("The Canonical path for category id 265" . " is " . $canonical_path);

Code: Select all

while($query->row['parent_id'] != 0)
 while($query->row['parent_id'] != "0")

Code: Select all

public function getCategoryPath($category_id) {
    if (!is_numeric($category_id) || $category_id <= 0) {
        return '';
    }

    $category_id = (int)$category_id;
    $path = [(string)$category_id];
    $seen_ids = [$category_id];

    while ($category_id > 0) {
        $query = $this->db->query("SELECT parent_id FROM " . DB_PREFIX . "category WHERE category_id = '" . $this->db->escape($category_id) . "'");
        if (!$query->num_rows) {
            break;
        }

        $parent_id = (int)$query->row['parent_id'];
        if (in_array($parent_id, $seen_ids)) {
            break;
        }

        if ($parent_id > 0) {
            $path[] = (string)$parent_id;
            $seen_ids[] = $parent_id;
            $category_id = $parent_id;
        } else {
            break;
        }
    }

    return implode('_', array_reverse($path));
}

Code: Select all

$this->log->write('My controller is being called!');

Code: Select all

		$this->load->model('catalog/category');
		$this->load->model('catalog/manufacturer');
		$this->load->model('catalog/product');
		$this->load->model('journal3/category');
		$this->load->model('journal3/product');

Code: Select all

error_reporting( E_ALL );
ini_set( 'error_reporting', E_ALL );
ini_set( 'display_errors', 'On' );

Code: Select all

 $this->log->write('My controller is being called!'); 

Code: Select all

  <file path="catalog/controller/journal3/catalog.php">
    <operation>
      <search><![CDATA[$data = parent::index($args);]]></search>
      <add position="after"><![CDATA[$this->log->write('My controller is being called!');]]></add>
    </operation>
    <operation>
      <search><![CDATA[public function index($args) {]]></search>
      <add position="before"><![CDATA[
	public function getCategoryPath($category_id) {
		if (!is_numeric($category_id) || $category_id <= 0) {
			return '';
		}

		$category_id = (int)$category_id;
		$path = [(string)$category_id];
		$seen_ids = [$category_id];

		while ($category_id > 0) {
			$query = $this->db->query("SELECT parent_id FROM " . DB_PREFIX . "category WHERE category_id = '" . $this->db->escape($category_id) . "'");
			if (!$query->num_rows) {
				break;
			}

			$parent_id = (int)$query->row['parent_id'];
			if (in_array($parent_id, $seen_ids)) {
				break;
			}

			if ($parent_id > 0) {
				$path[] = (string)$parent_id;
				$seen_ids[] = $parent_id;
				$category_id = $parent_id;
			} else {
				break;
			}
		}

		return implode('_', array_reverse($path));
	}
	  ]]></add>
    </operation>
	<operation>
      <search><![CDATA[foreach ($results as $result) {]]></search>
      <add position="after"><![CDATA[
							// $canonical_path = this->getCategoryPath($parser->getSetting('category'));
							$canonical_path = $this->model_catalog_category->getCategoryPath($parser->getSetting('category'));
							// $canonical_path = "Im working";
							$this->log = new \Log('PDP_Catalog.log');
							$this->log->write("The Canonical path for category id " . $category_info['name'] . " is " . $canonical_path);]]></add>
    </operation>
    <!--
	<operation>
      <search><![CDATA[$this->url->link('product/category', 'path=' . $category_path . '_' . $result['category_id']),]]></search>
      <add position="replace"><![CDATA[$this->url->link('product/category', 'path=' . $canonical_path . '_' . $result['category_id']),]]></add>
    </operation> -->
  </file>
  <file path="catalog/model/catalog/category.php">
  <operation>
      <search><![CDATA[public function getTotalCategories($parent_id) {]]></search>
      <add position="before"><![CDATA[
	public function getCategoryPath($category_id) {
		if (!is_numeric($category_id) || $category_id <= 0) {
			return '';
		}

		$category_id = (int)$category_id;
		$path = [(string)$category_id];
		$seen_ids = [$category_id];

		while ($category_id > 0) {
			$query = $this->db->query("SELECT parent_id FROM " . DB_PREFIX . "category WHERE category_id = '" . $this->db->escape($category_id) . "'");
			if (!$query->num_rows) {
				break;
			}

			$parent_id = (int)$query->row['parent_id'];
			if (in_array($parent_id, $seen_ids)) {
				break;
			}

			if ($parent_id > 0) {
				$path[] = (string)$parent_id;
				$seen_ids[] = $parent_id;
				$category_id = $parent_id;
			} else {
				break;
			}
		}
        $this->log->write("The Canonical path for category id " . $category_id . " is " . $path);
		return implode('_', array_reverse($path));
	}
	  ]]></add>
    </operation>
  </file>

Code: Select all

<?php

use Journal3\Opencart\ModuleController;
use Journal3\Options\Parser;
use Journal3\Utils\Arr;

class ControllerJournal3Catalog extends ModuleController {

	public function __construct($registry) {
		parent::__construct($registry);
		$this->load->model('catalog/category');
		$this->load->model('catalog/manufacturer');
		$this->load->model('catalog/product');
		$this->load->model('journal3/category');
		$this->load->model('journal3/product');
	}

	public function index($args) {
		$data = parent::index($args);

		if (!$data) {
			return null;
		}

		if ($this->settings['carousel']) {
			$this->journal3->document->addStyle('catalog/view/theme/journal3/lib/swiper/swiper.min.css');
			$this->journal3->document->addScript('catalog/view/theme/journal3/lib/swiper/swiper.min.js', 'footer');
		}

		return $data;
	}

	/**
	 * @param Parser $parser
	 * @param $index
	 * @return array
	 */
	protected function parseGeneralSettings($parser, $index) {
		$data = array(
			'classes'         => array(
				'carousel-mode'  => $parser->getSetting('carousel'),
				'image-on-hover' => $parser->getSetting('changeImageOnHover'),
			),
			'carouselOptions' => $this->journal3->carousel($parser->getJs(), 'carouselStyle'),
		);

		if ($this->journal3->settings->get('performanceLazyLoadImagesStatus')) {
			$data['dummy_image'] = $this->model_journal3_image->transparent($parser->getSetting('imageDimensions.width'), $parser->getSetting('imageDimensions.height'));
		}

		return $data;
	}

	/**
	 * @param Parser $parser
	 * @param $index
	 * @return array
	 */
	protected function parseItemSettings($parser, $index) {
		$data = array(
			'classes' => array(
				'swiper-slide' => $this->settings['carousel'],
			),
			'items'   => array(),
			'image'   => '',
			'name'    => '',
			'href'    => '',
		);

		switch ($parser->getSetting('type')) {
			case 'category':
				$category_info = $this->model_catalog_category->getCategory($parser->getSetting('category'));

				if (!$category_info) {
					return null;
				}

				$category_path = (string)$parser->getSetting('category');

				if ($category_prefix = (string)Arr::get($this->module_args, 'category_prefix')) {
					$category_prefix_info = $this->model_catalog_category->getCategory($category_prefix);

					if ($category_prefix_info && ($category_path !== $category_prefix)) {
						$category_path = $category_prefix . '_' . $category_path;
					}
				}

				$data['href'] = $this->url->link('product/category', 'path=' . $category_path);
				$data['name'] = $category_info['name'];

				if ($this->settings['images']) {
					$data['image'] = $this->model_journal3_image->resize($category_info['image'], $this->settings['imageDimensions']['width'], $this->settings['imageDimensions']['height'], $this->settings['imageDimensions']['resize']);
					$data['image2x'] = $this->model_journal3_image->resize($category_info['image'], $this->settings['imageDimensions']['width'] * 2, $this->settings['imageDimensions']['height'] * 2, $this->settings['imageDimensions']['resize']);
				}

				switch ($parser->getSetting('subtype')) {
					case 'category':
						$data['total'] = $this->model_journal3_category->getTotalCategories($parser->getSetting('category'));

						$results = $this->model_journal3_category->getCategories($parser->getSetting('category'), $parser->getSetting('limit'));

						foreach ($results as $result) {
							$data['items'][] = array(
								'name'    => $result['name'],
								'href'    => $this->url->link('product/category', 'path=' . $category_path . '_' . $result['category_id']),
								'image'   => $this->settings['images'] ? $this->model_journal3_image->resize($result['image'], $this->settings['imageDimensions']['width'], $this->settings['imageDimensions']['height'], $this->settings['imageDimensions']['resize']) : '',
								'image2x' => $this->settings['images'] ? $this->model_journal3_image->resize($result['image'], $this->settings['imageDimensions']['width'] * 2, $this->settings['imageDimensions']['height'] * 2, $this->settings['imageDimensions']['resize']) : '',
							);
						}

						break;

					case 'product':
						$filter_data = array(
							'filter_category_id' => $parser->getSetting('category'),
							'limit'              => $parser->getSetting('limit'),
							'sort'               => 'p.sort_order',
						);

						$data['total'] = $this->model_journal3_product->getTotalProducts($filter_data);

						$results = $this->model_journal3_product->getProducts($filter_data);

						foreach ($results as $result) {
							$data['items'][] = array(
								'name'    => $result['name'],
								'href'    => $this->url->link('product/product', 'path=' . $category_path . '&product_id=' . $result['product_id']),
								'image'   => $this->settings['images'] ? $this->model_journal3_image->resize($result['image'], $this->settings['imageDimensions']['width'], $this->settings['imageDimensions']['height'], $this->settings['imageDimensions']['resize']) : '',
								'image2x' => $this->settings['images'] ? $this->model_journal3_image->resize($result['image'], $this->settings['imageDimensions']['width'] * 2, $this->settings['imageDimensions']['height'] * 2, $this->settings['imageDimensions']['resize']) : '',
							);
						}

						break;

					default:
						return null;
				}

				break;

			case 'manufacturer';
				$manufacturer_info = $this->model_catalog_manufacturer->getManufacturer($parser->getSetting('manufacturer'));

				if (!$manufacturer_info) {
					return null;
				}

				$data['href'] = $this->url->link('product/manufacturer/info', 'manufacturer_id=' . $parser->getSetting('manufacturer'));
				$data['name'] = $manufacturer_info['name'];

				if ($this->settings['images']) {
					$data['image'] = $this->model_journal3_image->resize($manufacturer_info['image'], $this->settings['imageDimensions']['width'], $this->settings['imageDimensions']['height'], $this->settings['imageDimensions']['resize']);
					$data['image2x'] = $this->model_journal3_image->resize($manufacturer_info['image'], $this->settings['imageDimensions']['width'] * 2, $this->settings['imageDimensions']['height'] * 2, $this->settings['imageDimensions']['resize']);
				}

				$filter_data = array(
					'filter_manufacturer_id' => $parser->getSetting('manufacturer'),
					'limit'                  => $parser->getSetting('limit'),
					'sort'                   => 'p.sort_order',
				);

				$data['total'] = $this->model_journal3_product->getTotalProducts($filter_data);

				$results = $this->model_journal3_product->getProducts($filter_data);

				foreach ($results as $result) {
					$data['items'][] = array(
						'name'    => $result['name'],
						'href'    => $this->url->link('product/product', 'manufacturer_id=' . $result['manufacturer_id'] . '&product_id=' . $result['product_id']),
						'image'   => $this->settings['images'] ? $this->model_journal3_image->resize($result['image'], $this->settings['imageDimensions']['width'], $this->settings['imageDimensions']['height'], $this->settings['imageDimensions']['resize']) : '',
						'image2x' => $this->settings['images'] ? $this->model_journal3_image->resize($result['image'], $this->settings['imageDimensions']['width'] * 2, $this->settings['imageDimensions']['height'] * 2, $this->settings['imageDimensions']['resize']) : '',
					);
				}

				break;

			default:
				return null;
		}

		return $data;
	}

	/**
	 * @param Parser $parser
	 * @param $index
	 * @return array
	 */
	protected function parseSubitemSettings($parser, $index) {
		return array();
	}

}

Code: Select all

<?xml version="1.0" encoding="UTF-8"?>
<modification>
  <name>Journal3 Catalog Logging + Category Canonical Path</name>
  <code>j3_catalog_logging_category_path</code>
  <version>1.0</version>
  <author><![CDATA[<font color="#19700E"><b>khnaz35</b></font>]]></author>
  <link>mailto:khnaz35@gmail.com</link>

  <!-- =========================
       CONTROLLER: journal3/catalog.php
       ========================= -->
  <file path="catalog/controller/journal3/catalog.php">

    <!-- Log immediately when index() is entered -->
    <operation>
      <search><![CDATA[public function index($args) {]]></search>
      <add position="after"><![CDATA[
        if (isset($this->log)) {
          $this->log->write('[Journal3\\Catalog::index] Entered with args: ' . (is_scalar($args) ? (string)$args : json_encode($args)));
        }
      ]]></add>
    </operation>

    <!-- Log right after parent::index($args) returns -->
    <operation>
      <search><![CDATA[$data = parent::index($args);]]></search>
      <add position="after"><![CDATA[
        if (isset($this->log)) {
          $this->log->write('[Journal3\\Catalog::index] parent::index completed.');
        }
      ]]></add>
    </operation>

    <!-- When looping results, compute and log canonical path safely -->
    <operation>
      <search><![CDATA[foreach ($results as $result) {]]></search>
      <add position="after"><![CDATA[
        if (isset($this->log)) {
          $this->log->write('[Journal3\\Catalog::index] Iterating result. category_id: ' . (isset($result['category_id']) ? (int)$result['category_id'] : 'n/a'));
        }

        $canonical_path = '';
        try {
          // Journal3 typically exposes $parser; guard for safety.
          if (isset($parser) && is_object($parser) && method_exists($parser, 'getSetting')) {
            $category_setting = $parser->getSetting('category');
            if (isset($this->log)) {
              $this->log->write('[Journal3\\Catalog::index] parser->getSetting("category") => ' . (is_scalar($category_setting) ? (string)$category_setting : json_encode($category_setting)));
            }

            if (!empty($category_setting) && is_numeric($category_setting)) {
              if (isset($this->load)) {
                $this->load->model('catalog/category');
              }
              if (isset($this->model_catalog_category) && method_exists($this->model_catalog_category, 'getCategoryPath')) {
                $canonical_path = $this->model_catalog_category->getCategoryPath((int)$category_setting);
              }
            }
          } else {
            if (isset($this->log)) {
              $this->log->write('[Journal3\\Catalog::index] $parser missing or getSetting not available.');
            }
          }
        } catch (\Exception $e) {
          if (isset($this->log)) {
            $this->log->write('[Journal3\\Catalog::index] Exception while computing canonical path: ' . $e->getMessage());
          }
        }

        if (isset($this->log)) {
          $logged_name = isset($category_info['name']) ? $category_info['name'] : 'unknown';
          $this->log->write('[Journal3\\Catalog::index] Canonical path for category "' . $logged_name . '" = ' . (string)$canonical_path);
        }
      ]]></add>
    </operation>

    <!-- Optional: If you later want to switch links to use $canonical_path, uncomment your replace op.
    <operation>
      <search><![CDATA[$this->url->link('product/category', 'path=' . $category_path . '_' . $result['category_id']),]]></search>
      <add position="replace"><![CDATA[$this->url->link('product/category', 'path=' . $canonical_path . '_' . $result['category_id']),]]></add>
    </operation>
    -->
  </file>

  <!-- =========================
       MODEL: catalog/model/catalog/category.php
       ========================= -->
  <file path="catalog/model/catalog/category.php">
    <!-- Inject getCategoryPath() with comprehensive logging -->
    <operation>
      <search><![CDATA[public function getTotalCategories($parent_id) {]]></search>
      <add position="before"><![CDATA[
        /**
         * Build full "path" for a category by walking up the tree to root.
         * Logs lifecycle, guards cycles, and returns a string like "12_3_1".
         */
        public function getCategoryPath($category_id) {
          if (!is_numeric($category_id) || (int)$category_id <= 0) {
            if (isset($this->log)) {
              $this->log->write('[Model\\Catalog\\Category::getCategoryPath] Invalid category_id: ' . print_r($category_id, true));
            }
            return '';
          }

          $category_id = (int)$category_id;
          $path = [$category_id];
          $seen_ids = [$category_id];

          if (isset($this->log)) {
            $this->log->write('[Model\\Catalog\\Category::getCategoryPath] Start. category_id=' . $category_id);
          }

          while ($category_id > 0) {
            $query = $this->db->query("SELECT parent_id FROM " . DB_PREFIX . "category WHERE category_id = '" . (int)$category_id . "'");

            if (!$query->num_rows) {
              if (isset($this->log)) {
                $this->log->write('[Model\\Catalog\\Category::getCategoryPath] No DB row for category_id=' . $category_id . '; stopping.');
              }
              break;
            }

            $parent_id = (int)$query->row['parent_id'];

            if (in_array($parent_id, $seen_ids, true)) {
              if (isset($this->log)) {
                $this->log->write('[Model\\Catalog\\Category::getCategoryPath] Detected cycle at parent_id=' . $parent_id . '; current path=' . implode('_', array_reverse(array_map('strval', $path))));
              }
              break;
            }

            if ($parent_id > 0) {
              $path[] = $parent_id;
              $seen_ids[] = $parent_id;
              if (isset($this->log)) {
                $this->log->write('[Model\\Catalog\\Category::getCategoryPath] Ascend to parent_id=' . $parent_id);
              }
              $category_id = $parent_id;
            } else {
              if (isset($this->log)) {
                $this->log->write('[Model\\Catalog\\Category::getCategoryPath] Reached root (parent_id=0).');
              }
              break;
            }
          }

          $final_path = implode('_', array_reverse(array_map('strval', $path)));

          if (isset($this->log)) {
            $this->log->write('[Model\\Catalog\\Category::getCategoryPath] Final path=' . $final_path);
          }

          return $final_path;
        }
      ]]></add>
    </operation>
  </file>
</modification>