Wrong discount price is appearing for Special products while selecting discount type as "Percentage" or "Subtract".

No third-party extension is installed I'm only using default Opencart modules like Featured & Specials which comes with default Opencart extension. In order to reproduce the issue please enable and use the both modules in the homepage layout.

• Go to Catalog > Product via sidebar in Admin Dashboard.

• Create a new product or edit an existing product.

• Select the Discount tab.

• Add a new discount and set the type to "Percentage" or "Subtract"

| Customer Group | Quantity | Priority | Price   | Type         | Special | Date Start  | Date End   |
|----------------|----------|----------|---------|--------------|---------|-------------|------------|
| Default        | 1        | 0        | 20.0000 |  Percentage  |   true  | mm/dd/yyyy  | mm/dd/yyyy |

• Click on save and view the products in homepage.

JNeuhoff wrote: ↑

Thu May 29, 2025 5:16 pm

Could be related to this issue: https://github.com/opencart/opencart/issues/14755
Try the master branch (upcoming 4.1.0.4) to see whether this issue still exists or not.

| Customer Group | Quantity | Priority | Price   | Type         | Special | Date Start  | Date End   |
|----------------|----------|----------|---------|--------------|---------|-------------|------------|
| Default        | 1        | 0        | 40.0000 |  Percentage  |   true  | mm/dd/yyyy  | mm/dd/yyyy |

grgr wrote: ↑

Thu May 29, 2025 7:26 am

Because that is not how it is working.
Specials and discounts are now on the same line which is a touch confusing I guess.

grgr wrote: ↑

Thu May 29, 2025 7:26 am

For a discount you add the amount and select Fixed/Subtract/percent, you can add many discounts (so you get buy 2 or more = x$, buy 10 or more = $y)
For specials, you only add the one line, the price and select the Special switch.

grgr wrote: ↑

Thu May 29, 2025 7:26 am

You can't have a product on discount and special at the same time.

• Calculated discount price - can be displayed if special is disabled.

• Old price or original price in strike-through - can only be displayed if special is enabled.

• Percentage - Need to override the product/thumb view and calculate the percentage using twig tags and filters.
  It is possible for specials only as other cases does not provide any another amount value for calculation. Please check the code below for more details.

{% if price %}
	 <div class="price d-flex gap-2">
		{% if not special %}
			<span class="price-new">{{ price }}</span>
		{% else %}
			{% set old_price = price|replace({(currency_symbol): '', ',': ''}) %}
			{% set new_price = special|replace({(currency_symbol): '', ',': ''}) %}
			{% set discount = ((old_price - new_price) / old_price) * 100 %}
			<div class="ribbon">
				<span>{{ discount|number_format(0) }}% OFF</span>
			</div>
			<span class="price-new">{{ special }}</span> <span class="price-old fw-light">{{ price }}</span>
		{% endif %}
		{% if tax %}
			<span class="price-tax">{{ text_tax }} {{ tax }}</span>
		{% endif %}
	</div>
{% endif %}