[SOLVED] Receive an email anytime admin logs in

ADD Creative wrote: ↑

Thu Jan 02, 2025 8:00 pm

Both $_SERVER['HTTP_CLIENT_IP'] and $_SERVER['HTTP_X_FORWARDED_FOR'] should not be trusted. Only use them if you are using a proxy that sets them.

If you do need to use them, then pass both though filter_var or at the very least pass through htmlspecialchars (or use $this->request->server version) if used in HTML. Otherwise HTML could be injected into you email. Yes they would need an admin login, but still better to do things the correct way.

nonnedelectari wrote: ↑

Thu Jan 02, 2025 8:37 pm

Being "trusted" vs being a proper ip address are two different things.
This is about the fact that $_SERVER['HTTP_X_FORWARDED_FOR'] may not contain a single ip address but a comma separated string of ip addresses.
I.e. a format issue.
Whether you should or should not trust what is ultimately in there is a different issue.

supak111 wrote: ↑

Thu Jan 02, 2025 3:23 pm

You use the code below if you are making an ocmod for installation through admin->extensions->installer page...
If you are hardcoding the code into the login.php file directly (hardcoding is never really recommended), you don't need the code below, and you don't need a bunch of other code from my original file

Code: Select all

 <search>
                <![CDATA[$this->session->data['user_token'] = token(32);]]>
            </search>
            <add position="after">
                <![CDATA[

supak111 wrote: ↑

Fri Jan 03, 2025 10:29 am

Post a copy of your full XML ocmod file

PS did you refresh your modification after installation??
.

<?xml version="1.0" encoding="utf-8"?>
<modification>
    <name>Send email on Admin Login</name>
    <code>Send email On Admin Login</code>
    <version>1.0</version>
    <author>opencart.com username: MyOpe</author>
    <link>https://forum.opencart.com/viewtopic.php?p=876242</link>
    <file path="admin/controller/common/login.php">
        <operation error="skip">
 <search>
                <![CDATA[$this->session->data['user_token'] = token(32);]]>
            </search>
            <add position="after">
                <![CDATA[

$ip_address = '';
if (!empty($_SERVER['HTTP_CLIENT_IP'])) {
	$ip_address = $_SERVER['HTTP_CLIENT_IP'];
} elseif (!empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
	$ip_list = explode(',',$_SERVER['HTTP_X_FORWARDED_FOR']);
	$ip = trim($ip_list[0]);
	if (filter_var ($ip, FILTER_VALIDATE_IP)) $ip_address = $ip;
}
if ($ip_address === '') $ip_address = $_SERVER['REMOTE_ADDR'];

if (!empty($_SERVER['HTTP_REFERER'])) {                  
    $refer = $_SERVER['HTTP_REFERER'];
} else {
    $refer = 'referrer not found';
}

$to = "jrr@flippers.com"; //the address the email is being sent to
$subject = "Admin LOGIN"; //the subject of the message
$msg = "Admin LOGIN
<br><br>
Admin:  {$this->request->post['username']}<br>
Referer:  {$refer}<br>
From IP:  <a href='https://flippers.com/catalog_oc/admin/ip/{$ip_address}'>https://flippers.com/catalog_oc/admin/ip/{$ip_address}</a><br>"; //the message of the email

// Set content-type header for sending HTML email 
$headers = "MIME-Version: 1.0" . "\r\n"; 
$headers .= "Content-type:text/html;charset=UTF-8" . "\r\n"; 

// Additional headers 
$headers .= 'From: JRR <noreply@flippers.com>' . "\r\n";

mail($to, $subject, $msg, $headers); //send the email

]]>
            </add>
        </operation>
    </file>
</modification>

 <search>
                <![CDATA[$this->session->data['user_token'] = token(32);]]>
            </search>
            <add position="after">
                <![CDATA[

by mona wrote: ↑

Sat Jan 04, 2025 9:53 am

Try this and check your error logs if it does not work
Tested and Send Email on Admin Login (seoal for short) is working on 3.0.4.0

IMPORTANT : this download has site specific addresses

supak111 wrote: ↑

Sat Jan 04, 2025 10:25 am

I just compared his code to your new OCmod code and there is nothing in there that I can see that would make his code not work lol.

No clue why his code didn't work lol

.

jrr wrote: ↑

Sat Jan 04, 2025 4:30 pm

There is something wrong with my compress function in osx Sonoma. I tried expanding Mona's extension and then recompressed it using osx's native compress that appears to make zipped files but I realized that it did NOT actually compress the file. Mona's compressed file was 1K in size, and mine was 3K.

I then compressed this on a Windows XP machine and tried uploading the XP Zipped file and see if that worked...nope same null result.

Something is wrong with how the compressed file is being created on both Windows and OSX.

jrr wrote: ↑

Sat Jan 04, 2025 4:30 pm

Mona's compressed file was 1K in size, and mine was 3K.

by mona wrote: ↑

Sat Jan 04, 2025 9:32 pm

jrr wrote: ↑

Sat Jan 04, 2025 4:30 pm

Mona's compressed file was 1K in size, and mine was 3K.

My mac will zip it to 2k

OSWorX wrote: ↑

Sat Jan 04, 2025 10:47 pm

by mona wrote: ↑

Sat Jan 04, 2025 9:32 pm

jrr wrote: ↑

Sat Jan 04, 2025 4:30 pm

Mona's compressed file was 1K in size, and mine was 3K.

My mac will zip it to 2k

And my Atari can do that to 720 B
7zip use 1.12 KB

supak111 wrote: ↑

Sat Jan 04, 2025 11:58 pm

I do all my coding and compression on a M1 MacBook Air and never had issues with a compressed ocmod "install.xml"

Double click the install.xml file, and click: "Compress install.xml", then rename the compressed file so that it ends with: XXX.ocmod.zip

.

by mona wrote: ↑

Sat Jan 04, 2025 11:39 pm

@OSWorX It was to jrr not you.
Point being jrr has made an assumption that the zip function is the problem because of the difference in file size.
This is not a reliable way to debug a problem.
Each zip and rounding method will produce a different result.