Opencart Image Mananger not opening

Hi there,
this regards Opencard 3.0.xx-Maintenance and the current github pull from https://github.com/opencart/opencart-3

I am currently trying to setup a store, and I am using opencart 3 because my payment plugins are not available for opencart 4 yet. Installation goes through fine, but after logging in into the admin panel, and try to change the store logo or any product image, the image manager doesnt open. I get this instead:


I tried this with a current firefox esr build, chrome on linux, chrome on windows. When clicking onto the image to replace it, there is no network traffic(apache2 server log is not showing any activity, firefox http live headers doesnt record anything). There are no errors in developer console of firefox(F12)

Is there anything I can do to get the image manager working? Btw, this picture was taken with german language addon installed, however i get the same result on a naked fresh install.

Please create an issue case in the opencart-3 repository. This addressed issue may need to be looked at.

Yes, I can confirm this issue for the 3.0.x.x_Maintenance, too. I am now looking into it. Perhaps an issue with the newer jquery?

Update: Tried all the jquery versions and PHP versions, no change. Maybe the issue is caused by bootstrap 3.4.1?

Mine isn't updated, yet. Reporting user mentioned both packages on the first post.

straightlight wrote: ↑

Tue Jul 11, 2023 12:23 am

Mine isn't updated, yet. Reporting user mentioned both packages on the first post.

Hmm, that's strange. opencart-3 uses bootstrap 3.3.1, 3.0.x.x_Maintenance uses bootstrap 3.4.1, but both of them have this issue.
Something else must cause this issue. Have to investigate. Let me know if you find the cause of it.

It might have something to do with the bootstrap sanitizer. The solution as suggested on this forum thread seems to solve this issue for 3.0.x.x_Maintenance which uses bootstrap 3.4.1.

To straightlight: Can you also try it on opencart-3 and let us know what you get?

JNeuhoff wrote: ↑

Tue Jul 11, 2023 1:01 am

It might have something to do with the bootstrap sanitizer. The solution as suggested on this forum thread seems to solve this issue for 3.0.x.x_Maintenance which uses bootstrap 3.4.1.

To straightlight: Can you also try it on opencart-3 and let us know what you get?

Please provide the pull request URL from the maintenance branch that shows the change of bootstrap 3.4.1 with sanitize: false. I'll take a look at it.

straightlight wrote: ↑

Tue Jul 11, 2023 1:20 am

JNeuhoff wrote: ↑

Tue Jul 11, 2023 1:01 am

It might have something to do with the bootstrap sanitizer. The solution as suggested on this forum thread seems to solve this issue for 3.0.x.x_Maintenance which uses bootstrap 3.4.1.

To straightlight: Can you also try it on opencart-3 and let us know what you get?

Please provide the pull request URL from the maintenance branch that shows the change of bootstrap 3.4.1 with sanitize: false. I'll take a look at it.

The only pull request in the 3.0.x.x_Maintenance branch for this issue is this one: https://github.com/opencart/opencart/co ... ca88b1c287

See also this: https://github.com/opencart/opencart-3/issues/188

JNeuhoff wrote: ↑

Tue Jul 11, 2023 1:50 am

straightlight wrote: ↑

Tue Jul 11, 2023 1:20 am

JNeuhoff wrote: ↑

Tue Jul 11, 2023 1:01 am

It might have something to do with the bootstrap sanitizer. The solution as suggested on this forum thread seems to solve this issue for 3.0.x.x_Maintenance which uses bootstrap 3.4.1.

To straightlight: Can you also try it on opencart-3 and let us know what you get?

Please provide the pull request URL from the maintenance branch that shows the change of bootstrap 3.4.1 with sanitize: false. I'll take a look at it.

The only pull request in the 3.0.x.x_Maintenance branch for this issue is this one: https://github.com/opencart/opencart/co ... ca88b1c287

See also this: https://github.com/opencart/opencart-3/issues/188

The reason why we're seeing this code is because you just committed to it less than an hour ago.

@straightlight: Actually, I just tested the current opencart-3, and it works fine there, without the bugfix as suggested on this forum thread.

This makes me think the issue was caused after the upgrade from bootstrap 3.3.1 to 3.4.1 in the 3.0.x.x_Maintenance branch. Anyway, for the latter I added the to the admin/view/javascript/common.js, to make it work there for bootstrap 3.4.1, too.

I can confirm that after making said change to /admin/view/javascript/common.js the image manager works. Thank you all!

JNeuhoff wrote: ↑

Tue Jul 11, 2023 5:53 pm

This makes me think the issue was caused after the upgrade from bootstrap 3.3.1 to 3.4.1 in the 3.0.x.x_Maintenance branch.

The sanitize option was only added in 3.4.1 to fix an XSS vulnerability. Before 3.4.1 no sanitization was done, so there was no need to disable it.

https://blog.getbootstrap.com/2019/02/1 ... and-3-4-1/

@ADD Creative: Thanks for the clarification.

antares0 wrote: ↑

Tue Jul 11, 2023 7:55 pm

I can confirm that after making said change to /admin/view/javascript/common.js the image manager works. Thank you all!

Glad to hear that this has fixed it for you.

Please add '[SOLVED]' to the beginning of this original forum thread title.

JNeuhoff wrote: ↑

Tue Jul 11, 2023 5:53 pm

@straightlight: Actually, I just tested the current opencart-3, and it works fine there, without the bugfix as suggested on this forum thread.

This makes me think the issue was caused after the upgrade from bootstrap 3.3.1 to 3.4.1 in the 3.0.x.x_Maintenance branch. Anyway, for the latter I added the

Code: Select all

santize: false,

to the admin/view/javascript/common.js, to make it work there for bootstrap 3.4.1, too.

By doing that, extension theme developer that will depend on content-x won't be able to propagate it.

straightlight wrote: ↑

Tue Jul 11, 2023 11:47 pm

By doing that, extension theme developer that will depend on content-x won't be able to propagate it.

This is for the admin backend, and only for the bootstrap popover function, it shouldn't affect the frontend theme. If you know a better solution let me know.

actually, before marking this as solved, while the basic functionality of the image manager now works, trying to create a directory still gives the same trouble(i.e. no dialog popping up). I havent figured out where to change the code for this, but since i can manually create and upload directories/images and only need the picker to select them, this is a lower end issue as far as i am concerned - I still believe it should be brought up

antares0 wrote: ↑

Wed Jul 12, 2023 5:20 pm

actually, before marking this as solved, while the basic functionality of the image manager now works, trying to create a directory still gives the same trouble(i.e. no dialog popping up). I havent figured out where to change the code for this, but since i can manually create and upload directories/images and only need the picker to select them, this is a lower end issue as far as i am concerned - I still believe it should be brought up

Thanks for bringing this up. There are still internal codes from bootstrap that uses its own resource to load the required features and adding a switch case as a compatible solution can still leave some leftover issues. This limitation has been going on for many years and hope to find a workaround for this eventually.

antares0 wrote: ↑

Wed Jul 12, 2023 5:20 pm

actually, before marking this as solved, while the basic functionality of the image manager now works, trying to create a directory still gives the same trouble(i.e. no dialog popping up). I havent figured out where to change the code for this, but since i can manually create and upload directories/images and only need the picker to select them, this is a lower end issue as far as i am concerned - I still believe it should be brought up

Thanks for pointing it out. I have now uploaded the same popover bugfix for the admin/common/filemanager.twig. Creating a directory should now work again.