Great.Qphoria wrote:That is no longer used and was "partially" removed in 1.4.8b and will be completely removed in 1.4.9
Therefore we can assume the next release very soon??
* Additonally, maybe the backend URLs will be fixed also to be XHTML valid (like the new 'token', 'product_id', 'page' (and maybe more)?
* And this long existing, but nasty issue with the 'line 121 column 5 - Warnung: <li> anchor "store" already defined' can be fixed also?
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
Just upgraded from 1.4.0 to 1.4.8b
I try to access "System->Localization->Measurement Classes" and I am getting...
Permission Denied!
...
Also after upgrading, all my products set for Inches, were automatically changed to Centimeters
I try to access "System->Localization->Measurement Classes" and I am getting...
Permission Denied!
...
Also after upgrading, all my products set for Inches, were automatically changed to Centimeters
1.4.8b Bugs I have found
1) When in the Storefront, on the left select ANY manufacturer. Then change the product "Sort By" to anything other than default, then change it back to default, You will get an Error: "Manufacturer not found!"
1) When in the Storefront, on the left select ANY manufacturer. Then change the product "Sort By" to anything other than default, then change it back to default, You will get an Error: "Manufacturer not found!"
Not sure if it's been noticed but
and
both need to have
changed to
To maintain a valid document
Also is in the template which should be changed to (bestseller only)
Code: Select all
/catalog/controller/module/bestseller.phpCode: Select all
/catalog/controller/module/latest.phpCode: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id']; Code: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id']; Also
Code: Select all
width="1"Code: Select all
style="width:1px"those changes were other bugs not related to yours. I have confirmed on the demo that what you mentioned is a bug.12oclocker wrote:I made those changes, but the bug is still there. humm
OpenCart commercial mods and development http://spotonsolutions.net
Layered Navigation
Shipment Tracking
Vehicle Year/Make/Model Filter
These are NOT the only one!JAY6390 wrote:Not sure if it's been noticed butandCode: Select all
/catalog/controller/module/bestseller.phpboth need to haveCode: Select all
/catalog/controller/module/latest.phpchanged toCode: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id'];To maintain a valid documentCode: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id'];
Cannot understand why the URL building goes NOT through a function (as it was once a while ago).
So many not needed lines if all those links were build by $this->model_tool_seo_url->rewrite() - one line instead 5!
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
I totally agree, but think having to write that to rewrite a url is a bit much too to be honest, this should be a helper and a lot shorter to write
$this->rewrite
or $this->url
There shouldn't be any str_replace('&', '&', ...) or vice versa either. urlencode was made for this
$this->rewrite
or $this->url
There shouldn't be any str_replace('&', '&', ...) or vice versa either. urlencode was made for this
Also agreed.JAY6390 wrote:I totally agree, but think having to write that to rewrite a url is a bit much too to be honest, this should be a helper and a lot shorter to write
$this->rewrite
or $this->url
There shouldn't be any str_replace('&', '&', ...) or vice versa either. urlencode was made for this
But if the current method is used further, a simple addition to the rewrite function like 'false' and the url comes back as it was (the model still exists).
So this is just one line.
Same goes with all those currently stupid additons for the token.
In nearly every controller there are between 3 and 20 calls for that.
Would have been the controller 1 variable like $this->_url this could be handled much easier, the code would be much cleaner and - the scripts would be much smaller!
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
So did I - want to use my time for much better thingsJAY6390 wrote:I actually have done something similar with the latest mods I've made
$this->_u()
which adds a token if needed
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
I just noticed the little [+] beside my products on the Home page is NOT adding the products to the Cart, instead it's just taking me to the product page. But for the Online Demo it works fine. I upgraded from 1.4.0 to 1.4.8b, anyone else run into this problem or know a fix?
You really should read more before posting. This is NOT a bug, the product you've chosen has options, therefore it goes to the product page.12oclocker wrote:I just noticed the little [+] beside my products on the Home page is NOT adding the products to the Cart, instead it's just taking me to the product page. But for the Online Demo it works fine. I upgraded from 1.4.0 to 1.4.8b, anyone else run into this problem or know a fix?
Norman in 't Veldt
Moderator OpenCart Forums
_________________ READ and Search BEFORE POSTING _________________
Our FREE search: Find your answer FAST!.
[How to] BTW + Verzend + betaal setup.
OSWorX wrote: Cannot understand why the URL building goes NOT through a function (as it was once a while ago).
So many not needed lines if all those links were build by $this->model_tool_seo_url->rewrite() - one line instead 5!
I'm trying guys.. I really am. Daniel is very much opposed to the old method of url class. He has plans for a real url class that can be constructed. Something like this I guess:JAY6390 wrote:I totally agree, but think having to write that to rewrite a url is a bit much too to be honest, this should be a helper and a lot shorter to write
$this->rewrite
or $this->url
There shouldn't be any str_replace('&', '&', ...) or vice versa either. urlencode was made for this
Code: Select all
$action_url = new Class('Url');
$action_url->route = 'product/product';
$action_url->getToken();
$action_url->vars = array(
'product_id' => '1',
'sort' => 'p.price',
);
$action = $action_url->getHref();
Last edited by JAY6390 on Thu Jul 22, 2010 4:52 am, edited 1 time in total.
Reason: code corrected ;)
Reason: code corrected ;)
Who is online
Users browsing this forum: No registered users and 16 guests
