OC 3.0.3.8 Maintenance Branch - PHP Warning: preg_replace(): Passing null to parameter #3 ($subject) in action.php

Hi,

In OpenCart's error log I get following error:
OpenCart's version: 3.0.3.8 Maintenance Branch from GitHub - Clean installation, I didnt made any changes
PHP version: 8.1.16

How to fix above error?
OpenCart's Maintenance Branch fixed all errors with PHP 8.1 but this one remains.

With best regards
Lukas

Similar error is shown while trying to do a backup:

If you are serious about getting some help here, then you have to provide some more details, since nobody else has this issue.

septero wrote: ↑

Thu Apr 27, 2023 2:20 am

Similar error is shown while trying to do a backup:

Code: Select all

PHP Unknown:  str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /xxx/model/tool/backup.php on line 47

This seems to be caused by null values in the database. I found some in the oc_googleshopping_product table used by the built in Google Shopping Extension.

Need to add a check for $value being null before line 47 of admin/model/tool/backup.php.

septero wrote: ↑

Thu Apr 27, 2023 12:11 am

Hi,

In OpenCart's error log I get following error:

Code: Select all

PHP Unknown:  preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in xxx/storage/modification/system/engine/action.php on line 65

OpenCart's version: 3.0.3.8 Maintenance Branch from GitHub - Clean installation, I didnt made any changes
PHP version: 8.1.16

How to fix above error?
OpenCart's Maintenance Branch fixed all errors with PHP 8.1 but this one remains.

With best regards
Lukas

Which route do you see this error message?

ADD Creative wrote: ↑

Thu Apr 27, 2023 7:48 am

This seems to be caused by null values in the database. I found some in the oc_googleshopping_product table used by the built in Google Shopping Extension.

Need to add a check for $value being null before line 47 of admin/model/tool/backup.php.

I have now applied a bugfix for it to the 3.0.x.x_Maintenance branch.

Thanks for the fix. Now backup is working without any issues

Regarding the error message for action.php I am having it on my main site and on product site. OpenCart is installed on localhost.

There was a topic about this error but without any clear solution: viewtopic.php?t=230071

Below are sample OpenCart shop on which this error is visible:
https://www.pinvoordeel.nl/index.php?route=common/home

I hope that will help fix the error.

Check you don't have any missing files. That error could be caused by a missing controller file that is being call by a route, pre_action or an event.

One of your error messages is about line 103 in catalog/controller/startup/startup.php . There is no code on that line, hence your startup.php appears to be corrupted. All your other error messages are about modified core files, so it looks like these are caused by some of you OCmod-based modifications.

Thanks for the answers. I have further investigated the error.
I have checked server error logs and it seems that OpenCart's googleshopping extension is causing the problem. Error occurs each time where there is some fetching from feed/gshopping ("GET /index.php?route=extension/feed/gshopping HTTP/1.1" 404 123636 "-" "google-xrawler").

Each day I have about two action.php errors which occurs exactly in the same time when gshopping feed is being checked. In previous post there was a notice that this can be caused by some null values in database oc_googleshopping_product table used by the built in Google Shopping Extension.

I have uninstalled Google Shopping extension and I hope it will fix the error. For those which will use gshopping maybe there can be a check for $value being null before line 65 in action.php?

You are right. It's obvious to me now. /index.php?route=extension/feed/gshopping produces a 404 because the extension/feed/gshopping controller file doesn't exist. So even /index.php?route=anything will cause the error in system/engine/action.php.

The Action class constructor only sets $this->route if the file exists. If they is no controller file, $this->route will still be null. So it does need some sort of check. No point trying to include a file that doesn't exist.

ADD Creative wrote: ↑

Fri Apr 28, 2023 6:10 pm

You are right. It's obvious to me now. /index.php?route=extension/feed/gshopping produces a 404 because the extension/feed/gshopping controller file doesn't exist. So even /index.php?route=anything will cause the error in system/engine/action.php.

The Action class constructor only sets $this->route if the file exists. If they is no controller file, $this->route will still be null. So it does need some sort of check. No point trying to include a file that doesn't exist.

Thank you for clarification. Is there a possibility to fix the error in system/engine/action.php so it will check if there is no controller file ($this->route is null)?

The simplest way to get stop the error is to change. To. Maybe a more correct way would be to add a check for the route being null in the execute method.

I have the same error.
using 3.0.3.8 maintenance release with PHP 8.1.x
PHP Unknown: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /home/.../storage/modification/system/engine/action.php on line 65

tried adding to line 15 : private $route = ''; # this doesn't work
The issue arises when i try and press delete on an extension that may have already been deleted (Extensions > Installer > delete an extension)

hence line 65 fails: $class = 'Controller' . preg_replace('/[^a-zA-Z0-9]/', '', $this->route);

**** update
this fix does work, i had forgotten to clear modifications, then refresh. once refreshed, the fix works:
line 15 : private $route = '';

Hey,
I came to the same error but my OC is 3.0.3.9, 3 week old opencart.com download.
When checking action.php file on line 15: Even if this is a newer release, should I change it to solution mentioned above?
I haven't really found the cause of this error, since I do not have the google marketplace enabled...


Thanks for your opinion!

The fix for the next version is https://github.com/opencart/opencart/pull/13019, but either will work.

To track down the actual cause of the error I would look at timestamp of the error in the error log and look at your web access logs for that exact time.

Hey,
thanks for advise ADD creative, I have found my cause of error.
Now I have another question, error comes from paypal express, that I do not have on my new site, but I had on my old one. Since I imported some stuff when going from oc 2 to oc 3, maybe that came along. I can not find where in database that leftover is or is just something else?
Any idea would be appreciated!

OC error log:

access log

You won't have a catalog/controller/extension/payment/pp_express.php file anymore as PayPal Express isn't included in 3.0.3.9.

You will probably need to change your PayPal IPN settings if you are not using PayPal Express anymore.

Hey,
ADD Creative thank you for all the info, that did the trick!

Best, Miha