Post by 00001 » Sat Sep 10, 2022 6:00 am

PHP 7.33 switched to 7.4.3

Trying to access array offset on value of type bool in /home/nginx/domains/***/storage/modification/system/library/image.php on line 37
Trying to access array offset on value of type bool in /home/nginx/domains/***/storage/modification/system/library/image.php on line 38

Code: Select all

[37]			$this->width  = $info[0];
[38]			$this->height = $info[1];
[39]			$this->bits = isset($info['bits']) ? $info['bits'] : '';
[40]			$this->mime = isset($info['mime']) ? $info['mime'] : '';

Newbie

Posts

Joined
Sat Sep 07, 2019 2:58 am

Post by straightlight » Sat Sep 10, 2022 8:55 pm

00001 wrote:
Sat Sep 10, 2022 6:00 am
PHP 7.33 switched to 7.4.3

Trying to access array offset on value of type bool in /home/nginx/domains/***/storage/modification/system/library/image.php on line 37
Trying to access array offset on value of type bool in /home/nginx/domains/***/storage/modification/system/library/image.php on line 38

Code: Select all

[37]			$this->width  = $info[0];
[38]			$this->height = $info[1];
[39]			$this->bits = isset($info['bits']) ? $info['bits'] : '';
[40]			$this->mime = isset($info['mime']) ? $info['mime'] : '';
Issue already fixed on opencart-3 repository with PHP 8.1x.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Mon Sep 12, 2022 12:22 am

straightlight wrote:
Sat Sep 10, 2022 8:55 pm
00001 wrote:
Sat Sep 10, 2022 6:00 am
PHP 7.33 switched to 7.4.3

Trying to access array offset on value of type bool in /home/nginx/domains/***/storage/modification/system/library/image.php on line 37
Trying to access array offset on value of type bool in /home/nginx/domains/***/storage/modification/system/library/image.php on line 38

Code: Select all

[37]			$this->width  = $info[0];
[38]			$this->height = $info[1];
[39]			$this->bits = isset($info['bits']) ? $info['bits'] : '';
[40]			$this->mime = isset($info['mime']) ? $info['mime'] : '';
Issue already fixed on opencart-3 repository with PHP 8.1x.
It's not fixed in 3.0.x, opencart-3 repository or master.
https://github.com/opencart/opencart-3/ ... hp#L36-L39

Issue is caused by a invalid image file, which results in getimagesize returning false. If you are seeing the error then check your images. The code could be improved by checking the result of getimagesize and logging a more meaningful error.

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by straightlight » Mon Sep 12, 2022 3:18 am

Except by putting a more meaningful error, it would also mean a user-defined error message instead of showing the actual error message.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Mon Sep 12, 2022 5:17 pm

straightlight wrote:
Mon Sep 12, 2022 3:18 am
Except by putting a more meaningful error, it would also mean a user-defined error message instead of showing the actual error message.
Yes, that's what good error handling is for.

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by 00001 » Mon Sep 12, 2022 7:15 pm

Thanks for answers.

Is there a plugin or code that keeps track of the details?

Newbie

Posts

Joined
Sat Sep 07, 2019 2:58 am

Post by katalin » Sat Jan 07, 2023 12:48 am

If you have a product with 0 stock and add an option let's say Size L with stock 5, it shows the product on the website as Out of stock and when you check the size option it doesnt change the stock. It should do that. Also when you add options with custom stocks it should calculate and update total stock.
Can anyone fix this issue?

Active Member

Posts

Joined
Wed May 05, 2010 2:28 am

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by katalin » Sat Jan 07, 2023 8:54 am

But does this module also live update stock on product page? if you select an option with no stock should display "out of stock" and viceversa.

Active Member

Posts

Joined
Wed May 05, 2010 2:28 am

Post by straightlight » Sun Jan 08, 2023 10:36 am

katalin wrote:
Sat Jan 07, 2023 8:54 am
But does this module also live update stock on product page? if you select an option with no stock should display "out of stock" and viceversa.
The problematic by considering this is the 1 hour interval where customers are adding a product that might be the last one in stock vs. the next one by product quantity that may no longer be in-stock. Therefore, the customer would still be eligible to buy another quantity of the product online, since the cart still contains the identical product that's been added previously until being purchased, expired from the cart, or removed from the cart by the customer within the next hour period by default.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by katalin » Sun Jan 08, 2023 7:30 pm

I found a little bug. On product page if you have a select option with incresed price it will display the price without a comma.

Attachments

2EA92C8A-ABB2-44C3-8807-E8B423F3CDD8.jpeg

2EA92C8A-ABB2-44C3-8807-E8B423F3CDD8.jpeg (120.55 KiB) Viewed 15700 times


Active Member

Posts

Joined
Wed May 05, 2010 2:28 am

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by katalin » Sun Jan 08, 2023 10:15 pm

xxvirusxx wrote:
Sun Jan 08, 2023 8:34 pm
Is not an opencart bug....
viewtopic.php?p=852082
I am already using that modification but for dropdown list doesn't use <sup> and also does not display comma, price should be 12,00 not 1200.

Active Member

Posts

Joined
Wed May 05, 2010 2:28 am

Post by Majnoon » Sat Mar 04, 2023 3:22 pm

Every time payment method change order is being created.
How to re-produce this bug.
On clean opencart 3.0.3.8 default theme no add on install add any item into cart and proceed to checkout upon selecting the payment method the order will be created now without abandoning the cart try to choose any other payment method and new order will be created. So now imagine the scenario that you have 4 or 5 payment method available on your checkout and a single customer when switching the payment option there are 4 or 5 orders being created.

Active Member

Posts

Joined
Fri Feb 05, 2021 8:29 pm

Post by xxvirusxx » Sat Mar 04, 2023 5:15 pm

Better make a video....
Tested and payment methods are in the same order.....

Or you talk about missing orders....and not Payment Methods Order(Sort)

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by xcited » Thu Jul 13, 2023 5:50 am

Hi, on a fresh installation, when trying to make the first test order, I receive the following error on the last step:

Notice: Undefined property: Proxy::addOrderHistory in /modification/system/engine/action.php on line 75

It doesn't matter what combination of payment and shipping method I use, it always ends with this error. Any idea what is wrong with the addOrderHistory?

Newbie

Posts

Joined
Tue Nov 11, 2014 1:26 am

Post by straightlight » Thu Jul 13, 2023 6:50 am

xcited wrote:
Thu Jul 13, 2023 5:50 am
Hi, on a fresh installation, when trying to make the first test order, I receive the following error on the last step:

Notice: Undefined property: Proxy::addOrderHistory in /modification/system/engine/action.php on line 75

It doesn't matter what combination of payment and shipping method I use, it always ends with this error. Any idea what is wrong with the addOrderHistory?
Where did you downloaded the package from?

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ADD Creative » Thu Jul 13, 2023 6:57 am

xcited wrote:
Thu Jul 13, 2023 5:50 am
Hi, on a fresh installation, when trying to make the first test order, I receive the following error on the last step:

Notice: Undefined property: Proxy::addOrderHistory in /modification/system/engine/action.php on line 75

It doesn't matter what combination of payment and shipping method I use, it always ends with this error. Any idea what is wrong with the addOrderHistory?
It means addOrderHistory can't be found. Could be a missing or edited file. Could also be caused by an extension. Check all your files against a clean download of your version. Try clearing storage/modification/

www.add-creative.co.uk


Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by answersun » Sun Dec 17, 2023 2:55 am

Customers able to place order without choosing mandatory product options.

How to reproduce:
1. add a product in admin side without any option.
2. add this product to cart in the customer side.
3. add some mandatory options to the product in admin side.
4. update the product quantity in the cart and checkout, you can see the customer can update the cart and checkout without choosing any of the mandatory options introduced in the step before, which shouldn't be allowed.

Here's a recording showcase this problem: https://drive.google.com/file/d/1b42JH3 ... sp=sharing

Any suggestion on how to fix this?
Thanks in advance!

New member

Posts

Joined
Tue Apr 11, 2017 6:31 pm

Post by xxvirusxx » Tue Dec 19, 2023 6:51 pm

answersun wrote:
Sun Dec 17, 2023 2:55 am
1. add a product in admin side without any option.
2. add this product to cart in the customer side.
3. add some mandatory options to the product in admin side.
Why you will do that?

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România
Who is online

Users browsing this forum: No registered users and 9 guests