Post by AlexMBM » Tue Jul 06, 2010 6:35 am

First of all please escuse me for my bad english...

If i add more products (150 in my case) than discounted quantity my VAT Taxes (TVA in Romanian where is 24%) is not calculating correct total.

Attachments

Untitled.jpg

Untitled.jpg (79.57 KiB) Viewed 7661 times


Newbie

Posts

Joined
Tue Jul 06, 2010 6:27 am

Post by Daniel » Tue Jul 06, 2010 6:08 pm

AlexMBM wrote:First of all please escuse me for my bad english...

If i add more products (150 in my case) than discounted quantity my VAT Taxes (TVA in Romanian where is 24%) is not calculating correct total.

Did you setup your store location?

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by Qphoria » Tue Jul 06, 2010 10:22 pm

Johnathan wrote:In /catalog/controller/checkout/guest_step_2.php, in this block of code:

Code: Select all

if (($this->request->server['REQUEST_METHOD'] == 'POST') && isset($this->request->post['coupon']) && $this->validateCoupon()) {
			$this->session->data['coupon'] = $this->request->post['coupon'];
			
			$this->session->data['success'] = $this->language->get('text_success');
			
			$this->redirect(HTTPS_SERVER . 'index.php?route=checkout/guest_step_3');
		}
I think the last line should instead be:

Code: Select all

$this->redirect(HTTPS_SERVER . 'index.php?route=checkout/guest_step_2');
Otherwise, when you click "Apply Coupon" it takes you to the confirmation page. If you want to be consistent with how the non-guest checkout works, you should only proceed to the confirmation page when you click on "Continue", not "Apply Coupon".
Thanks!

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Johnathan » Wed Jul 07, 2010 6:46 am

In /catalog/language/english/checkout/guest_step_2.php
and /catalog/language/english/checkout/shipping.php:

Code: Select all

$_['text_shipping_methods'] = 'Please select the preferred shipping methods to use on this order.';
"methods" should be "method"

Image Image Image Image Image


User avatar
Administrator

Posts

Joined
Fri Dec 18, 2009 3:08 am


Post by Johnathan » Wed Jul 07, 2010 7:08 am

In /catalog/language/english/account/login.php there are two instances of "text_account":

Code: Select all

$_['text_account']                 = 'Account';
$_['text_account']                 = 'Register Account';
The first one should probably be removed.

Image Image Image Image Image


User avatar
Administrator

Posts

Joined
Fri Dec 18, 2009 3:08 am


Post by Johnathan » Wed Jul 07, 2010 7:17 am

One more: this typo still exists.
fido-x wrote:Small typo in the "catalog/language/account/success.php" file.

Code: Select all

$_['text_approval'] = '<p>Thank you for registing with %s!</p><p>You will be notified by email once your account has been activated by the store owner.</p><p>If you have ANY questions about the operation of this online shop, please <a href="%s">contact the store owner</a>.</p>';
"Thank you for registing"? Should be "registering".
Last edited by i2Paq on Wed Jul 07, 2010 2:27 pm, edited 1 time in total.
Reason: Typo added

Image Image Image Image Image


User avatar
Administrator

Posts

Joined
Fri Dec 18, 2009 3:08 am


Post by JAY6390 » Wed Jul 07, 2010 7:46 am

Some well spotted errors there Jonathan, nice work :)

Image


User avatar
Guru Member

Posts

Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom

Post by Moggin » Thu Jul 08, 2010 12:06 am

...if on a typo hunt, here's a couple more

in catalog/language/english/mail/order_confirm.php

$_['text_greeting'] = 'Thank your for interest in %s products. ...

and an oldie left over from 1.4.7 in in catalog/language/english/account.success.php

// Text
$_['text_message'] = '<p>Congratulations! Your new account has been successfully created!</p> <p>You can now take advantage of member priviledges to enhance your online shopping experience with us.</p>

s/be privileges .There, I knew you'd be grateful ;D ;D

Active Member

Posts

Joined
Wed May 05, 2010 4:56 am

Post by Qphoria » Thu Jul 08, 2010 12:18 am

Johnathan wrote:One more: this typo still exists.
fido-x wrote:Small typo in the "catalog/language/account/success.php" file.

Code: Select all

$_['text_approval'] = '<p>Thank you for registing with %s!</p><p>You will be notified by email once your account has been activated by the store owner.</p><p>If you have ANY questions about the operation of this online shop, please <a href="%s">contact the store owner</a>.</p>';
"Thank you for registing"? Should be "registering".
This one was already fixed in 1.4.8
I've fixed the rest for the next version
Thanks

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by thehumancpu » Thu Jul 08, 2010 1:19 am

I noticed that when I started my XML-SITEMAP generator locally, it would get to a link depth of about 25, and start looping between products that were linked in someway together. They would just go back and forth and add to the URL. Example

Headsets/earphones/headsets/earphones
earphones/earphones/earphones/earphones

It does not stop and it is endless

Anyway, I have disabled SEO for now, as google will ding for duplicate content on different URLs.

I would suggest anyone else that does alot of product linking and so on to be run a real crawler on your site to make sure you don't get this endless looping.

New member

Posts

Joined
Mon Oct 19, 2009 10:59 am

Post by ttanemori » Fri Jul 09, 2010 1:55 am

After I upgraded to 1.4.8b, Website Payment Pro seems to be something wrong.

After I press the submit button, "Please Wait!" text appears. But it does not finish.

I checked my PayPal account, and the money is actually there.

It was fine before, but I am not sure why.

Newbie

Posts

Joined
Wed Jul 07, 2010 3:39 am

Post by Qphoria » Fri Jul 09, 2010 2:13 am

ttanemori wrote:After I upgraded to 1.4.8b, Website Payment Pro seems to be something wrong.

After I press the submit button, "Please Wait!" text appears. But it does not finish.

I checked my PayPal account, and the money is actually there.

It was fine before, but I am not sure why.
The please wait fix is here: http://forum.opencart.com/viewtopic.php?f=31&t=16053

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by ttanemori » Fri Jul 09, 2010 2:39 am

Yes, that bug fixed solved it. Thanks!

Newbie

Posts

Joined
Wed Jul 07, 2010 3:39 am

Post by OSWorX » Sat Jul 10, 2010 2:25 am

All OC versions are using the CKEditor AND have additional languages installed (or extensions which use multiple instances of the editor), have the same bug: it is IMPOSSIBLE to embedd an image EXCEPT at the first instance of the editor.

If I try to embedd/include an image in one of the the other instances of the editor, this error is shown (FF / FireBug):

Code: Select all

z._.filebrowserSe is undefined
This bug is already well known at CKEditor, see: http://cksource.com/search/yboss/filebrowserSe and NO fix is provided - it seems that Knabben (the author of this editor) wants to push instead his commercial extension 'Finder'.

With this bug, it is simply impossible to work with embedded images in the current editor IF the shop use more languages and have therefore multiple instances of the editor (on the same page).

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by Qphoria » Sat Jul 10, 2010 2:53 am

OSWorX wrote:All OC versions are using the CKEditor AND have additional languages installed (or extensions which use multiple instances of the editor), have the same bug: it is IMPOSSIBLE to embedd an image EXCEPT at the first instance of the editor.

If I try to embedd/include an image in one of the the other instances of the editor, this error is shown (FF / FireBug):

Code: Select all

z._.filebrowserSe is undefined
This bug is already well known at CKEditor, see: http://cksource.com/search/yboss/filebrowserSe and NO fix is provided - it seems that Knabben (the author of this editor) wants to push instead his commercial extension 'Finder'.

With this bug, it is simply impossible to work with embedded images in the current editor IF the shop use more languages and have therefore multiple instances of the editor (on the same page).
This was reported in the last few versions too. Good to know its a ckeditor issue. Another potential reason to get rid of it.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by OSWorX » Sat Jul 10, 2010 4:39 am

Good to know that the 'developers' already know this issue ..
This and the bug itself is the reason, why I am using from now on only the TinyMCE: http://tinymce.moxiecode.com/

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by Chrissy Poo » Sat Jul 10, 2010 5:42 am

Can I just confirm that all the bugs listed in the first post still apply in 1.4.8b?

Also once I have applied them it will be all ready to go?

10% Discount on all Shared and Reseller Hosting Packages at Vidahost.com

Discount Code: DISCOUNT10


Active Member

Posts

Joined
Mon Jun 29, 2009 8:48 am
Location - UK

Post by speedingorange » Sun Jul 11, 2010 6:08 pm

When copying items with dicounts included within them, new discount rules are added occasionally which make products free before the first pre made price break is inserted.

Example.

If an item with a price break at 10 items is coppied. Occasionally a new price break is created at

0 items for £00.00

Had it happen on two of my stores so thought i would make you aware. Not sure if it has allready been posted. Running 1.4.8.B

Active Member

Posts

Joined
Tue Feb 23, 2010 7:33 pm

Post by Qphoria » Mon Jul 12, 2010 11:20 pm

Chrissy Poo wrote:Can I just confirm that all the bugs listed in the first post still apply in 1.4.8b?

Also once I have applied them it will be all ready to go?
Yes

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Chrissy Poo » Mon Jul 12, 2010 11:42 pm

Qphoria wrote:
Chrissy Poo wrote:Can I just confirm that all the bugs listed in the first post still apply in 1.4.8b?

Also once I have applied them it will be all ready to go?
Yes
Thanks just one more thing....

When I click on the fix for "Showing 1 to 14 of 14 (1 Pages)" it takes me to a post saying:
Qphoria wrote:
allenshea wrote:Tags problem,

Please check below link, it show "Showing 1 to 14 of 14 (1 Pages)" but on the page only get 7items
http://unbannable.com/v148rc1/index.php ... word=Apple

Is this a bug? I have the same problem with my own cart

Thanks

Allen
Congratulations. You found the first true 1.4.8 bug. We went about 16 hours without a bug.. almost made it to 24 hours :)
But where is the actual fix for it?

10% Discount on all Shared and Reseller Hosting Packages at Vidahost.com

Discount Code: DISCOUNT10


Active Member

Posts

Joined
Mon Jun 29, 2009 8:48 am
Location - UK
Who is online

Users browsing this forum: No registered users and 23 guests