Duplicate customer activity (new order), and email sent twice.

Hey folks.

Bit of a weird one that I cannot work out. When a new order is made, the customer activity is showing the new order twice (exact same time), and when dive into the report it shows a different IP address against the duplicated activity. I assume because of the payment callback.

Also, and I'd say related, the order alert is sent to the admin twice.

The site is using a Payment Express (Windcave) gateway that sets the order history as "processing". The default order status is "pending" in the system settings.

Does anyone know where I might be missing what could be causing this? I am assuming it is happening each time the order history is updated?

Thanks

The event model/checkout/order/addOrderHistory/before should only add an activity if the order ID changes from 0.
https://github.com/opencart/opencart/bl ... #L222-L227

Could be some sort or race condition between the payment response and the callback it the both call addOrderHistory. Does it happen every time and with different payment modules?

ADD Creative wrote: ↑

Thu Jul 29, 2021 7:51 am

Could be some sort or race condition between the payment response and the callback it the both call addOrderHistory. Does it happen every time and with different payment modules?

Yeah appears to be every time with the same payment gateway.

It's the payment gateway that does this. I'm pretty sure

You could check the server's access log to see what the exact logged requests are, and whether they originate from the payment gateway, and if so, perhaps twice. This way you'd get a clearer idea whether or not it is caused by the payment gateway.

JNeuhoff wrote: ↑

Thu Jul 29, 2021 4:56 pm

You could check the server's access log to see what the exact logged requests are, and whether they originate from the payment gateway, and if so, perhaps twice. This way you'd get a clearer idea whether or not it is caused by the payment gateway.

Yeah good point. Thanks, I will check.