Post by Lozza2 » Mon Nov 23, 2020 6:05 pm

Hi folks, I hope you can help me as I am now at the end (nearly) of my tether! :-)

In Summary - I have installed an extension, refreshed on the modification page and changes made to product_form.twig are not showing in admin.

Details and checks:
1) install.xml mods to product_form.twig were successfully applied according to the log
2) the mods have been applied correctly in the storage area to {{storage}}/modification/admin/view/template/catalog/product_form.twig
3) if I overwrite /admin/view/template/catalog/product_form.twig with the version in storage/modification... it works fine

So, something is causing Opencart to continue using the unmodified version, even though is has correctly created a modified version.

Best wishes
Lozza
Last edited by Lozza2 on Thu Nov 26, 2020 5:28 pm, edited 1 time in total.

New member

Posts

Joined
Sat Sep 12, 2020 4:13 pm

Post by khnaz35 » Tue Nov 24, 2020 1:34 am

What is your OC version ? Any theme installed?

Got an urgent question that’s keeping you up at night? There might just be a magical inbox ready to help: khnaz35@gmail.com
Enjoy nature ;) :) :-*


User avatar
Active Member

Posts

Joined
Mon Aug 27, 2018 11:30 pm
Location - Malaysia

Post by JNeuhoff » Tue Nov 24, 2020 2:31 am

Perhaps you have also used the theme editor from the admin backend? If so, the OCmod-based changes to the same template won't be applied!

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by OSWorX » Tue Nov 24, 2020 5:40 am

JNeuhoff wrote:
Tue Nov 24, 2020 2:31 am
Perhaps you have also used the theme editor from the admin backend? If so, the OCmod-based changes to the same template won't be applied!
It would surprise me that the Theme Editor can also modidy admin templates ..
For catalog templates see this https://github.com/opencart/opencart/pull/8925

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by JNeuhoff » Tue Nov 24, 2020 5:32 pm

OSWorX wrote:
Tue Nov 24, 2020 5:40 am
It would surprise me that the Theme Editor can also modidy admin templates ..
Sorry, yes, you are right, the theme editor only does it for frontend templates.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by OSWorX » Tue Nov 24, 2020 8:43 pm

Additional to the catalog issue, loading modified admin templates does not work, because of an old(and wrong) modification.xml (until 3.0.3.6).
Ran yesterday into that "trap".
Simply replace the modification.xml with that here and it works:
https://github.com/opencart/opencart/bl ... cation.xml

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by JNeuhoff » Tue Nov 24, 2020 8:56 pm

Makes me wonder why there is no OC 3.0.3.7 bugfix release, the last 2 releases should be skipped!

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by OSWorX » Tue Nov 24, 2020 9:27 pm

JNeuhoff wrote:
Tue Nov 24, 2020 8:56 pm
Makes me wonder why ..
Really .. still after that long time we both are here?

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by straightlight » Tue Nov 24, 2020 10:16 pm

OSWorX wrote:
Tue Nov 24, 2020 9:27 pm
JNeuhoff wrote:
Tue Nov 24, 2020 8:56 pm
Makes me wonder why ..
Really .. still after that long time we both are here?
Momentum level.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by Lozza2 » Thu Nov 26, 2020 5:13 pm

OSWorX wrote:
Tue Nov 24, 2020 8:43 pm
Simply replace the modification.xml with that here and it works:
https://github.com/opencart/opencart/bl ... cation.xml
Thank you all for your replies and sorry I took so long to read them!!
The issue has been resolved by replacing the modification.xml - thank you OSWorX.

Best wishes
Lozza

New member

Posts

Joined
Sat Sep 12, 2020 4:13 pm

Post by khnaz35 » Thu Nov 26, 2020 5:14 pm

Lozza2 wrote:
Thu Nov 26, 2020 5:13 pm
The issue has been resolved by replacing the modification.xml - thank you OSWorX.

Best wishes
Lozza
Thanks for confirming Lozza, Kindly add word [SOLVED] in beginning of your post title.

Got an urgent question that’s keeping you up at night? There might just be a magical inbox ready to help: khnaz35@gmail.com
Enjoy nature ;) :) :-*


User avatar
Active Member

Posts

Joined
Mon Aug 27, 2018 11:30 pm
Location - Malaysia

Post by Lozza2 » Thu Nov 26, 2020 5:29 pm

Thanks for confirming Lozza, Kindly add word [SOLVED] in beginning of your post title.
Done, cheers :-)

New member

Posts

Joined
Sat Sep 12, 2020 4:13 pm
Who is online

Users browsing this forum: No registered users and 25 guests