Multilingual URL showing default language instead of selected URLs

Post by Besti » Sat Sep 12, 2020 4:04 am

You are a wonder!

It is so nice, when there is someone to guide you, when you are trying to learn
I really appreciate your time and effort!!!!!
I will absolutely follow your advice and above all i have to thank you for a very good explanation!
Actually (concerning your example with dots), i don't use the dots in the urls... And i like the idea a lot! Safety first
But i am not sure how this would affect robots, sitemap etc... They have the dots.. As im not a pro, my questions may sound stupid, but both examples block .txt and .xml... So i don't really get it, if we block them, then what about google etc, they wont be able even to read the robots or am i wrong?

P.S. Ok, checked everything to see myself, looks like files are accessible... Interesting.. A bit confused trying to understand how it works...

Post by letxobnav » Sat Sep 12, 2020 7:20 am

RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d

RewriteCond %{REQUEST_URI} !.*\.(env|php|xml|ashx|cfg|dat|ico|cur|txt|mp3|webp|svg|ttf|eot|woff|woff2|gif|jpg|JPG|jpeg|JPEG|png|js|cfg|css|pdf|zip|env|tar|sql|gz|tar|exe|rar|arj|cab|iso|rpm|tbz|tgz|old|bak|backup|dump|db|7z|asp|aspx|exp|html|htm)$

RewriteCond %{REQUEST_URI} !.*\..*$

Crystal Light Centrum Taiwan
Extensions: MailQueue | SUKHR | VBoces

“Data security is paramount at [...], and we are committed to protecting the privacy of anyone who is associated with our [...]. We’ve made a lot of improvements and will continue to make them.”
When you know your life savings are gone.

Post by Besti » Sat Sep 12, 2020 5:24 pm

Thank you very much for an explanation! I prefer to understand (at least a bit) what am i doing... lol
I guess i will stick with your idea with the dot! I really like it! Thank you!

My error with the product got back... Sorry, for further questions...
2020-09-11 22:11:29 - PHP Notice: Undefined index: attribute_id in /home/wittomin/oc/storage/modification/admin/model/catalog/product.php on line 178
2020-09-11 22:28:37 - PHP Warning: Illegal string offset 'attribute_id' in /home/wittomin/oc/storage/modification/admin/model/catalog/product.php on line 178
2020-09-11 22:28:37 - PHP Warning: Illegal string offset 'attribute_id' in /home/wittomin/oc/storage/modification/admin/model/catalog/product.php on line 180
2020-09-11 22:28:37 - PHP Warning: Illegal string offset 'product_attribute_description' in /home/wittomin/oc/storage/modification/admin/model/catalog/product.php on line 182
2020-09-11 22:28:37 - PHP Warning: Invalid argument supplied for foreach() in /home/wittomin/oc/storage/modification/admin/model/catalog/product.php on line 182
These are the lines - 176-187.. I am a bit lost. Compared with the file, which comes with OC.. looks the same.. No idea why it is complaining... And above all couple of attributes in products disapear from time to time.. Is there a typo or else? It started after modifications with the language, and the attribute disappears only for one language, so it is really strange and looks related to the chenges in language.php or smth... Could be be so kind to take a look...

if (!empty($data['product_attribute'])) {
foreach ($data['product_attribute'] as $product_attribute) {
if ($product_attribute['attribute_id']) {
// Removes duplicates
$this->db->query("DELETE FROM " . DB_PREFIX . "product_attribute WHERE product_id = '" . (int)$product_id . "' AND attribute_id = '" . (int)$product_attribute['attribute_id'] . "'");

foreach ($product_attribute['product_attribute_description'] as $language_id => $product_attribute_description) {
$this->db->query("INSERT INTO " . DB_PREFIX . "product_attribute SET product_id = '" . (int)$product_id . "', attribute_id = '" . (int)$product_attribute['attribute_id'] . "', language_id = '" . (int)$language_id . "', text = '" . $this->db->escape($product_attribute_description['text']) . "'");
}
}
}
}

Post by letxobnav » Sat Sep 12, 2020 5:51 pm

$this->log->write(print_r($data['product_attribute'],true));

foreach ($data['product_attribute'] as $product_attribute) {

2020-09-12 18:03:29 - Array
(
    [0] => Array
        (
            [name] => Fragile
            [attribute_id] => 16
            [product_attribute_description] => Array
                (
                    [2] => Array
                        (
                            [text] => 不
                        )

                    [1] => Array
                        (
                            [text] => No
                        )

                )

        )

)

Crystal Light Centrum Taiwan
Extensions: MailQueue | SUKHR | VBoces

“Data security is paramount at [...], and we are committed to protecting the privacy of anyone who is associated with our [...]. We’ve made a lot of improvements and will continue to make them.”
When you know your life savings are gone.

Post by Besti » Sat Sep 12, 2020 6:49 pm

Post by letxobnav » Sat Sep 12, 2020 9:09 pm

$language_data = $this->cache->get('language');

$language_data = $this->cache->get('catalog.language');

$this->log->write(print_r($data['product_attribute'],true));

Crystal Light Centrum Taiwan
Extensions: MailQueue | SUKHR | VBoces

“Data security is paramount at [...], and we are committed to protecting the privacy of anyone who is associated with our [...]. We’ve made a lot of improvements and will continue to make them.”
When you know your life savings are gone.

Post by Besti » Sat Sep 12, 2020 9:21 pm

Wow.. Thank you fo the fix for that language bug.. I read it is nothing serious, but it gets annoying every time manually adding the file to cache to delete it.. lol
Hope the fix will work, ill definetely check it in the evening!

I will recheck the code for product.php again.. But this error with attributes is pretty strange - it appears from time to time only in two-three products, one language different attribute for each product, but always the same one.
So product 1 always gets Product type in german deleted, Produt 3 gets always gets for material in german some additional meaningless symbols in it and Product 3 gets quality for german language missing. So always my default language is affected. But is does not happen every time i edit the product.. As i had to edit them pretty often these days, but it happened like couple of times... Starting from 9th...

Post by letxobnav » Sat Sep 12, 2020 10:03 pm

Crystal Light Centrum Taiwan
Extensions: MailQueue | SUKHR | VBoces

“Data security is paramount at [...], and we are committed to protecting the privacy of anyone who is associated with our [...]. We’ve made a lot of improvements and will continue to make them.”
When you know your life savings are gone.

Post by Besti » Mon Sep 14, 2020 3:11 am

Hello!

Thank you once again! Finally, no language error anymore!

Tried to edit product.php again, no success... However the text that appeart in one of the attributes of one of my products is this -

-----WebKitFormBoundaryn8uYYdULNa2qa2aL
Content-Disposition: form-data; name="product_attribute[1][product_attribute_description][1][text]"

Post by letxobnav » Mon Sep 14, 2020 10:48 am

Crystal Light Centrum Taiwan
Extensions: MailQueue | SUKHR | VBoces

“Data security is paramount at [...], and we are committed to protecting the privacy of anyone who is associated with our [...]. We’ve made a lot of improvements and will continue to make them.”
When you know your life savings are gone.

Post by Besti » Mon Sep 14, 2020 4:40 pm

Post by letxobnav » Mon Sep 14, 2020 5:35 pm

-----WebKitFormBoundaryn8uYYdULNa2qa2aL
Content-Disposition: form-data; name="product_attribute[1][product_attribute_description][1][text]"

Crystal Light Centrum Taiwan
Extensions: MailQueue | SUKHR | VBoces

“Data security is paramount at [...], and we are committed to protecting the privacy of anyone who is associated with our [...]. We’ve made a lot of improvements and will continue to make them.”
When you know your life savings are gone.

Post by Besti » Mon Sep 14, 2020 7:43 pm

Post by letxobnav » Mon Sep 14, 2020 8:24 pm

Crystal Light Centrum Taiwan
Extensions: MailQueue | SUKHR | VBoces

“Data security is paramount at [...], and we are committed to protecting the privacy of anyone who is associated with our [...]. We’ve made a lot of improvements and will continue to make them.”
When you know your life savings are gone.

Post by Besti » Mon Sep 14, 2020 11:53 pm

Hello!
Evidently all the mess was because of the email missing in the files somehow... After the backup from my provider..
My hosting provider finally managed to fix it.. Even if at first they sent me off..
After the email got fixed, the export of database from admin is possible, checkout with bank transfer works again, so i need just to check whether the attribute error comes back!

Anyway, i would like to thank you for your patience and once again for very valuable advices with a wonderful understandable explanations!!!!

Post by ADD Creative » Tue Sep 15, 2020 12:34 am

www.add-creative.co.uk

Post by Besti » Tue Sep 15, 2020 5:37 am

Post by ADD Creative » Tue Sep 15, 2020 7:05 am

www.add-creative.co.uk

Post by Besti » Tue Sep 15, 2020 3:29 pm

Post by Besti » Tue Sep 15, 2020 3:32 pm

Getting back to the topic...
With the two languages, the sitemap i basically did online and enlarge it slowly manually.. But what about the Google base.. Should i turn the other language as default for a while, to make the xml for google feed in two languages (one will be the one he can fetch and the other static xml)?

Or there is a more decent way to do it?