I'll decide that.You can change to Best and is enough only zip archive.
As for the image cache: cleaned. Package re-uploaded.
As for the image cache: cleaned. Package re-uploaded.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Thanks. I can see all the type casts are in. You still need to change the following to match the patches in the master branch.straightlight wrote: ↑Fri Jun 05, 2020 6:36 am@Add Creative: All (if not, to the most possible ones that I found), integers variables have now been sanitized.
Add js escaping to upload/admin/view/template/common/filemanager.twig.
https://github.com/opencart/opencart/pu ... ca1cfc31cc
Add check zone_id is numeric in upload/catalog/controller/extension/total/shipping.php.
https://github.com/opencart/opencart/pu ... d41ab281bc
user_token should be from the session data and not GET in upload/admin/controller/sale/recurring.php.
https://github.com/opencart/opencart/pu ... bf283bd1cb
The first two commits, there's no approval for the master branch. As the third one, it has not been approved but you are correct, I have added the fix in the pre-release.ADD Creative wrote: ↑Fri Jun 05, 2020 7:07 pmThanks. I can see all the type casts are in. You still need to change the following to match the patches in the master branch.straightlight wrote: ↑Fri Jun 05, 2020 6:36 am@Add Creative: All (if not, to the most possible ones that I found), integers variables have now been sanitized.
Add js escaping to upload/admin/view/template/common/filemanager.twig.
https://github.com/opencart/opencart/pu ... ca1cfc31cc
Add check zone_id is numeric in upload/catalog/controller/extension/total/shipping.php.
https://github.com/opencart/opencart/pu ... d41ab281bc
user_token should be from the session data and not GET in upload/admin/controller/sale/recurring.php.
https://github.com/opencart/opencart/pu ... bf283bd1cb
The first issue has already been fixed in the master branch, however: https://github.com/opencart/opencart/bl ... g.php#L158 .
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
The first commit has also been fixed in the master branch already: https://github.com/opencart/opencart/bl ... .twig#L257 .
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Package re-uploaded.
- Integrated currency fixer.
- Added events in the opencart/install.sql for currency fixer controller.
- Added events in the upgrade for currency fixer controller.
- Fixed user_token from $this->request->get to read: $this->session->data as per the master branch.
- Integrated currency fixer.
- Added events in the opencart/install.sql for currency fixer controller.
- Added events in the upgrade for currency fixer controller.
- Fixed user_token from $this->request->get to read: $this->session->data as per the master branch.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Could the new packages "re-uploaded" and published only once a day?
Like a "nightly build"?
Now no one knows from when the latest package is!
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
Starting on this day, yes. The majors and features have been integrated so an update will be published once a day for minor changes from now on until the next official release comes in (no official date and time). However, as for the no one knows, I would have to disagree on that. The date and time is being addressed accordingly in the first post and on the releases page for each releases being updated.
As for the nightly build, it is the reason why I indicated (EST Time) on the releases updates due to the different time zones.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Until the next release, in admin/controller/localisation/currency.php file,
find:
Ensure the line right below is replaced with this one:
Then, find:
Replace with:
find:
Code: Select all
if ($this->validateRefresh()) {
Code: Select all
$this->load->controller('extension/currency/' . $this->config->get('config_currency_engine') . '/currency', $this->config->get('config_currency'));
Code: Select all
// $this->response->redirect($this->url->link('localisation/currency', 'user_token=' . $this->session->data['user_token'] . $url));
Code: Select all
$this->response->redirect($this->url->link('localisation/currency', 'user_token=' . $this->session->data['user_token'] . $url));
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
In PHPMyAdmin > << Your Opencart Database >> > SQL tab, launch the following query:
Note: If you use multiple stores, ensure to save each store settings from the OC admin accordingly after inserting this query.
2nd note: Take note of the oc_ and replace it with your current database table prefix name.
These last two changes will be added in the next release for the install and the upgrade.
Code: Select all
INSERT INTO `oc_setting` (`store_id`, `code`, `key`, `value`, `serialized`) VALUES
(0, 'config', 'config_currency_engine', 'fixer', 0);
INSERT INTO `oc_setting` (`store_id`, `code`, `key`, `value`, `serialized`) VALUES
(0, 'currency_fixer', 'currency_fixer_status', '1', 0);
INSERT INTO `oc_extension` (`extension_id`, `type`, `code`) VALUES
(42, 'currency', 'fixer');
2nd note: Take note of the oc_ and replace it with your current database table prefix name.
These last two changes will be added in the next release for the install and the upgrade.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
So do we have always to read the first post here before?straightlight wrote: ↑Fri Jun 05, 2020 9:03 pmHowever, as for the no one knows, I would have to disagree on that. The date and time is being addressed accordingly in the first post and on the releases page for each releases being updated.
As for the nightly build, it is the reason why I indicated (EST Time) on the releases updates due to the different time zones.
While these infos here and at GH are new (4 hours ago they were not), fine that they are added now:
p.s.: and could be the immense size of the package be reduced (as other already mentioned ..)?!
thx.
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
Yes, we do to ensure users understands the date and time of these updates when troubleshooting issues on the forum.So do we have always to read the first post here before?
As for the package, while the ZIP file could be reduced, it won't change anything for the TAR file being downloaded as these compression are handled differently.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
@OSWorX: As per the screenshot, however, noticed I forgot to upload the ZIP format. It has now been uploaded.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Yes, that is what I was saying. They were patched in the master branch, so need to be patched in the 3.0.3.4 pre-release.straightlight wrote: ↑Fri Jun 05, 2020 7:51 pmThe first commit has also been fixed in the master branch already: https://github.com/opencart/opencart/bl ... .twig#L257 .
Both {{ thumb }} and {{ target }} need escaping in the filemanager template.
You can see the zone_id patched here in the master here.
https://github.com/opencart/opencart/bl ... ng.php#L56
Ok, found it. Added line 56.ADD Creative wrote: ↑Fri Jun 05, 2020 10:50 pmYes, that is what I was saying. They were patched in the master branch, so need to be patched in the 3.0.3.4 pre-release.straightlight wrote: ↑Fri Jun 05, 2020 7:51 pmThe first commit has also been fixed in the master branch already: https://github.com/opencart/opencart/bl ... .twig#L257 .
Both {{ thumb }} and {{ target }} need escaping in the filemanager template.
You can see the zone_id patched here in the master here.
https://github.com/opencart/opencart/bl ... ng.php#L56
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Re-updated package.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
- admin/view/template/setting/setting.twig
Change this: config_limit_admin to thid config_pagination
Change this: config_limit_admin to thid config_pagination
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
The latest updated tar and zip dont work
The front page loads with error
Then in admin if you goto admin/settings/stores and edit the store and just click save without changing anything i get at the top of the page.
Also in admin/settings/stores and edit the store you cannot save any number in Default Items Per Page (Admin) in the option tab
The front page loads with error
Code: Select all
Fatal error: Uncaught ArgumentCountError: Too few arguments to function ModelExtensionTotalSubTotal::getTotal(), 0 passed in C:\xampp\htdocs\oc3.0.3.4\system\engine\loader.php on line 248 and exactly 3 expected in C:\xampp\htdocs\oc3.0.3.4\catalog\model\extension\total\sub_total.php:3 Stack trace: #0 C:\xampp\htdocs\oc3.0.3.4\system\engine\loader.php(248): ModelExtensionTotalSubTotal->getTotal() #1 C:\xampp\htdocs\oc3.0.3.4\catalog\controller\common\cart.php(37): Loader->{closure}(Array, Array, 0) #2 C:\xampp\htdocs\oc3.0.3.4\system\engine\action.php(79): ControllerCommonCart->index(Array) #3 C:\xampp\htdocs\oc3.0.3.4\system\engine\loader.php(48): Action->execute(Object(Registry), Array) #4 C:\xampp\htdocs\oc3.0.3.4\catalog\controller\common\header.php(77): Loader->controller('common/cart') #5 C:\xampp\htdocs\oc3.0.3.4\system\engine\action.php(79): ControllerCommonHeader->index(Array) #6 C:\xampp\htdocs\oc3.0.3.4\system\engine\loader.php(48): Action->execute(Object(Registry), Array) #7 C:\xampp\htdocs\oc3.0.3.4\catalog\co in C:\xampp\htdocs\oc3.0.3.4\catalog\model\extension\total\sub_total.php on line 3Code: Select all
Notice: Undefined index: config_pagination in C:\xampp\htdocs\oc3.0.3.4\admin\controller\setting\setting.php on line 919Also in admin/settings/stores and edit the store you cannot save any number in Default Items Per Page (Admin) in the option tab
The escaping of {{ thumb }} and {{ target }} in admin/view/template/common/filemanager.twig is still missing.
https://github.com/opencart/opencart/pu ... ca1cfc31cc
Need to change.
To.
And.
To.
https://github.com/opencart/opencart/pu ... ca1cfc31cc
Need to change.
Code: Select all
{{ thumb }}Code: Select all
{{ thumb|escape('js') }}Code: Select all
{{ target }}Code: Select all
{{ target|escape('js') }}Ok, package has been updated.
- Feature: Duplicated admin store page with admin setting page (as per their accordance titles - please submit feedback about this feature).
- Reversed lookup for getTotal to the previous one. It seem the OC engine was a bit altered on the master branch to remove the referenced variables.
- Fixed $total_data to read $total_data['totals'] in the sort order lists. This issue was reported on the forum in the past.
- Fixed admin/view/template/common/filemanager.js by adding the escape|js as per the post reply above by Add Creative.
- One identified 'possible' bug in the catalog/controller/extension/payment/paypal_smart_button.php file where the $total_data['total'] is reflected by the $order_data['total'] . Should it be called ['totals'] instead of ['total'] to pull the one from the getTotal(). Still under investigation as to know why an array would be needed to insert the data instead of a specific float.
- Feature: Duplicated admin store page with admin setting page (as per their accordance titles - please submit feedback about this feature).
- Reversed lookup for getTotal to the previous one. It seem the OC engine was a bit altered on the master branch to remove the referenced variables.
- Fixed $total_data to read $total_data['totals'] in the sort order lists. This issue was reported on the forum in the past.
- Fixed admin/view/template/common/filemanager.js by adding the escape|js as per the post reply above by Add Creative.
- One identified 'possible' bug in the catalog/controller/extension/payment/paypal_smart_button.php file where the $total_data['total'] is reflected by the $order_data['total'] . Should it be called ['totals'] instead of ['total'] to pull the one from the getTotal(). Still under investigation as to know why an array would be needed to insert the data instead of a specific float.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
- Reuploaded package again. Forgot to clear the cache.
- Repackaged with normal compression seem to have shrink the ZIP file.
- Repackaged with normal compression seem to have shrink the ZIP file.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Who is online
Users browsing this forum: No registered users and 2 guests
