User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 10:16 pm


Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 10:21 pm

Duplicate $information_info['title']

https://github.com/opencart/opencart/issues/7518
https://github.com/opencart/opencart/co ... cfa0384770

Files:
- catalog/controller/account/affiliate.php
- catalog/controller/account/register.php
- catalog/controller/account/return.php
- catalog/controller/affiliate/register.php
- catalog/controller/checkout/payment_method.php
- catalog/controller/checkout/register.php

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 10:26 pm

xxvirusxx wrote:
Sun May 31, 2020 10:21 pm
Duplicate $information_info['title']

https://github.com/opencart/opencart/issues/7518
https://github.com/opencart/opencart/co ... cfa0384770

Files:
- catalog/controller/account/affiliate.php
- catalog/controller/account/register.php
- catalog/controller/account/return.php
- catalog/controller/affiliate/register.php
- catalog/controller/checkout/payment_method.php
- catalog/controller/checkout/register.php
Fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Guru Member

Posts

Joined
Sat Jan 14, 2012 1:02 am
Location - United Kingdom

Post by xxvirusxx » Sun May 31, 2020 10:31 pm

- admin/view/template/customer/customer_ip.twig

this:

Code: Select all

http://www.geoiptool.com/en/?IP={{ ip.ip }}
in this (used also on report/online)

Code: Select all

//whatismyipaddress.com/ip/{{ ip.ip }}

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 10:35 pm

First commit: Denied. No major incidents reported about those claims. Besides, too many extensions and could also affect local APIs being used. There are frequent posts regarding use of APIs and must not report additional issues. In addition, most of these instructions from Add Creative on this commit shows files that are no longer included in the master branch and even, nowadays, excluded from the pre-release. Security concerns have then been addressed accordingly by removing the extra files.

Second commit: The master branch already contains a removal line of DIR_UPLOAD being replaced with html_entity_decode instead. Hard to know which one is right at this time. Will have to put that one on hold.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 10:39 pm

xxvirusxx wrote:
Sun May 31, 2020 10:31 pm
- admin/view/template/customer/customer_ip.twig

this:

Code: Select all

http://www.geoiptool.com/en/?IP={{ ip.ip }}
in this (used also on report/online)

Code: Select all

//whatismyipaddress.com/ip/{{ ip.ip }}
Fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 10:50 pm


Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by straightlight » Sun May 31, 2020 10:51 pm

xxvirusxx wrote:
Sun May 31, 2020 10:40 pm
Upload somewhere and give me for test :)

LE: Summernote update?

https://github.com/opencart/opencart/pull/6145
https://github.com/opencart/opencart/co ... 8add64e434
Not modifying JS / CSS right now. Bootstrap has been widely modified on the master branch on anyhow. This goes to features later on.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 10:57 pm


Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 11:03 pm

xxvirusxx wrote:
Sun May 31, 2020 11:01 pm
Pagination fix

viewtopic.php?f=24&t=210459
Already fixed in the pre-release. Used the (int)$this->request->get['page'] instead throughout the entire platform. Besides, the master branch also uses the $this->load->controller('common/pagination', array(...)) instead of the old ways to manually call the new Pagination() class.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by xxvirusxx » Sun May 31, 2020 11:05 pm

- Don't allow to save when use only spaces

-- Removed --
Last edited by xxvirusxx on Sun May 31, 2020 11:14 pm, edited 1 time in total.

Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer


User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 11:10 pm

xxvirusxx wrote:
Sun May 31, 2020 11:05 pm
- Don't allow to save when use only spaces

https://github.com/opencart/opencart/pull/7733
https://github.com/opencart/opencart/pull/7737/files
Denied. Only trims the strings. It won't prevent un-trimming the arrays or objects since the request library method also looks for arrays.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

User avatar
Expert Member

Posts

Joined
Tue Jul 17, 2012 10:35 pm
Location - România

Post by straightlight » Sun May 31, 2020 11:17 pm

xxvirusxx wrote:
Sun May 31, 2020 11:14 pm
Filter value issue

https://github.com/opencart/opencart/pull/7832
Not a major but would indeed be more informative to the users ... :ponder:

Ok, fixed.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 4 guests