Ok. I will stop posting
Whether you decide to keep or stop posting, that decision is your own and your own only. However, to recall what you stated on the first page, you want to help but no one assigns your topic. By stop posting your solutions on the topic, your solutions may not be added either. However, while one provides the solutions, even though it may not be prioritized, based on the urgency of the situation, it does not mean the suggested solution may not be added at all. Quite the contrary. This topic is opened for all solutions that have been posted in the past, whether on the forum or on Github Opencart, in order to integrate these bug-fixes into the pre-release version as long as it involves the core.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
The package has now been updated on the Github Opencart releases. I have added several additional fixes posted by engwalid from Github, including SEO language.
@xxvirusxx: Once you will provide the locations on page 1 to where to find the addressed issues for the TWIG custom fields, or provide the Github commit about it, I will take a look at it.
@xxvirusxx: Once you will provide the locations on page 1 to where to find the addressed issues for the TWIG custom fields, or provide the Github commit about it, I will take a look at it.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Change logs has been updated on the first post.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
You forgot to delete 'mysql', from line 185. And php 5 if (phpversion() < '5.4') {straightlight wrote: ↑Sat May 30, 2020 11:40 pm- install step_2 controller: install/controller/install/step_2.php - removed older DB libraries from the $db array.
Typo function name Session and not Sesson
https://github.com/opencart/opencart/pull/7945
Wrong font classstraightlight wrote: ↑Sat May 30, 2020 11:40 pm- admin design layout list TWIG file: admin/view/template/design/layout/translation_list.twig - replaced JS functions with the ones from the master branch by
Code: Select all
<i class="fas fa-pencil-alt">This:
Code: Select all
if (isset($this->positions[2][$this->position][0])) {Code: Select all
if ($this->options['whitespace_trim'] === $this->positions[2][$this->position][0]) {- install/model/install/install.php, deprecated mysql $db->query("SET @@session.sql_mode = 'MYSQL40'");
- admin/controller/common/filemanager.php, this is broken. If you edit a product image, other images doesn't show
- admin/controller/sale/order.php, why this?
Code: Select all
$option_weight = 0.00;Code: Select all
$option_weight = 0;These lines
Code: Select all
catalog/model/account/affiliate/Code: Select all
catalog/model/account/customer/Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
- 5.4 and mysql to be removed from $db: Fixed
- Sesson: Replied to the commit
- SET MODE: Ok, found the commit for this: https://github.com/opencart/opencart/issues/6868 . Unposted on your behalf but fixed
- 7.4: Too soon. The Opencart forum moderating team and forum supporters still recommends users to stick around PHP v7.3.1 to PHP 7.3.9 . There's enough to be concerned between each 7.3.x releases with Opencart. These needs to be dealt first. Besides, I have already added a workaround solution for PHP v7.4 for the payment address and shipping address in the startup, as stated in the change logs, since it was reported as major incident during the first period of the PHP release with Opencart.
- returns: On Github, one says text_return needs to be text_returns and now you're saying the opposite direction. Will put this one on hold for now until being found in the master branch.
- product weight variable: Ok, that is correct. Fixed
- affiliate to customer in events: Fixed
- font class: Fixed.
- Sesson: Replied to the commit
- SET MODE: Ok, found the commit for this: https://github.com/opencart/opencart/issues/6868 . Unposted on your behalf but fixed
- 7.4: Too soon. The Opencart forum moderating team and forum supporters still recommends users to stick around PHP v7.3.1 to PHP 7.3.9 . There's enough to be concerned between each 7.3.x releases with Opencart. These needs to be dealt first. Besides, I have already added a workaround solution for PHP v7.4 for the payment address and shipping address in the startup, as stated in the change logs, since it was reported as major incident during the first period of the PHP release with Opencart.
- returns: On Github, one says text_return needs to be text_returns and now you're saying the opposite direction. Will put this one on hold for now until being found in the master branch.
- product weight variable: Ok, that is correct. Fixed
- affiliate to customer in events: Fixed
- font class: Fixed.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
I think this also need to be changed/fixed -admin/controller/sale/order.php
to (master branch)
Code: Select all
if ($product_option_value_info['weight_prefix'] == '+') {
$option_weight += $product_option_value_info['weight'];
} elseif ($product_option_value_info['weight_prefix'] == '-') {
$option_weight -= $product_option_value_info['weight'];
} Code: Select all
if (!empty($product_option_value_info['weight'])) {
if ($product_option_value_info['weight_prefix'] == '+') {
$option_weight += $product_option_value_info['weight'];
} elseif ($product_option_value_info['weight_prefix'] == '-') {
$option_weight -= $product_option_value_info['weight'];
}
}Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Ok, fixed.xxvirusxx wrote: ↑Sun May 31, 2020 7:49 pmI think this also need to be changed/fixed -admin/controller/sale/order.phpto (master branch)Code: Select all
if ($product_option_value_info['weight_prefix'] == '+') { $option_weight += $product_option_value_info['weight']; } elseif ($product_option_value_info['weight_prefix'] == '-') { $option_weight -= $product_option_value_info['weight']; }Code: Select all
if (!empty($product_option_value_info['weight'])) { if ($product_option_value_info['weight_prefix'] == '+') { $option_weight += $product_option_value_info['weight']; } elseif ($product_option_value_info['weight_prefix'] == '-') { $option_weight -= $product_option_value_info['weight']; } }
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
I have also fixed the addHistory to read addOrderHistory in the events. This one, I have no idea how it ended up in there.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
catalog/controller/information/contact.php
from this:
to this:
from this:
Code: Select all
$mail->setFrom($this->config->get('config_email'));Code: Select all
$mail->setFrom($this->request->post['email']);
Last edited by xxvirusxx on Sun May 31, 2020 8:19 pm, edited 2 times in total.
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Fixed.xxvirusxx wrote: ↑Sun May 31, 2020 8:02 pmcatalog/controller/information/contact.php
from this:to this:Code: Select all
$mail->setFrom($this->config->get('config_email'));Code: Select all
$mail->setFrom($this->request->post['email']);
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Replaced the previous file manager in.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Account return not fixed?
viewtopic.php?f=201&t=200184&p=705802
Rating fix?
https://github.com/opencart/opencart/co ... f3bc4840a8
viewtopic.php?f=201&t=200184&p=705802
Rating fix?
https://github.com/opencart/opencart/co ... f3bc4840a8
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
The account/return, Daniel's taking care of it. As for the rating fix, I did saw this commit yesterday but I am not sure what this really does. It removes the validation but directly uses the $result['rating']. Since the case being, then why keep the config_review_status key in the settings remains the question ...xxvirusxx wrote: ↑Sun May 31, 2020 8:20 pmAccount return not fixed?
viewtopic.php?f=201&t=200184&p=705802
Rating fix?
https://github.com/opencart/opencart/co ... f3bc4840a8
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
- Duplicate time in some files
https://github.com/opencart/opencart/co ... 7199f31e37
- For ratings this user from here
https://github.com/opencart/opencart/issues/7906
Complain about this: "It always shows the rating stars in product lists, Even if the reviews are disabled in the system."
- admin/view/template/mail/affiliate_approve.twig is this {{ text_service }} and language use this text_services
https://github.com/opencart/opencart/co ... 7199f31e37
- For ratings this user from here
https://github.com/opencart/opencart/issues/7906
Complain about this: "It always shows the rating stars in product lists, Even if the reviews are disabled in the system."
- admin/view/template/mail/affiliate_approve.twig is this {{ text_service }} and language use this text_services
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Fixed.xxvirusxx wrote: ↑Sun May 31, 2020 8:28 pmDuplicate time in some files
https://github.com/opencart/opencart/co ... 7199f31e37
For ratings this user from here
https://github.com/opencart/opencart/issues/7906
Complain about this: "It always shows the rating stars in product lists, Even if the reviews are disabled in the system."
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Ok, but this is features. Again, we focus on the majors. The custom datetime fields were a bit large as an issue so it's been all fixed for the next pre-release package now.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
This technically wrong. The from address for the contact form should be the store owners email address and the reply-to the customer's. As the email will be sent via the store owners server or SMTP server, it would be impossible to match the SPF records of the customer email domain or be DKIM signed for the customer email domain. As more and more hosts add outgoing SMTP filters there will be a greater chance the emails will be rejected as spam.straightlight wrote: ↑Sun May 31, 2020 8:14 pmFixed.xxvirusxx wrote: ↑Sun May 31, 2020 8:02 pmcatalog/controller/information/contact.php
from this:to this:Code: Select all
$mail->setFrom($this->config->get('config_email'));Code: Select all
$mail->setFrom($this->request->post['email']);
This fix was handled by Jesse on Github: https://github.com/opencart/opencart/bl ... ontact.php . It is using the $this->request->post['email'] . You'll have to address this issue on the Github Opencart issues tab.ADD Creative wrote: ↑Sun May 31, 2020 8:39 pmThis technically wrong. The from address for the contact form should be the store owners email address and the reply-to the customer's. As the email will be sent via the store owners server or SMTP server, it would be impossible to match the SPF records of the customer email domain or be DKIM signed for the customer email domain. As more and more hosts add outgoing SMTP filters there will be a greater chance the emails will be rejected as spam.straightlight wrote: ↑Sun May 31, 2020 8:14 pmFixed.xxvirusxx wrote: ↑Sun May 31, 2020 8:02 pmcatalog/controller/information/contact.php
from this:to this:Code: Select all
$mail->setFrom($this->config->get('config_email'));Code: Select all
$mail->setFrom($this->request->post['email']);
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Who is online
Users browsing this forum: No registered users and 4 guests
