Post by yveveke » Wed May 12, 2010 4:12 pm

The bug is at /system/library/tax.php at line 25
$tax_rate_query = $this->db->query("SELECT tr.tax_class_id, SUM(tr.rate) AS rate, tr.description, tr.priority FROM ... GROUP BY tr.priority ORDER BY tr.priority ASC
The different tax rates with the same priority are calculated together in a zone.

Newbie

Posts

Joined
Wed Mar 17, 2010 6:15 pm
Location - Belgium

Post by Qphoria » Wed May 12, 2010 7:50 pm

OSWorX wrote: btw: with US I guess you mean the United States of America and not the United States of Central or South America or Russia?
And the US is 1 country but 50 states (48 plus Alaska & Hawaii) where states means here federal states (country could be also state if translated where state could also mean [federal] state).
Qphoria wrote:United states IS one country
I said "United States". not "US"
and later I referred to "USA" which has no question. Great job on the geography lesson.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by OSWorX » Wed May 12, 2010 8:53 pm

Great - and the tax bug is a bug.

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by Qphoria » Wed May 12, 2010 9:41 pm

OSWorX wrote:Great - and the tax bug is a bug.
Calm the hell down.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Qphoria » Wed May 12, 2010 9:42 pm

OK. I can finally see this now. The trick is not to have 2 states.. but 2 different classes using the same state
IL Tax Class 1 - 20%
IL Tax Class 2 - 10%

now I see
$100
10% discount (-30.00) <---- wrong
Total 70.00

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by linuxaisle » Wed May 12, 2010 10:07 pm

Wouldn't that be expected behavior?

OpenCart user since 4/27/10


New member

Posts

Joined
Wed Apr 28, 2010 2:01 pm

Post by Qphoria » Wed May 12, 2010 10:34 pm

No. because they are 2 different tax "classes". Not rates.

Product A has Tax Class "IL Tax 1"
Product B has Tax Class "IL Tax 2"

It would be correct if I had 2 separate "Rates" inside of the "Class"
But in this case I have 2 separate "Classes"

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by OSWorX » Thu May 13, 2010 5:17 am

Okay, no it is known where/what the problem is.
Till when will this be fixed?

Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.


User avatar
Administrator

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by Qphoria » Thu May 13, 2010 5:44 am

It will be fixed when you stop whining

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Thu May 13, 2010 8:57 pm

The Low Ordering Fee module does not calculate the Tax on checkout.
The Handling Fee module does.

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Thu May 13, 2010 11:57 pm

i2Paq wrote:The Low Ordering Fee module does not calculate the Tax on checkout.
The Handling Fee module does.
Confirmed. There is some copy/paste from the handling_fee total inside the low_order fee total

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Qphoria » Fri May 14, 2010 12:00 am

Ok for the tax bug try this:
1. EDIT: system/library/tax.php

2. FIND:

Code: Select all

$tax_rate_query = $this->db->query("SELECT tr.tax_class_id, SUM(tr.rate) AS rate, tr.description, tr.priority FROM " . DB_PREFIX . "tax_rate tr LEFT JOIN " . DB_PREFIX . "zone_to_geo_zone z2gz ON (tr.geo_zone_id = z2gz.geo_zone_id) LEFT JOIN " . DB_PREFIX . "geo_zone gz ON (tr.geo_zone_id = gz.geo_zone_id) WHERE (z2gz.country_id = '0' OR z2gz.country_id = '" . (int)$country_id . "') AND (z2gz.zone_id = '0' OR z2gz.zone_id = '" . (int)$zone_id . "') GROUP BY tr.priority ORDER BY tr.priority ASC");
3. REPLACE WITH:

Code: Select all

$tax_rate_query = $this->db->query("SELECT tr.tax_class_id, tr.rate AS rate, tr.description, tr.priority FROM " . DB_PREFIX . "tax_rate tr LEFT JOIN " . DB_PREFIX . "zone_to_geo_zone z2gz ON (tr.geo_zone_id = z2gz.geo_zone_id) LEFT JOIN " . DB_PREFIX . "geo_zone gz ON (tr.geo_zone_id = gz.geo_zone_id) WHERE (z2gz.country_id = '0' OR z2gz.country_id = '" . (int)$country_id . "') AND (z2gz.zone_id = '0' OR z2gz.zone_id = '" . (int)$zone_id . "') ORDER BY tr.priority ASC");
Last edited by i2Paq on Fri May 14, 2010 12:47 am, edited 1 time in total.
Reason: Added to the confirmed bugs on page 1

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by ifyouseek » Fri May 14, 2010 1:23 am

hey, im not sure if this has been pointed out already but i found issues when changing the weight class in Admin>system>settings>Local .

This may just an issue with the UK Royal Mail shipping option but i have to keep the weight class on KG for this shippping module to work. Otherwise it assumes my items weighs loads and doesnt provide the correct shipping price or options. This is sort of an issue as all my products weigh no more than a couple of grams

Active Member

Posts

Joined
Thu May 06, 2010 4:40 pm

Post by linuxaisle » Fri May 14, 2010 5:40 am

There are multiple bugs on the account create page (and address page) where the script does not validate the length of the inputs correctly, or at least there is a mismatch with the required lengths and the wording of error messages.

For example:
I do not enter a first name, it returns "First Name must be greater than 1 and less than 32 characters!"
I enter "F" as the first name, there is no error even though it is not greater than 1 character.

Code: Select all

    	if ((strlen(utf8_decode($this->request->post['firstname'])) < 1) || (strlen(utf8_decode($this->request->post['firstname'])) > 32)) {
      		$this->error['firstname'] = $this->language->get('error_firstname');
    	}
Very easy to see here that it only returns an error if the input has "< 1" characters instead of "<= 1". Same concept for the maximums. Make sense?

OpenCart user since 4/27/10


New member

Posts

Joined
Wed Apr 28, 2010 2:01 pm

Post by Qphoria » Fri May 14, 2010 9:23 pm

nitpicky much. Yes all the error messages should say "Between 1 and 32 characters"...

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by eka7a » Fri May 14, 2010 10:30 pm

Liqpay checkout confirm button inactivated

SSL Certificates


User avatar
Active Member

Posts

Joined
Sun Apr 12, 2009 12:59 am
Location - Türkiye

Post by Qphoria » Fri May 14, 2010 10:42 pm

eka7a wrote:Liqpay checkout confirm button inactivated
Confirmed. To fix:
1. EDIT: catalog/controller/payment/liqpay.php

3. FIND:

Code: Select all

public function callback() { 
2. BEFORE, ADD:

Code: Select all

    public function confirm() {
        return;
    } 

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Qphoria » Fri May 14, 2010 10:51 pm

i2Paq wrote: Aha, you where not referring to MY tax bug ;)
Which tax bug ?

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Fri May 14, 2010 10:58 pm

Qphoria wrote:
i2Paq wrote: Aha, you where not referring to MY tax bug ;)
Which tax bug ?
This one:
i2Paq wrote:The Low Ordering Fee module does not calculate the Tax on checkout.
The Handling Fee module does.

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Fri May 14, 2010 11:03 pm

yea thats fixed too. just edit the low_order file in catalog/model/total/low_order
and replace the copy/paste of "handling" with "low_order"

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am
Who is online

Users browsing this forum: No registered users and 19 guests