text_empty issue [solved]

Post by virtualgadjo » Thu Dec 21, 2017 9:52 pm

Hi all,

first message for me here so, glad to meet you

i'm running into a funny little issue, when i click on en empty category or run a search with no result, it's always the language/common/cart.php text_empty string that is displayed instead of the product/category.php or the search.php one
in order to be sure i've replaced the original string by a personal one i can't miss

if any of you had an idea that would help solve this, i would be lifelong grateful
all the best
chris

Post by straightlight » Thu Dec 21, 2017 11:38 pm

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester

Post by virtualgadjo » Fri Dec 22, 2017 12:38 am

Hi straightlight,

thanks a lot for your answer and, you know, as soon as i clicked on submit, i slapped my head and was waiting for my post to appear to add "sorry guys, forgot to say, using the very last opencart release (3.0.2.0)"

i talked a little with the great guys behind journal2 to see if they had any insight about this but having investigated a bit they ended thinking like i was that it must be an opencart issue

the website is currently local and i use extensively url_rewriting but i could easily reproduce the problem with, for example
route=product/manufacturer/info&manufacturer_id=8 (no products for this manufacturer)
or
route=product/search&search=toto&description=true (of course, no result for toto in the search field)
same for
guitares-acoustiques/guitares-acoustiques-occasions for example with url rewriting which routes to category_id=67 that has no products (yet )

actually whichever page that has no product in it displays the cart.php text_epty string instead of the category/search/ and so on text_empty one, funny isn't it?

thanks again for your time and answer
all the best
chris

Post by straightlight » Fri Dec 22, 2017 12:43 am

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester

Post by virtualgadjo » Fri Dec 22, 2017 1:00 am

Hi again,

and now to say that those great guys i talked about above that are behind journal2 theme found out the solution, it's an opencart little issue
in case it helps anybody else, solved by adding

Code: Select all

$data['text_empty'] = $this->language->get('text_empty');

before

Code: Select all

$data['breadcrumbs'] = array();

in the catalog/product/controller/category.php, search.php, special.php and manufacturers controllers (refreshing opencart modification afterwards)

have a great day and thanks again for having taken time to answer
all the best
chris

Post by webs_bd » Wed Apr 04, 2018 8:33 pm

Big Decision
Website Production, Ecommerce & Digital Marketing in the UK
http://www.bigdecision.co.uk

Post by dpanderson » Thu Apr 05, 2018 2:01 am

Post by straightlight » Thu Apr 05, 2018 2:03 am

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester

Post by dpanderson » Thu Apr 05, 2018 3:08 am

Post by leeburgess » Wed Aug 01, 2018 3:01 am

Post by HSLGuy » Sat Aug 04, 2018 2:42 am

$data['text_empty'] = $this->language->get('text_empty');

$data['breadcrumbs'] = array();

$data['addresses'] = array();

$this->document->setTitle($this->language->get('heading_title'));

$this->document->setTitle($this->language->get('heading_title'));

$data['continue'] = $this->url->link('common/home');

Post by devth » Mon Apr 29, 2019 11:45 am

$data['header'] = $this->load->controller('common/header');

$this->load->language('common/cart');

Post by straightlight » Mon Apr 29, 2019 7:25 pm

devth wrote: ↑

Mon Apr 29, 2019 11:45 am

This problem is caused by this line in every page.

Code: Select all

$data['header'] = $this->load->controller('common/header');

It will load controller/common/cart.php that will load its language file by this line.

Code: Select all

$this->load->language('common/cart');

So, text_empty in every page will be replaced by controller/common/cart.php.
For me, I fix it by change "text_empty" to "text_empty_cart" in these files.

common/cart.twig
language/en-gb/common/cart.php

Ahh ! yes, as explained to Daniel regarding the conflicted array keys on Github.

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester

Post by Mr.Pikatchu » Mon Sep 23, 2019 6:41 pm