Cart items not clearing after checkout

EvolveWebHosting wrote:I added this to system/library/cart.php for v2.0.1.1 and it seems to be working so far.

if (isset($this->session->data['customer_id'])) {
$this->db->query("UPDATE " . DB_PREFIX . "customer SET cart = '' WHERE customer_id = '" . (int)$this->session->data['customer_id'] . "'");
}

Qphoria wrote:

EvolveWebHosting wrote:I added this to system/library/cart.php for v2.0.1.1 and it seems to be working so far.

if (isset($this->session->data['customer_id'])) {
$this->db->query("UPDATE " . DB_PREFIX . "customer SET cart = '' WHERE customer_id = '" . (int)$this->session->data['customer_id'] . "'");
}

where did you add that? That code would empty your cart immediately anytime the cart is loaded
in 2.1.x it would delete the cart instantly and people would be confused why they click Add to cart and nothing gets added because it is being deleted immediately after.

There is no bug in OpenCart with this. If you are having this problem, it is either caused by payment configuration or another mod breaking the process and the customer never gets to the success page. The cart is cleared ON the success page, if you don't make it there, something else is causing that and there are no known bugs causing that.

Qphoria wrote:Not likely theme related but if all payments are experiencing it then it could be an order completion problem caused by a vQmod or ocmod. Common mods that cause this are like enhanced email mods or mods that report order details to other sites. These types of mods add themselves right to the common order confirmation function so if there is an error caused, it stops all order finalization.

not sure what line 330 is for you as that is the getTaxes function for me and that wouldn't make sense.

Qphoria wrote:Well it's basically 6 vs half-dozen.. That change actually clear their saved cart and in versions that have the "Login as this customer" feature from the admin will actually cause the customer's saved cart to clear.

Here is the flow:
Checkout->pay->success page
The success page calls that system library "clear()" function and clears the cart.
The cart class itself calls the update db cart when the session is cleared.

So calling it there is a bandaid which clears the cart on login to mask the problem. But the real underlying problem is that the success step isn't getting called correctly.

Qphoria wrote:Well it's basically 6 vs half-dozen.. That change actually clear their saved cart and in versions that have the "Login as this customer" feature from the admin will actually cause the customer's saved cart to clear.

Here is the flow:
Checkout->pay->success page
The success page calls that system library "clear()" function and clears the cart.
The cart class itself calls the update db cart when the session is cleared.

So calling it there is a bandaid which clears the cart on login to mask the problem. But the real underlying problem is that the success step isn't getting called correctly.

public function clear() {
		$this->db->query("DELETE FROM " . DB_PREFIX . "cart WHERE customer_id = '" . (int)$this->customer->getId() . "' AND session_id = '" . $this->db->escape($this->session->getId()) . "'");
	}