2.2 event not triggering after protected method

florinsith wrote:Since its private then it is called from within the class so the callback method from loader isnt used (and that is where the model events get loaded). Maybe you could link it to the method calling the private one if its not called from within as well.
As for the product_id, it is beeing returned by the addProduct method, and since your event is after, the return is added to args.

JeffroDH wrote:Also, are you saying that all of the variables within the scope of the triggering method are available to be passed (by name) to the triggered method?

$this->model_route_ofmodel->methodName();

florinsith wrote:Input params for :before event and input params + return for :after events.

florinsith wrote: Changing it to public I dont think will solve the issue because it would still be called inside the object. The methods supporting events are the ones called like:

Code: Select all

$this->model_route_ofmodel->methodName();

Id say since you are willing to modify that file to change the method to public then you could just modify the method and put your code in there.(or maybe via ocmod)

straightlight wrote:An additional methodology I would recommend rather than putting any method from private / protected methods would be to propagate the Opencart registry into the __construct method instead. Then, from the library / engine file, simply callback your initialized class name and reuse it into your preferred method instead.

To answer your question; setting the method to public would allow Opencart to access the preferred method throughout possibly the entire script as I do not fully recommend this approach for security / conflict reasons since extensions are involved with Opencart and the Object Registry from Opencart is already propagating and recalled from its engine and can be re-called at any time throughout the model files or by directly using the long object recall method manually once being passed to the method parameter.

JeffroDH wrote:

straightlight wrote:An additional methodology I would recommend rather than putting any method from private / protected methods would be to propagate the Opencart registry into the __construct method instead. Then, from the library / engine file, simply callback your initialized class name and reuse it into your preferred method instead.

To answer your question; setting the method to public would allow Opencart to access the preferred method throughout possibly the entire script as I do not fully recommend this approach for security / conflict reasons since extensions are involved with Opencart and the Object Registry from Opencart is already propagating and recalled from its engine and can be re-called at any time throughout the model files or by directly using the long object recall method manually once being passed to the method parameter.

I understand the words that you're typing, but not what they mean when put together. I suspect that's because I don't have any knowledge of how the OC registry/engine works. I'm trying to decipher the __construct ->library->callback, but it is simply going over my head.

JeffroDH wrote: So for any event I register that is triggered ::before the Method indicated, the input parameters are available, and additionally I can access the data returned by the Method for events that are triggered ::after the Method?

According to the documentation, any Method can be a trigger for an event, but only a method inside a controller can be triggered. Do I have that right? If so, then my code should be able to be triggered by the method in question.

//before
$result = $registry->get('event')->trigger('model/' . $route . '/before', array_merge(array(&$route), $args));
....
//method called
$output = call_user_func_array(array($model, $method), $args);
....
//after
$result = $registry->get('event')->trigger('model/' . $route . '/after', array_merge(array(&$route, &$output), $args));