setting/store -> unused variable $store_total ?

Quote

Post by martin11 » Wed Nov 20, 2013 4:36 am

I found out there is a unused variable in admin/controller/setting/store.php on line 114:

Image

What is this variable here for? If it is really unused I suggest to remove it.
Link to source: https://github.com/opencart/opencart/bl ... e.php#L114
martin11
Newbie
Posts
3
Joined
Mon Jul 30, 2012 1:45 am
Top

Re: setting/store -> unused variable $store_total ?

Quote

Post by MarketInSG » Wed Nov 20, 2013 6:27 pm

I think it isn't used since there's no pagination for the stores listing page.

User avatar
MarketInSG
Guru Member
Posts
6443
Joined
Wed Nov 16, 2011 11:53 am
Location - Singapore
Top

Re: setting/store -> unused variable $store_total ?

Quote

Post by martin11 » Thu Nov 21, 2013 6:42 pm

Yes, that's why I suggest to remove it from source code.
martin11
Newbie
Posts
3
Joined
Mon Jul 30, 2012 1:45 am
Top
Post Reply
Return to “Feature Requests”
Who is online

Users browsing this forum: No registered users and 5 guests