Issues with contribution PayPal Improved

Code: Select all

        $sql = "select `order_status_id` from `order_status` where `name` = '?' and `language_id` = '?'";
        $parsed = $this->database->parse($sql, $this->language->get('order_status_paid_unconfirmed'), $this->language->getId()); 
        $results = $this->database->getRow($parsed);
        if ($results)
        {
            $this->order->process($results['order_status_id']);
        }
        else
        {
            // I think it may be better to die here with a message as it is
            // a major configuration problem that should be found by even
            // the most basic testing and hence not impact upon a customer.
            die('Configuration error: You MUST have created an order status for "Paid Unconfirmed" for every installed language. The following sql statement returned no rows ' . $parsed);
            //  The following is a reasonable alternative but there is no way without making
            //  changes to checkout_failure, to get a user defined message to the that page.
            //  The message, as above, is a big help in tracking any teething problems with this code.
            //$this->response->redirect($this->url->ssl('checkout_failure'));   
        }        

Code: Select all

       else
        {
            $this->order->process();
            // I think it may be better to die here with a message as it is
            ...
        } 
 

Code: Select all

function callback() {
		$req = 'cmd=_notify-validate';

		foreach ($_POST as $key => $value) {
			$req .= '&' . $key . '=' . urlencode(stripslashes($value));
		}

		$header  = 'POST /cgi-bin/webscr HTTP/1.0' . "\r\n";
		$header .= 'Content-Type: application/x-www-form-urlencoded' . "\r\n";
		$header .= 'Content-Length: ' . strlen($req) . "\r\n\r\n";
		
		if (!$this->config->get('paypal_test')) {
			$fp = fsockopen('ssl://www.paypal.com', 443, $errno, $errstr, 30);
		} else {
			$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
		}
		
		if ($fp) {
			fputs($fp, $header . $req);
			
			while (!feof($fp)) {
				$res = fgets($fp, 1024);
				
				if (strcmp($res, 'VERIFIED') == 0) {
					$this->order->load($this->request->get('invoice', 'post'));
						
					$this->order->process();
				}
			}
			
			fclose($fp);
		}
  	}

Code: Select all

	function callback() {
		$req = 'cmd=_notify-validate';

		foreach ($_POST as $key => $value) {
			$req .= '&' . $key . '=' . urlencode(stripslashes($value));
		}

		$header  = 'POST /cgi-bin/webscr HTTP/1.0' . "\r\n";
		$header .= 'Content-Type: application/x-www-form-urlencoded' . "\r\n";
		$header .= 'Content-Length: ' . strlen($req) . "\r\n\r\n";
		
		if (!$this->config->get('paypal_test')) {
			$fp = fsockopen('ssl://www.paypal.com', 443, $errno, $errstr, 30);
		} else {
			$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
		}
		
		if ($fp) 
        {
			fputs($fp, $header . $req);			
			while (!feof($fp))
				$res = fgets($fp, 1024);
			        
            fclose($fp);
	
            $pos = strpos($res, 'VERIFIED');
			if ($pos === false)
            {
                //  Payment is not verified so there is nothing we need to do.
            }
            else 
            {
                //
                //  The payment is verified so we try to change the status from Paid Unconfirmed to Pending
                //  but only if the status is currently Paid Unconfirmed. A change to any other value
                //  has probably been made by the store administrator.
                //
                //  Remember also, that we are not relying on this to succeed and that it is being 
                //  executed by a callback from paypal. Hence there is no error recovery required.
                //  
                $paidUnconfirmedStatus = 0;
                $pendingStatus = 0;
                                   
        $sql = "select `order_status_id` from `order_status` where `name` = '?' and `language_id` = '?'";
                $parsed = $this->database->parse($sql, $this->language->get('order_status_pending'), $this->language->getId()); 
                $results = $this->database->getRow($parsed);
                if ($results)
                {
                    $pendingStatus = $results['order_status_id'];
                }
                //
                //  Perhaps the IPN from paypal has arrived before the user has returned from
                //  the paypal web site OR the user has not returned at all. 
                //  In response to either case, we should load and process the order.
                //             
		$reference = $this->request->get('invoice', 'post');
                if ($this->order->load($reference))
                {
                    //  IPN is winner or customer never returned and IPN arrived.
                    //  default status should be Pending so the update below will have no
                    //  effect if we process the order here but the end result is still correct.
                    $this->order->process(); 
                }
  else
        {
		 $this->order->process();
            // I think it may be better to die here with a message as it is
            // a major configuration problem that should be found by even
            // the most basic testing and hence not impact upon a customer.
            die('Configuration error: You MUST have created an order status for "Paid Unconfirmed" for every installed language. The following sql statement returned no rows ' . $parsed);
            //  The following is a reasonable alternative but there is no way without making
            //  changes to checkout_failure, to get a user defined message to the that page.
            //  The message, as above, is a big help in tracking any teething problems with this code.
            //$this->response->redirect($this->url->ssl('checkout_failure'));   
        }        
                $sql = "update `order` set `order_status_id` = '?' where `reference` = '?' and `order_status_id` = '?'";
                // bug fix from asif
	            //$parsed = $this->database->parse($sql, $paidUnconfirmedStatus, $reference, $pendingStatus);
                $parsed = $this->database->parse($sql,  $pendingStatus, $reference, $paidUnconfirmedStatus);
                $this->database->query($parsed);
			}
//				$reference = $this->request->get('invoice', 'post');
//                $sql = "update `order` set `order_status_id` = '?' where `reference` = '?' and `order_status_id` = '?'";
//                // bug fix from asif
//                //$parsed = $this->database->parse($sql, $paidUnconfirmedStatus, $reference, $pendingStatus);
//                $parsed = $this->database->parse($sql,  $pendingStatus, $reference, $paidUnconfirmedStatus);
//                $this->database->query($parsed);
			//}
		}
  	}