Issues with contribution PayPal Improved

bruce wrote: I am looking forward to seeing how it will be done.

What you have suggested does eliminate the race condition but makes it difficult to handle the circumstance where the user fails to complete the payment. Now we have an order, but the customer cannot try to make the payment again because the order data is gone and the cart is empty.

Lets keep the new workflow and eliminate the race condition. First we need another table to hold order verifications. The callback can try to update the order status but if it fails then it puts a record in the verifications table. Second, we need some code to check for records in the verifications table, look for the processed order and update it's status, deleting the record in the verifications table on success. Finally, we need an event to trigger that code every so often.

D4T wrote: Hi,

I am having problems with the improved paypal extension too, my problem is that if the user pays and gets the paypal confirmation page then quits there browser before they are redirected back to my site I end up with no order in the Admin -> Customer -> Order even though the Paypal callback to the site has been successful.

Maybe I am doing something wrong but I cannot see what I have done if that is the case.

Also I am no PHP man unfortunately, but in your process() function I cannot see in the code where the order status is updated to "Paid Unconfirmed". Maybe you can point this out to me as I only see a sql select and no update?

asif wrote:

D4T wrote: Hi,

I am having problems with the improved paypal extension too, my problem is that if the user pays and gets the paypal confirmation page then quits there browser before they are redirected back to my site I end up with no order in the Admin -> Customer -> Order even though the Paypal callback to the site has been successful.

Maybe I am doing something wrong but I cannot see what I have done if that is the case.

Also I am no PHP man unfortunately, but in your process() function I cannot see in the code where the order status is updated to "Paid Unconfirmed". Maybe you can point this out to me as I only see a sql select and no update?

yeh it will not insert the record even if u get a postback from PayPal in the case when ur customer closed the browser before getting back to ur site. It is so because Process() function gets executed when user hits ur site after paying at PayPal, and in Process() function it inserts the order with paid_unconfirmed status. When u receive postback from paypal, callback() gets exeecuted and it just changes the order status. So if customer didnt hit back, there will be no order in the database, so nothing will be updated with Paid status. Yes, its an issue with this contribution. Bruce may be workin on this issue to improve...

D4T wrote: I am having problems with the improved paypal extension too, my problem is that if the user pays and gets the paypal confirmation page then quits there browser before they are redirected back to my site I end up with no order in the Admin -> Customer -> Order even though the Paypal callback to the site has been successful.

D4T wrote: Also I am no PHP man unfortunately, but in your process() function I cannot see in the code where the order status is updated to "Paid Unconfirmed". Maybe you can point this out to me as I only see a sql select and no update?

        $parsed = $this->database->parse($sql, $this->language->get('order_status_paid_unconfirmed'), $this->language->getId()); 
        $results = $this->database->getRow($parsed);
        if ($results)
        {
            $this->order->process($results['order_status_id']);
        }
   

bruce wrote:The customer has gone to another web site (paypal) to make the payment. If they do not return, there is no way of knowing what they have done.

• Customer pays and does not return and the IPN fails => Customer cart is still intact and order is still in order_data ie not processed.
• Customer pays and returns and the IPN returns at the same time => This could get messy but duplicates are a possiblity.

	function process($order_status_id = NULL) 
	{
		if ($this->data) 
		{

			$database->query( "START TRANSACTION" );

			// existing code here... except for email send

			$database->query("COMMIT;");

			// move the email  send to here because we do not want errors in email to rollback the database work
		}
	}