Post by OC2PS » Sun Nov 29, 2009 3:47 am

The tabs are not working well at
http://www.csillamvilag.com/shop/csill% ... extra_glue

At first product descriptions seems ok - till you scroll down to see photos, reviews, and related products.

But that's bearable. Thereal problem is that clicking on photos, reviews or related products makes things worse...product description disappears but on all 3 tabs reviews, photos and related products appear on the same page...in that order.

The tabs seem to be working fine on other products:
http://www.csillamvilag.com/shop/Csill% ... est%C3%A9s

OC2PS
OC 3.0.3.7, vQmod 2.6.2, Journal3 theme
Arcfesték, Csillámtetoválás, Henna
Image
Check out: All my extensions | My FREE extensions


User avatar
Active Member

Posts

Joined
Wed Jul 22, 2009 4:15 am
Location - Hungary

Post by Qphoria » Sun Nov 29, 2009 5:19 am

This is not a bug. You have lots of customizations to that template and lots of problems like the breadcrumb bar being mixed with the language bar.

This is a personal problem to your site. I will move it to the proper place

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by OC2PS » Sun Nov 29, 2009 7:25 am

Qphoria wrote:This is not a bug.
Well, if it was a problem caused by customizations (and I do have some - like the misplaced breadcrumbs and language flags), then it would be on every product. Since everything is fine in most places, and just one page (so far) seems to be acting up, it would seem like a bug.

OC2PS
OC 3.0.3.7, vQmod 2.6.2, Journal3 theme
Arcfesték, Csillámtetoválás, Henna
Image
Check out: All my extensions | My FREE extensions


User avatar
Active Member

Posts

Joined
Wed Jul 22, 2009 4:15 am
Location - Hungary

Post by Qphoria » Sun Nov 29, 2009 7:55 am

But its not on the default template and its not in the core code. If there are customizations or you have some strange characters in the product description, that is your bug. Bugs are only for actual problems with OpenCart on a fresh install.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by moggiex » Sun Nov 29, 2009 4:30 pm

That bottom section of the product pages is really touchy, if you mess around with that lower section, place the reviews div (the one with all the review code in it) at the beginning and that solved it jumping or completely failing to show.

Matt

Code: Select all

It was like that when I found it, honest!


User avatar
Active Member

Posts

Joined
Mon Nov 09, 2009 9:55 pm

Post by OC2PS » Sun Nov 29, 2009 5:07 pm

moggiex wrote:if you mess around with that lower section, place the reviews div (the one with all the review code in it) at the beginning and that solved it jumping or completely failing to show.
Matt, thanks for responding. I'm not quite sure what you meant. Please can you elaborate?

OC2PS
OC 3.0.3.7, vQmod 2.6.2, Journal3 theme
Arcfesték, Csillámtetoválás, Henna
Image
Check out: All my extensions | My FREE extensions


User avatar
Active Member

Posts

Joined
Wed Jul 22, 2009 4:15 am
Location - Hungary

Post by moggiex » Sun Nov 29, 2009 5:34 pm

Sure

See /catalog/view/theme/default/template/product/product.tpl

Look for a DIV that looks similar to this (mine is altered, hence the asterix's):

Code: Select all

    <div class="tabs">
		<a tab="#tab_description"***s</a>
		<a tab="#tab_image">		<?php echo $tab_image; ?></a>
		<a tab="#tab_review">		<?php echo $tab_review; ?></a>
		<a tab="#tab_related">		<?php echo $tab_related; ?></a>
		<a tab="#tab_images">		*** </a>
	</div>
This is where swicther for the tabs and the tab DIV's start after this.

Now after this section look for the opening DIV:

Code: Select all

<div id="tab_review" class="tab_page">
And cut/paste the contents of that DIV (remember to get the closing DIV too!!)to just after the closing DIV of the 'switcher' tabs are, so it reads something like this:

Code: Select all

    <div class="tabs">
		<a tab="#tab_description">        ***s</a>
		<a tab="#tab_image">		<?php echo $tab_image; ?></a>
		<a tab="#tab_review">		<?php echo $tab_review; ?></a>
		<a tab="#tab_related">		<?php echo $tab_related; ?></a>
		<a tab="#tab_images">		*** </a>
	</div>

<div id="tab_review" class="tab_page">
	<!-- Some reviews code here -->
</div>
By putting it first, but keeping the switcher tabs in the same order, seems to make it 'behave' and no pop out or completely fail to show.

Matt

PS. If this doesn't solve it, you've foobared some html or PHP above it and for that, good luck!

Code: Select all

It was like that when I found it, honest!


User avatar
Active Member

Posts

Joined
Mon Nov 09, 2009 9:55 pm

Post by OC2PS » Mon Nov 30, 2009 1:38 am

Works! Beautiful! Thanks, Matt!

Curious though: why does changing the order outside of the switcher div make tabs behave?

OC2PS
OC 3.0.3.7, vQmod 2.6.2, Journal3 theme
Arcfesték, Csillámtetoválás, Henna
Image
Check out: All my extensions | My FREE extensions


User avatar
Active Member

Posts

Joined
Wed Jul 22, 2009 4:15 am
Location - Hungary

Post by Qphoria » Mon Nov 30, 2009 10:42 am

If you break 1 div, then all other closing div tags offset by one

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am
Who is online

Users browsing this forum: No registered users and 6 guests