Ampersands are not properly encoded in URL's

Quote

Post by AndreasT » Sat Dec 01, 2007 5:57 pm

The Create function in url.php does not properly encode ampersands, so XHTML validation fails.

Code: Select all

    	if ($action) {
      		$link .= '&action=' . $action;
    	}
    
		foreach ($query as $key => $value) {
	  		if ($value) {
	    		$link .= '&' . $key . '=' . urlencode($value);
	  		}
		}
Simply substituting & with

Code: Select all

&
breaks functionality in other places.

Cheers,

Andreas
AndreasT
Newbie
Posts
7
Joined
Tue Oct 23, 2007 6:51 am
Top

Re: Ampersands are not properly encoded in URL's

Quote

Post by JNeuhoff » Wed Dec 05, 2007 5:45 pm

I noticed that, too. I am new to OpenCart, but I have to fix it for my latest online store project. I also hope to get the templates updated to the XHTML 1.0 Transitional standard.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7487
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: Ampersands are not properly encoded in URL's

Quote

Post by JNeuhoff » Fri Dec 07, 2007 9:48 pm

I have now created a fix for the not properly encoded ampersands, as part of making the whole lot XHTML 1.0 compliant. See my announcement at http://forum.opencart.com/index.php?topic=720.0

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7487
Joined
Wed Dec 05, 2007 3:38 am
Top
Locked
Return to “Development”
Who is online

Users browsing this forum: No registered users and 1 guest