Post by Daniel » Fri Jul 31, 2009 8:26 pm

Does any one think its a good idea to get rid of the controller layout class?

If you look at lot of other projects they seem to just have a header and footer class rather than a layout.

the header would be responsable for settign the title, descriptions and modules.

Does any one think this is a good idea?

it would mean none of the old templates would work.

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by Qphoria » Fri Jul 31, 2009 9:36 pm

I know zencart does this on a per module basis... tho I find it somewhat unintuitive. but how about the sidebox layouts and such? would that also be set in the header?

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by phpuk » Fri Jul 31, 2009 11:45 pm

Hmm,

Users already complain like hell about the lack of a seamless upgrade to the next version. Do you really want them to have to redesign all of their templates as well?

Just a thought...

Phil.

Global Moderator

Posts

Joined
Wed Mar 25, 2009 10:57 am

Post by CodeBits » Sun Aug 02, 2009 8:29 am

BAD Idea. To take away ability to create designs beyond a header and footer would suck big time. Don't even consider it PLEASE!!!

User avatar
Active Member

Posts

Joined
Fri Jun 05, 2009 3:16 am

Post by gichuru » Mon Aug 03, 2009 5:02 pm

That is a very bad idea...

I would even suggest if Smarty tags can be used then it would even be much better , Users should be able to use their old template with new versions of Opencart... just my 2cents

Newbie

Posts

Joined
Sat Aug 01, 2009 2:06 pm

Post by CodeBits » Mon Aug 03, 2009 5:13 pm

I personally don't care for programs like Smarty :P , but that's me... just let me keep the flexibility and freedom to hand code a layout and I'm a happy camper. It is to bad the templates are not compatible with new versions, but I'd rather live with that than loose the ability to hand code a design.

User avatar
Active Member

Posts

Joined
Fri Jun 05, 2009 3:16 am

Post by gichuru » Mon Aug 03, 2009 6:21 pm

:) thats why you are called codebit.. you can code to bits... the simpler the better for us with simpler names ;)

Newbie

Posts

Joined
Sat Aug 01, 2009 2:06 pm

Post by Qphoria » Mon Aug 03, 2009 7:23 pm

See here why smarty makes no sense:
http://forum.opencart.com/viewtopic.php ... rty#p24378

Also, why learn another language syntax when php is simpler yet more powerful, and applies to all php applications the same way.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by robbercrombie » Mon Aug 03, 2009 10:48 pm

will there be any improvements to the cart by doing so?
if not, i do not see why you should change it
and i totally agree with Phil

~ Robbercrombie


User avatar
New member

Posts

Joined
Mon Jul 20, 2009 5:05 pm


Post by orionweb » Tue Aug 04, 2009 5:35 pm

It really makes no difference in the end, and anyone who is making a hardcore theme will potentially modify and edit the entire layout code anyway, so I would just leave it!

Image
Image


New member

Posts

Joined
Sun Jul 19, 2009 10:18 am

Post by Daniel » Tue Aug 04, 2009 10:56 pm

I'm only thinking of doing for personal coding preference.

I prefer on having children and drilling down and not having parents e.g. layout.

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by Qphoria » Tue Aug 04, 2009 11:52 pm

Well if you have a proof of concept working, that could be cool to see.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by orionweb » Wed Aug 05, 2009 12:06 am

It would just suck to have to re-do a whole template in order to update the cart software as well, unless you offered the template system update as an alternate download.

Image
Image


New member

Posts

Joined
Sun Jul 19, 2009 10:18 am

Post by Qphoria » Wed Aug 05, 2009 12:07 am

how many files of the template have you actually modified? mostly the css and a few placements maybe.. but most files are rarely touched anyway. First lets see what's involved with the new method to see if maybe its easier or more powerful

Perhaps make it a v130-nolayout.zip version that is no diff from the current v130.. then decide which is better and go that way.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Rich » Wed Aug 05, 2009 2:17 am

Perhaps make it a v130-nolayout.zip version that is no diff from the current v130.. then decide which is better and go that way.
I agree with Qphoria. This will be probably the best way to find out what is the better way to go.
I am now working on template for OpenCart now ( it will be finish in couple days so I will post it here ) so I like to try out the version what you Daniel are proposing just to find out what takes more time and what you can do with it.

Rich
Bird is the word


New member

Posts

Joined
Tue Jul 28, 2009 2:56 am
Location - Bird Cage

Post by orionweb » Wed Aug 05, 2009 5:05 am

It would be cool if you did this to include a small set of instructions for theme makers to update their templates so that they can be used in newer versions. I guess it would only be a paragraph or two, copy this paste it here... that sort of thing.

Image
Image


New member

Posts

Joined
Sun Jul 19, 2009 10:18 am

Post by Daniel » Wed Aug 05, 2009 7:13 am

you would only need to change about 4 files to upgrade.

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by orionweb » Wed Aug 05, 2009 7:39 am

That's cool then, so long as I know which ones :P

Image
Image


New member

Posts

Joined
Sun Jul 19, 2009 10:18 am
Who is online

Users browsing this forum: No registered users and 12 guests