Does any one think we should do this change?

I was thinking of changing the code so that opencart is not using the controller to register all the template variables and using them directly in the template.

for example:

$this->data['entry_store'] = $this->language->get('entry_store');

<td width="25%"><span class="required">*</span> <?php echo $entry_store; ?></td>

would become:

<td width="25%"><span class="required">*</span> <?php echo $this->language->get('entry_store'); ?></td>


what do you think?

it would save a lot of code time.

Hi Daniel,

We did exactly this with a site a while ago as delivery time was tight and therefore required a number of short cuts to hit the deadline. What a mistake that was especially when calculations are required it made the site a real mess and in the end we had to re-write large chunks of it to make it manageable.

The problems we encountered were simply not knowing where variables were declared and in some cases calculations were applied twice to variables etc...

This is our experience of trying to shortcut the MVC solution and we paid big time for it later with things that we could not have foreseen as customer requirements.

Phil.

I guess it could be done both ways. Seems kinda silly just to go back and remove all the existing entries. Technically the way it is done is correct. As long as its made known that users can do it both ways when adding things like fields then I'd just leave it. Plus it kinda separates the official variables and ones that users modded in some ways

I guess it could be done both ways. Seems kinda silly just to go back and remove all the existing entries. Technically the way it is done is correct. As long as its made known that users can do it both ways when adding things like fields then I'd just leave it. Plus it kinda separates the official variables and ones that users modded in some ways

ok i will leave it like it is. glad we had this disscusion.