[MOD] - VirtualQMod "vQmod" Virtual File Modification System

drivenbyweb wrote:My log file has a bunch of lines in it that say ---DELAYED WRITE---. Searched google and the forum but can seem to find what it means. Does anyone know?

Qphoria wrote:

madimar wrote:

Qphoria wrote:Yes it is true, inline after/before would be good. But it can be done in a pseudo-way like I showed above.. by using replace and finding the line and replacing the same line with code after it. Since if that line changed anyway, it wouldn't match anyway so the same effect still happens.

I'm not sure I understood correctly. If you replace the line, you will have a different code in your file.
Adding directly in the file those str_replace operations (as in my example), mantains the original line unchanged in the file.
If all the other mods work in the same way, I think the conflict risk is minor even if not completely avoided.

Well no.. Think about it
You have to search "abc123"
and replace with "abc123-XYZ"

You are replacing the exact same code with the original code plus your new code.
And you are actually bound to rule since your search would have to match in the first place
So another script could use that same search tag without breaking anything

So If you had search "abc123"
and inline-after "-XYZ"
still resulting in "abc123-XYZ"
You'd still end up with all the same pieces of the puzzle
And another script could still search on the tag the same way.

It is 6 vs half-dozen.

$sql = "abc123-XYZ";

$sql = "abc123-ABCD-XYZ";

$sql = "abc123-ABCD-XYZ";

$sql = "abc123-XYZ";

$sql = "abc123-XYZ";
$sql = str-replace('123','123-ABCD' ,$sql);

$sql = "abc123-XYZ";
$sql = str-replace('123','123-ABCD' ,$sql);

$sql = "abc123-XYZ-9999";
$sql = str-replace('123','123-ABCD' ,$sql);

JAY6390 wrote:Personally I try to have as little effect on the original code as I possibly can but sometimes it's inevitable that you are going to make changes that have the potential to screw up another mod/a mod will screw up your matches
In these situations, you just have to leave it be. You can't be held responsible for your mod not working with every other mod out there (take PC applications for example, they conflict on occasion - it just happens)

Qphoria wrote:I think I see what you mean madimar,
But I think what Jay says kinda negates it...

It looks like your example is 2 mods that want to edit the same exact line in the same exact way, yeilding different results. But then the mods will have logical conflicts anyway.

if mod 1 says:
search: blue
replace: red

and mod 2 says
search: blue
replace: green

even if you tried some passive
str_replace(blue, red, $line)
str_replace(blue, gree, $line)

The end result is that those 2 mods do diff things to the same line are not compatible anyway.

<operation>
            <search position="after"><![CDATA[
      $sql = "SELECT o.order_id, CONCAT(o.firstname, ' ', o.lastname) AS customer, (SELECT os.name FROM " . DB_PREFIX . "order_status os WHERE os.order_status_id = o.order_status_id AND os.language_id = '" . (int)$this->config->get('config_language_id') . "') AS status, o.total, o.currency_code, o.currency_value, o.date_added, o.date_modified FROM `" . DB_PREFIX . "order` o";
         ]]></search>
            <add><![CDATA[
      // madimar mod   
      $sql = str_replace (' FROM `', ', sr.name AS sales_rep FROM `', $sql);
      // madimar mod end      
         ]]></add>
        </operation>

<operation>
            <search position="after"><![CDATA[
      $sql = "SELECT o.order_id, CONCAT(o.firstname, ' ', o.lastname) AS customer, (SELECT os.name FROM " . DB_PREFIX . "order_status os WHERE os.order_status_id = o.order_status_id AND os.language_id = '" . (int)$this->config->get('config_language_id') . "') AS status, o.total, o.currency_code, o.currency_value, o.date_added, o.date_modified FROM `" . DB_PREFIX . "order` o";
         ]]></search>
            <add><![CDATA[
      // madimar mod   
      $sql = str_replace (' FROM `', ', newfield AS newfield FROM `', $sql);
      // madimar mod end      
         ]]></add>
        </operation>

Qphoria wrote:

drivenbyweb wrote:My log file has a bunch of lines in it that say ---DELAYED WRITE---. Searched google and the forum but can seem to find what it means. Does anyone know?

That was a feature I added to avoid write locking. It means the vqcache file couldn't be written to in a timely manner and took up to 1 sec to be written. It typically means your host is slow. But does it still work?

Qphoria wrote:Yea the installer doesn't check file permission on the index.php file. Jay. fix it!

JAY6390 wrote:I'd rather not use expletives to reply to that comment, so I'll simply say "do one, guvna"