1.5.0.5 very slow

DirkZz wrote:The product count is ok, but the menu doesn't add an extra sub item.
I didn't understand you at first, thanks for pointing me to this problem, ill see if I can think of something otherwise, too bad

EDIT:
Oc doesnt see the level-3 category as a subcategory of the level-2. Thats the problem.

DirkZz wrote: Currenctly working on it .. ill show you what i ment.. almost done.. prob after the weekend.

Xsecrets wrote:yeah I'm 99.999% sure it cannot be done with group by alone. You will have to have some sort of looping or something. I just don't believe it's possible to get it in one query.

Xsecrets wrote:Ok I've changed the way I approached it all. Here's a new vqmod. It basically does the same thing as the default install, but it rolls it all into the category model function and enables caching, so if someone wants to give this one a try I would love to hear if it helps. This one should not mess with the display at all.

Moggin wrote:What's this
http://www.opencart.com/index.php?route ... me=danvaly

in extensions?

Xsecrets wrote:

m3scott wrote:Good call on the categories, Xsecrets.
Disabling categories on the homepage resulted in this....

Domain name Size Load Time Average Speed per KB
1 dev2.aspencreekoutdoors.com 10.9 KB 0.29 seconds 0.03 seconds

Similar results for product view...

Categories enabled
Domain name Size Load Time Average Speed per KB
1 dev2.aspencreekoutdoors.com/index.php?route=product/product&product_id=3795 83.18 KB 20.53 seconds 0.25 seconds

Categories disabled
Domain name Size Load Time Average Speed per KB
1 dev2.aspencreekoutdoors.com/index.php?route=product/product&product_id=3795 15.34 KB 1.85 seconds 0.12 seconds

ok well you or someone has obviously already modified your category module to remove the category counts.
edit catalog/controller/module/category.php and look for code something like this (you've probably already changed it a bit)

Code: Select all

        foreach ($categories as $category) {
            $children_data = array();
            
            $children = $this->model_catalog_category->getCategories($category['category_id']);
            
            foreach ($children as $child) {
                $data = array(
                    'filter_category_id'  => $child['category_id'],
                    'filter_sub_category' => true
                );        
                    
                $product_total = $this->model_catalog_product->getTotalProducts($data);
                            
                $children_data[] = array(
                    'category_id' => $child['category_id'],
                    'name'        => $child['name'] . ' (' . $product_total . ')',
                    'href'        => $this->url->link('product/category', 'path=' . $category['category_id'] . '_' . $child['category_id'])    
                );                    
            }
            
            $data = array(
                'filter_category_id'  => $category['category_id'],
                'filter_sub_category' => true    
            );        
                
            $product_total = $this->model_catalog_product->getTotalProducts($data);
                        
            $this->data['categories'][] = array(
                'category_id' => $category['category_id'],
                'name'        => $category['name'] . ' (' . $product_total . ')',
                'children'    => $children_data,
                'href'        => $this->url->link('product/category', 'path=' . $category['category_id'])
            );
        }

 

Change it to look like this

Code: Select all

        foreach ($categories as $category) {
            $children_data = array();
            
            $children = $this->model_catalog_category->getCategories($category['category_id']);
            
            foreach ($children as $child) {
                $data = array(
                    'filter_category_id'  => $child['category_id'],
                    'filter_sub_category' => true
                );        
                    
                //$product_total = $this->model_catalog_product->getTotalProducts($data);
                            
                $children_data[] = array(
                    'category_id' => $child['category_id'],
                    'name'        => $child['name'],
                    'href'        => $this->url->link('product/category', 'path=' . $category['category_id'] . '_' . $child['category_id'])    
                );                    
            }
            
            $data = array(
                'filter_category_id'  => $category['category_id'],
                'filter_sub_category' => true    
            );        
                
            //$product_total = $this->model_catalog_product->getTotalProducts($data);
                        
            $this->data['categories'][] = array(
                'category_id' => $category['category_id'],
                'name'        => $category['name'],
                'children'    => $children_data,
                'href'        => $this->url->link('product/category', 'path=' . $category['category_id'])
            );
        }

 

the total next to the name is probably already removed, but make sure that you comment out the product total lines and see if that makes a difference in speed with the category module turned on.

dony_b wrote:This works fine on v 1.5.05 but I tried it on v1.5.1 and it doesn't work. Whats the difference from last version so I can apply it ? Thanks

dony_b wrote:

Xsecrets wrote:

m3scott wrote:Good call on the categories, Xsecrets.
Disabling categories on the homepage resulted in this....

Domain name Size Load Time Average Speed per KB
1 dev2.aspencreekoutdoors.com 10.9 KB 0.29 seconds 0.03 seconds

Similar results for product view...

Categories enabled
Domain name Size Load Time Average Speed per KB
1 dev2.aspencreekoutdoors.com/index.php?route=product/product&product_id=3795 83.18 KB 20.53 seconds 0.25 seconds

Categories disabled
Domain name Size Load Time Average Speed per KB
1 dev2.aspencreekoutdoors.com/index.php?route=product/product&product_id=3795 15.34 KB 1.85 seconds 0.12 seconds

ok well you or someone has obviously already modified your category module to remove the category counts.
edit catalog/controller/module/category.php and look for code something like this (you've probably already changed it a bit)

Code: Select all

        foreach ($categories as $category) {
            $children_data = array();
            
            $children = $this->model_catalog_category->getCategories($category['category_id']);
            
            foreach ($children as $child) {
                $data = array(
                    'filter_category_id'  => $child['category_id'],
                    'filter_sub_category' => true
                );        
                    
                $product_total = $this->model_catalog_product->getTotalProducts($data);
                            
                $children_data[] = array(
                    'category_id' => $child['category_id'],
                    'name'        => $child['name'] . ' (' . $product_total . ')',
                    'href'        => $this->url->link('product/category', 'path=' . $category['category_id'] . '_' . $child['category_id'])    
                );                    
            }
            
            $data = array(
                'filter_category_id'  => $category['category_id'],
                'filter_sub_category' => true    
            );        
                
            $product_total = $this->model_catalog_product->getTotalProducts($data);
                        
            $this->data['categories'][] = array(
                'category_id' => $category['category_id'],
                'name'        => $category['name'] . ' (' . $product_total . ')',
                'children'    => $children_data,
                'href'        => $this->url->link('product/category', 'path=' . $category['category_id'])
            );
        }

 

Change it to look like this

Code: Select all

        foreach ($categories as $category) {
            $children_data = array();
            
            $children = $this->model_catalog_category->getCategories($category['category_id']);
            
            foreach ($children as $child) {
                $data = array(
                    'filter_category_id'  => $child['category_id'],
                    'filter_sub_category' => true
                );        
                    
                //$product_total = $this->model_catalog_product->getTotalProducts($data);
                            
                $children_data[] = array(
                    'category_id' => $child['category_id'],
                    'name'        => $child['name'],
                    'href'        => $this->url->link('product/category', 'path=' . $category['category_id'] . '_' . $child['category_id'])    
                );                    
            }
            
            $data = array(
                'filter_category_id'  => $category['category_id'],
                'filter_sub_category' => true    
            );        
                
            //$product_total = $this->model_catalog_product->getTotalProducts($data);
                        
            $this->data['categories'][] = array(
                'category_id' => $category['category_id'],
                'name'        => $category['name'],
                'children'    => $children_data,
                'href'        => $this->url->link('product/category', 'path=' . $category['category_id'])
            );
        }

 

the total next to the name is probably already removed, but make sure that you comment out the product total lines and see if that makes a difference in speed with the category module turned on.

This works fine on v 1.5.05 but I tried it on v1.5.1 and it doesn't work. Whats the difference from last version so I can apply it ? Thanks