[1.4.9.1]Does not accept any email that contains Dash

dantheman50_98 wrote: Also, if we've already installed opencart how are we supposed to get the new code into the install/controller/step_3.php file?

Qphoria wrote:I've searched around for the holy grail of email regex.. still not found one.
But I was a step ahead with the one place pattern. The day I made this fix I checked in a change to define the pattern once and use that constant. That will be in effect for 1.5.0

Shark wrote:

Qphoria wrote:I've searched around for the holy grail of email regex.. still not found one.
But I was a step ahead with the one place pattern. The day I made this fix I checked in a change to define the pattern once and use that constant. That will be in effect for 1.5.0

I noticed this bug before; I changed the code using:
if (!filter_var(filter_var($this->request->post['email'], FILTER_SANITIZE_EMAIL), FILTER_VALIDATE_EMAIL)) {
$this->error['email'] = $this->language->get('error_email');
}

See also: http://www.charles-reace.com/blog/2008/ ... ate_email/

Or is the change you made to the regex better? (I'm not an professional php-coder). thx.

Qphoria wrote:Confirmed.

1. EDIT the following files:
catalog/controller/account/create.php
catalog/controller/account/edit.php
catalog/controller/checkout/guest_step_1.php
catalog/controller/information/contact.php
catalog/model/checkout/order.php
admin/controller/sale/customer.php
admin/controller/sale/order.php
admin/controller/setting/setting.php
install/controller/step_3.php

2. FIND:

Code: Select all

$pattern = '/^[A-Z0-9._%-+]+@[A-Z0-9][A-Z0-9.-]{0,61}[A-Z0-9]\.[A-Z]{2,6}$/i';

3. REPLACE WITH:

Code: Select all

$pattern = '/^[A-Z0-9._%\-+]+@[A-Z0-9][A-Z0-9.-]{0,61}[A-Z0-9]\.[A-Z]{2,6}$/i';

$pattern = '/^[A-Z0-9._%+-]+@[A-Z0-9][A-Z0-9.-]{0,61}[A-Z0-9]\.[A-Z]{2,6}$/i';