OK "Q" I checked out your site from home and yes it seems to work and guess what mine does too but..........
Check this out:
Please select the preferred shipping method to use on this order.
United States Postal Service (Weight: 0.50oz)
First-Class Mail $2.41
Flat Rate
Flat Shipping Rate $12.00
as you can see from above first class does work the weight is .50oz and first class mail does appear but........
when I change this to anything above that lets say for example 8oz like you did in your example in the above post I get this instead of first class:
Shipping Method
Please select the preferred shipping method to use on this order.
United States Postal Service (Weight: 8.00oz)
Priority Mail $10.00
Priority Mail Large Flat Rate Box $14.95
Priority Mail Medium Flat Rate Box $10.95
Priority Mail Small Flat Rate Box $5.20
Priority Mail Flat Rate Envelope $4.95
Parcel Post $8.56
Media Mail $5.11
Flat Rate
Flat Shipping Rate $12.00
as you can see from above 8oz eliminates fist class but .50oz it appears with no problem
even (Weight: 1.00oz) does not give me first class mail option but if I change it to lets say .1 oz
I get the fist class option again as you can see from below:
lease select the preferred shipping method to use on this order.
United States Postal Service (Weight: 0.10oz)
First-Class Mail $1.39
Flat Rate
Flat Shipping Rate $12.00
I did the upgrade from 1.4.9.3 this may have something to do with it it may not.
I am not sure whats going on here at all.
Meanguns
On line 25 of upgrade.php,
Unless I'm mistaken, I believe the first part of that error message should actually read:
, it should read like this:
Marc
Code: Select all
$errors[] = 'The database could selected, check you have permissions, and check it exists on the server.';Plus, if we really want to nit-pikThe database could NOT BE selected...
, it should read like this:
Code: Select all
'The database could not be selected. Check that you have proper permissions, and that it exists on the server.'OpenCart v1.4.9.4
VQMod | Categories Home | Cleaner By Default - 2 Column | Speak Good English
Go to the admin site.
Go under sales-custemers.
Try to type in a custemer name (has to be in the database to be found of cause) - and press filter - the filtering makes different on small and capital letters - that's not god! It may find "Lars" but not "lars". Same goes for filtering email.
The filtering under sales-orders does NOT do the same - here it doesn't matter wheather small or capital letters is used!
Small, but irritating bug.
Regards
Lars
Go under sales-custemers.
Try to type in a custemer name (has to be in the database to be found of cause) - and press filter - the filtering makes different on small and capital letters - that's not god! It may find "Lars" but not "lars". Same goes for filtering email.
The filtering under sales-orders does NOT do the same - here it doesn't matter wheather small or capital letters is used!
Small, but irritating bug.
Regards
Lars
I'm pretty sure this was fixed a few versions ago. I just tried it on my demo site and I have 2 orders asdinmc wrote:Go to the admin site.
Go under sales-custemers.
Try to type in a custemer name (has to be in the database to be found of cause) - and press filter - the filtering makes different on small and capital letters - that's not god! It may find "Lars" but not "lars". Same goes for filtering email.
The filtering under sales-orders does NOT do the same - here it doesn't matter wheather small or capital letters is used!
Small, but irritating bug.
Regards
Lars
"Qphoria Qphoria"
but a filter of "qph" found both orders
However, there was a problem with the record count not doing the case filtering.. so it would show 0 of 0 for the total orders, so I fixed that... but the actual filtering works fine.
Hi,Qphoria wrote:There's a known issue with the search that if you have
5 products with "Apple" in the title and 2 products with "Apple" in the tag.. it will return 7 products but only show 1-5 out of 5. It's not a major issue, and all products still showup, just a limitation to the way the counting it done separately. It's been there since I added tags in 1.4.7 and noone has really noticed it until now so it's a pretty well tucked issueBut yea it's something to deal with eventually
Just checking on this issue. Has anyone come up with a fix?
Thank you!
You guys are going about email address validation all wrong.
You have a define( EMAIL_PATTERN, '...' ) that you're using in most places, however, in the admin controllers, you decided to make yet another bad regular expression. Not only does this expression still not validate emails correctly, it has a bad bug in it that doesn't allow dashes in email addresses.
$pattern = '/^[A-Z0-9._%-+]+@[A-Z0-9][A-Z0-9.-]{0,61}[A-Z0-9]\.[A-Z]{2,6}$/i';
Notice in your first character class that you have %-+, this should be written %+- or %\-+. A - within a character class denotes a range unless escaped, or placed at the beginning or end of a character class.
To recap:
BAD:
if ((strlen(utf8_decode($this->request->post['email'])) > 96) || (!preg_match( any_expression_here , $this->request->post['email']))) {
GOOD:
if ( !filter_var( $this->request->post['email'], FILTER_VALIDATE_EMAIL) ) { ... }
You have a define( EMAIL_PATTERN, '...' ) that you're using in most places, however, in the admin controllers, you decided to make yet another bad regular expression. Not only does this expression still not validate emails correctly, it has a bad bug in it that doesn't allow dashes in email addresses.
$pattern = '/^[A-Z0-9._%-+]+@[A-Z0-9][A-Z0-9.-]{0,61}[A-Z0-9]\.[A-Z]{2,6}$/i';
Notice in your first character class that you have %-+, this should be written %+- or %\-+. A - within a character class denotes a range unless escaped, or placed at the beginning or end of a character class.
To recap:
BAD:
if ((strlen(utf8_decode($this->request->post['email'])) > 96) || (!preg_match( any_expression_here , $this->request->post['email']))) {
GOOD:
if ( !filter_var( $this->request->post['email'], FILTER_VALIDATE_EMAIL) ) { ... }
That's old and already fixed. Now the pattern is simply *@*.*genio wrote:$pattern = '/^[A-Z0-9._%-+]+@[A-Z0-9][A-Z0-9.-]{0,61}[A-Z0-9]\.[A-Z]{2,6}$/i';
Yes we could use the filter_var option too and probably should at some point but i'm not too worried about it
Same on my site. If I search "Alan" it display different results to if I search "alan"dinmc wrote:Hmmm. Strange. Here it does not work.
I have a custemer with name Lars Ebdrup.
If I filter "Lars" - Lars Ebdup is found
If I filter "lars" - nothing is found
Filtering email's does not work at all!!
Regards
Lars
What version is that fixed in? I just downloaded your latest release and it's still in there.Qphoria wrote:That's old and already fixed. Now the pattern is simply *@*.*genio wrote:$pattern = '/^[A-Z0-9._%-+]+@[A-Z0-9][A-Z0-9.-]{0,61}[A-Z0-9]\.[A-Z]{2,6}$/i';
Yes we could use the filter_var option too and probably should at some point but i'm not too worried about it
I've checked the code and it looks correct. This was a fix for 1.4.9.4 and is in the full download and the patch only release.
The diff shows it as well:
http://code.google.com/p/opencart/sourc ... hp&old=142
Are you sure you are not running a mod that replaces the admin/model/sale/order.php file?
Edit that file and verify you have this line. If you don't have it, then you must not have uploaded all the files:
The diff shows it as well:
http://code.google.com/p/opencart/sourc ... hp&old=142
Are you sure you are not running a mod that replaces the admin/model/sale/order.php file?
Edit that file and verify you have this line. If you don't have it, then you must not have uploaded all the files:
Code: Select all
$sql .= " AND LCASE(CONCAT(o.firstname, ' ', o.lastname)) LIKE '%" . $this->db->escape(strtolower($data['filter_name'])) . "%'";
Q, I have found the problem.
I had EditOrdersManually149v4 installed. Although it did not edit the order.php file it added editorder.php to admin/model/sale/
I deleted that file and the search is no longer case sensitive.
dinmc, do you have that mod installed also ?
I had EditOrdersManually149v4 installed. Although it did not edit the order.php file it added editorder.php to admin/model/sale/
I deleted that file and the search is no longer case sensitive.
dinmc, do you have that mod installed also ?
I had the same problem too Bluelayer. Since I removed the editorder.php I can add products to the order and remove them without errors.
Before I would add an item to the order and it would throw up an error but if you refreshed the page the item would be in there. Same with removing a product.
I do not have this error anymore
EDIT **Ignore above... still does it (http://blah.com says Failed) when I try to add a product to an existing order.
Before I would add an item to the order and it would throw up an error but if you refreshed the page the item would be in there. Same with removing a product.
I do not have this error anymore
EDIT **Ignore above... still does it (http://blah.com says Failed) when I try to add a product to an existing order.
I got excactly the same error. It's on a brand new and "clean" 1.4.9.4 install.Simple wrote:I had the same problem too Bluelayer. Since I removed the editorder.php I can add products to the order and remove them without errors.
Before I would add an item to the order and it would throw up an error but if you refreshed the page the item would be in there. Same with removing a product.
I do not have this error anymore
EDIT **Ignore above... still does it (http://blah.com says Failed) when I try to add a product to an existing order.
Hmmm!
I have upgraded to 1.4.9.4 from a previous install of 1.4.9.3, this is the first time that I've gotten round to testing the store (working up to launch day) and I'm having issues with the shipping. I have not installed the USPS patch as I don't believe it's relevant (I'm not using USPS) and I have installed the latest update to Paypal Standard. I have the "tag cloud" extension installed but I don't think it modifies any of the core files.
I have set size (in mm) and weight (in grams) for all items, I have set the site up wherever I have seen the option with size in mm and weight in grams.
I have Royal Mail as the only shipping option installed, set up as I assume it should be, with both second class standard and airmail selected (now tested with all options selected).
I add one product to my basket and checkout, using the same address as the store is in (and also tested with fake address in york with york post code and west yorkshire selected) and it says "Error: No Shipping options are available. Please contact us for assistance!" on the Delivery Information page and won't go past this.
Any idea as to what I'm doing wrong or if this is a bug?
I have set size (in mm) and weight (in grams) for all items, I have set the site up wherever I have seen the option with size in mm and weight in grams.
I have Royal Mail as the only shipping option installed, set up as I assume it should be, with both second class standard and airmail selected (now tested with all options selected).
I add one product to my basket and checkout, using the same address as the store is in (and also tested with fake address in york with york post code and west yorkshire selected) and it says "Error: No Shipping options are available. Please contact us for assistance!" on the Delivery Information page and won't go past this.
Any idea as to what I'm doing wrong or if this is a bug?
Specialist Hobby Games for sale online
Have you set up a Geo Zone that includes all of the places in the UK [and elsewhere?] that you are willing to ship to via Royal Mail? Is that zone (or "All Zones") selected as being applicable for Royal Mail?
Please use proper English at all times, so that all members may understand you.
Who is online
Users browsing this forum: No registered users and 5 guests
