Post by hundefor » Wed Feb 23, 2011 5:27 pm

I have a web service - http://www.dogclub.no - running Opencart 1.4.9.3. It is in Norwegian, and the only additional language kept in the system is English. The latter has been switched off, both backend and frontend. Now the weird issue is that in Internet Explorer 8 the frontend displays in English on my own computer which is holding English OS (Vista). At the backend it displays correctly. Both Chrome and Firefox displays the service correctly in Norwegian.
Do note that the language selector is also gone in IE, whereas it displays in Chrome and Firefox.
Having spoken to people in Norway who use IE8 and tested myself on two local computers with Norwegian OS and Norwegian keyboard, all display the language correctly, including the language selector. Also another laptop with English OS and Swisss keyboard displays the language correctly.
Having looked at the generated source I notice that on my computer the HTML tag is displayed as follows:
<html lang="en" dir="ltr" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">. On those that do display correctly it shows as <html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="no" xml:lang="no">.
Presumably the source code is generated by Opencart without any interruption from IE8, or am I wrong? Is it a IE8 issue or an Opencart issue?

Stig

Newbie

Posts

Joined
Sat Dec 18, 2010 12:45 am

Post by i2Paq » Thu Feb 24, 2011 12:52 am

hundefor wrote:I have a web service - http://www.dogclub.no - running Opencart 1.4.9.3. It is in Norwegian, and the only additional language kept in the system is English. The latter has been switched off, both backend and frontend. Now the weird issue is that in Internet Explorer 8 the frontend displays in English on my own computer which is holding English OS (Vista). At the backend it displays correctly. Both Chrome and Firefox displays the service correctly in Norwegian.
Do note that the language selector is also gone in IE, whereas it displays in Chrome and Firefox.
Having spoken to people in Norway who use IE8 and tested myself on two local computers with Norwegian OS and Norwegian keyboard, all display the language correctly, including the language selector. Also another laptop with English OS and Swisss keyboard displays the language correctly.
Having looked at the generated source I notice that on my computer the HTML tag is displayed as follows:
<html lang="en" dir="ltr" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">. On those that do display correctly it shows as <html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="no" xml:lang="no">.
Presumably the source code is generated by Opencart without any interruption from IE8, or am I wrong? Is it a IE8 issue or an Opencart issue?

Stig
I have noticed the same behavior, even with English disabled it would still show my store-front in English using an English browser/os.
I'm running 1.4.9.1 updated to 1.4.9.2 but I have seen this in older versions to.

I mentioned it in several other BUG topics but it looks like I (we) are the only one having this issue.

I completely removed the English language (kept the files in place) just to prevent confusing my customers.

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Thu Feb 24, 2011 1:07 am

not sure I understand the issue exactly...

OpenCart (like most carts) does have a browser detect function that tries to detect the customer's browser locale and uses that to force the language

So if you have a site with English and German supported
- if you visit your site from a browser where english is the default language, it will load english, if enabled
- if you visit your site from a browser where german is the default language, it will load german, if enabled

If not enabled, the autodetect will use the default language set in the admin.

Or, if a cookie already exists for another language, or if the &currency=en url parameter was passed in, then that will override the autodetect

As far as IE not showing the dropdown but chrome and ff are showing it.. that may just be a browser cache thing or something. PHP code parsing is not browser dependent

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Thu Feb 24, 2011 1:29 am

Qphoria wrote:not sure I understand the issue exactly...
2 languages, Dutch and English.

Dutch = enabled.
English = disabled.

When browsing to my store with an English browser/os it will show my store in..... English, when it is supposed to only show Dutch.

Only solution: completely remove the English language (not the files).

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Thu Feb 24, 2011 2:09 am

actually you are right.. none of the language code verifies that the language is enabled. good find.. this has been like this from day 1

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Thu Feb 24, 2011 5:59 am

Qphoria wrote:actually you are right.. none of the language code verifies that the language is enabled. good find.. this has been like this from day 1
The funny thing is that I mentioned this a few times before, no-one ever care to reply to that :'(

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by alexmitev » Fri Feb 25, 2011 6:34 pm

I see OC 1.4.9.3 creates a new order with order_statys_id=0 every time the checkout/confirm.php loads

Code: Select all

$this->session->data['order_id'] = $this->model_checkout_order->create($data);
I understand this data is needed for the payment modules (probably not a good idea to have it in the session?), but this bloats the DB with new orders every time the confirm page is refreshed (or some order details are changed, like address, shipping, etc.).
So, maybe we can have some code like:

Code: Select all

if (isset($this->session->data['order_id']))
  $this->model_checkout_order->delete($this->session->data['order_id']);
or even better:

Code: Select all

if (isset($this->session->data['order_id']))
  $this->model_checkout_order->update($data);
else
  $this->model_checkout_order->create($data);

to avoid creating new IDs.

New member

Posts

Joined
Wed Jan 19, 2011 10:38 pm

Post by Qphoria » Fri Feb 25, 2011 9:05 pm

i2Paq wrote:
Qphoria wrote:actually you are right.. none of the language code verifies that the language is enabled. good find.. this has been like this from day 1
The funny thing is that I mentioned this a few times before, no-one ever care to reply to that :'(
Well we just like to test you :)

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Qphoria » Fri Feb 25, 2011 9:07 pm

alexmitev wrote:I see OC 1.4.9.3 creates a new order with order_statys_id=0 every time the checkout/confirm.php loads
Try this mod:
http://forum.opencart.com/viewtopic.php?t=9192&f=23

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by pingpong » Mon Feb 28, 2011 12:28 am

Hey guys, I know this is the bugs thread, but was just wondering, whether these bugs have been updated in the patch from 1.4.9.2 to 1.4.9.3 download file, or would i need to apply the bug patches manually from the above threads?

Many thanks

http://www.mydesignercard.co.uk


New member

Posts

Joined
Sat Nov 14, 2009 5:59 pm
Location - UK

Post by Qphoria » Mon Feb 28, 2011 12:57 am

pingpong wrote:Hey guys, I know this is the bugs thread, but was just wondering, whether these bugs have been updated in the patch from 1.4.9.2 to 1.4.9.3 download file, or would i need to apply the bug patches manually from the above threads?

Many thanks
Like all code projects across the world, bugs found in an existing version number are not fixed until the next version number. All these will be fixed in 1.4.9.4

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by soyo » Thu Mar 03, 2011 4:00 am

Hope I'm submitting this right.

1.4.9.3 multi-store setup, default theme, only add-on is global mega options.

Tried searching but haven't found a reference to this...

Have a few stores set up... and 8 manufacturers.

Problem is...Let's say I have 14 products linked to manufacturer "Nike".

7 of them are showing in Store A.

4 of them are showing in Store B.

5 of them are showing in Store C.

Not that it matters, but of course some are shared (i.e. same item on more than one store).

No matter what, if I click the Manufacturer Nike in the left dropdown in any of the stores, it will say:

"Showing 1 to 14 of 14 (2 pages)"

But then, will only show the 7 or 4 or 5 items in that store. It seems like it's calculating the total from the total number of items assigned to the manufacturers, and not basing that total on the individual store.

Same case of course for other manufacturers.

Very confusing looking... especially since it will even show the second page, with nothing on it...

???

I'm hoping someone can verify this behavior? or if I missed a previous reference to this, please point me there...

1.4.9.3 / global mega options

Thanks

1.4.9.4


New member

Posts

Joined
Wed Dec 29, 2010 12:45 am

Post by soyo » Fri Mar 04, 2011 12:52 am

Another thing I am noticing...

1.4.9.3, default theme, only add-on is Global Mega Options.

If I am in one of the Multi-Stores, and perform a search from the top search box, it takes me from the store I'm in to the default store. Products change, etc.

***** UPDATE: After testing, I found that this occurs when I have a Manufacturer selected in the left box! If I choose -please select- (to de-select the brand), then the search functions normally and stays within the store. The 'advanced search' seems to work because it appears to clear the Manufacturer selection automatically. *****

If someone running Multi-Store could confirm this behavior I would appreciate it.

1.4.9.4


New member

Posts

Joined
Wed Dec 29, 2010 12:45 am

Post by Xsecrets » Tue Mar 08, 2011 4:28 am

Multi-store in admin has a bug. If you do not upload a logo and icon when you create the new store then you cannot upload on upon edit when using firefox, because no image is displayed and you have to click on the image to trigger the file manager to appear.

OpenCart commercial mods and development http://spotonsolutions.net
Layered Navigation
Shipment Tracking
Vehicle Year/Make/Model Filter


Guru Member

Posts

Joined
Sun Oct 25, 2009 3:51 am
Location - FL US

Post by Qphoria » Tue Mar 08, 2011 5:04 am

Xsecrets wrote:Multi-store in admin has a bug. If you do not upload a logo and icon when you create the new store then you cannot upload on upon edit when using firefox, because no image is displayed and you have to click on the image to trigger the file manager to appear.
I liked it better when there was that little button next to the image to click on myself. Daniel thought it would be better to just click the image back in 1.4.6 and that is when this started. This was an issue with normal store too.. I added "..." to the image back in 1.4.9 to always give you something to click on but probably forgot the multistore since I'd never use it :)

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by tech.cnsb » Wed Mar 09, 2011 6:24 pm

SEO Friendly Enable Quick Search Bug.

After I enable SEO Friendly URL, the quick search not working in some of the page.
It require 2 conditions to make this bug happen.
e.g
http://localhost/oc/apple
If you are in this page, you are using quick search at the top with "book" keyword, then after you click search, it will display correct layout.
However.
if you url is
1. http://oc/
then you go to one of brand SEO friendly URL
http://oc/apple , then you are using quick search at the top with "book" keyword, then after you click search, it will redirect to http://oc/index.php/index.php?route=pro ... egory_id=0
as you can see the url index.php/index.php? , it is duplicated.


Solution:-
I not sure this is the best, but it definitely solve my problem, I not sure this will affect other or not.
\oc\catalog\view\theme\default\template\common\header.tpl

line: 208

Code: Select all

function moduleSearch() {	
	pathArray = location.pathname.split( '/' );
	
	url = location.protocol + "//" + location.host + "/" + pathArray[1] + '/';
		
	url += 'index.php?route=product/search';

replace to

Code: Select all

function moduleSearch() {	

	url = '<?php echo HTTP_SERVER?>';
	
	url += 'index.php?route=product/search';

Hope this will help.

Newbie

Posts

Joined
Wed Jan 12, 2011 11:44 am

Post by Qphoria » Wed Mar 09, 2011 11:32 pm

tech.cnsb wrote:SEO Friendly Enable Quick Search Bug.

After I enable SEO Friendly URL, the quick search not working in some of the page.
It require 2 conditions to make this bug happen.
e.g
http://localhost/oc/apple
If you are in this page, you are using quick search at the top with "book" keyword, then after you click search, it will display correct layout.
However.
if you url is
1. http://oc/
then you go to one of brand SEO friendly URL
http://oc/apple , then you are using quick search at the top with "book" keyword, then after you click search, it will redirect to http://oc/index.php/index.php?route=pro ... egory_id=0
as you can see the url index.php/index.php? , it is duplicated.


Solution:-
I not sure this is the best, but it definitely solve my problem, I not sure this will affect other or not.
\oc\catalog\view\theme\default\template\common\header.tpl

line: 208

Code: Select all

function moduleSearch() {	
	pathArray = location.pathname.split( '/' );
	
	url = location.protocol + "//" + location.host + "/" + pathArray[1] + '/';
		
	url += 'index.php?route=product/search';

replace to

Code: Select all

function moduleSearch() {	

	url = '<?php echo HTTP_SERVER?>';
	
	url += 'index.php?route=product/search';

Hope this will help.
Thanks, but you could have just looked at the 3rd post in the thread which has this fix already:
http://forum.opencart.com/viewtopic.php ... 68#p120725

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by tech.cnsb » Thu Mar 10, 2011 8:35 am

Qphoria wrote:
tech.cnsb wrote:SEO Friendly Enable Quick Search Bug.

After I enable SEO Friendly URL, the quick search not working in some of the page.
It require 2 conditions to make this bug happen.
e.g
http://localhost/oc/apple
If you are in this page, you are using quick search at the top with "book" keyword, then after you click search, it will display correct layout.
However.
if you url is
1. http://oc/
then you go to one of brand SEO friendly URL
http://oc/apple , then you are using quick search at the top with "book" keyword, then after you click search, it will redirect to http://oc/index.php/index.php?route=pro ... egory_id=0
as you can see the url index.php/index.php? , it is duplicated.


Solution:-
I not sure this is the best, but it definitely solve my problem, I not sure this will affect other or not.
\oc\catalog\view\theme\default\template\common\header.tpl

line: 208

Code: Select all

function moduleSearch() {	
	pathArray = location.pathname.split( '/' );
	
	url = location.protocol + "//" + location.host + "/" + pathArray[1] + '/';
		
	url += 'index.php?route=product/search';

replace to

Code: Select all

function moduleSearch() {	

	url = '<?php echo HTTP_SERVER?>';
	
	url += 'index.php?route=product/search';

Hope this will help.
Thanks, but you could have just looked at the 3rd post in the thread which has this fix already:
http://forum.opencart.com/viewtopic.php ... 68#p120725
alright, I use search feature didn't notice it had been fix. I found it not only happen in IE only, for other browser FF, Chrome also having this.
Will this bug fixed included in next patch?

Newbie

Posts

Joined
Wed Jan 12, 2011 11:44 am

Post by Narazum0no » Fri Mar 11, 2011 8:57 pm

USPS Shipping prices being converted twice from dollars to pounds.

First thank all of you developers for creating and maintaining this great software!

I've read this entire thread and searched the forums but haven't seen anything like this listed.
I installed Opencart 1.4.9.3 from scratch and this is happening in the default USPS extension.

A customer from England ordered an item to be shipped by USPS International Small Flat Rate Box.
The item costs $18.00 and they were charged £11.00, so the currency conversion was correct. But for shipping they were only charged £5.40~ A small international flat rate box is $13.95~ so they should have been charged £8.70. Convert that again with the same exchange rate and you get £5.40.

I tested and found that this was happening for all my international orders when a customer chooses pounds as their currency in the front of the store.

Removing $this->currency->convert($cost, 'USD', $this->currency->getCode()) from lines 338, 341, 371, and 373 in /catalog/model/shipping/usps.php fixed the problem perfectly for me and so far hasn't seemed to have any adverse side effects.

I changed:

Code: Select all

$quote_data[$id] = array(
										'id'           => 'usps.' . $id,
										'title'        => $title,
										'cost'         => $this->currency->convert($cost, 'USD', $this->currency->getCode()),
										'tax_class_id' => $this->config->get('usps_tax_class_id'),
										'text'         => $this->currency->format($this->tax->calculate($this->currency->convert($cost, 'USD', $this->currency->getCode()), $this->config->get('usps_tax_class_id'), $this->config->get('config_tax')))
									);	
to:

Code: Select all

									$quote_data[$id] = array(
										'id'           => 'usps.' . $id,
										'title'        => $title,
										'cost'         => $cost,
										'tax_class_id' => $this->config->get('Jusps_tax_class_id'),
										'text'         => $this->currency->format($this->tax->calculate($cost, $this->config->get('Jusps_tax_class_id'), $this->config->get('config_tax'))),
										'count'			=> 1,
									);
									 
I don't know where the shipping rates are being converted, code wise, but everything works perfectly for me now with my set up. All shipping prices are calculated correctly no matter what items and destinations I test it with. It even seems to work when I change my default currency to pounds.

Still it seems like people other than me would have had this issue. And I am not familiar enough with how opencart works overall to be sure if this is really an ok fix or not.

User avatar
Newbie

Posts

Joined
Fri Mar 11, 2011 7:29 pm

Post by Johnathan » Fri Mar 11, 2011 11:11 pm

Here is (I think) a new one: since the price column was added recently, the colspan is off in /admin/view/template/catalog/product_list.tpl when there are no products. Replace:

Code: Select all

colspan="7"
with:

Code: Select all

colspan="8"

Image Image Image Image Image


User avatar
Administrator

Posts

Joined
Fri Dec 18, 2009 3:08 am

Who is online

Users browsing this forum: No registered users and 11 guests