OpenCart Community

qahar wrote:I'm not test it yet but from what I read, it's sound interesting!

The only concern is conflict possibility and performance of the chain-class.
Well, I think I will found an answer after test it

Qphoria wrote:Ah.. Great to see something finally came from the old 0.x discussions! Looks like you guys have done a nice job with this. I haven't tried it yet but it sounds great the way you got the automatic subclassing system working for multiple mods. I will have to try this.

Nice Work!

3rdcorner wrote:Something like this is what I've built in-house. The only problem I have is it replacing the core files. Right now I use VQMod to modify the core files and keep my override system separated.

How's the upgrade process with this system?

Looks great, I'll see for my next project what the options are for using this with VQMod, although it might not be worth the trouble.

$this->db->query("UPDATE " . DB_PREFIX . "customer SET address_id = '" . (int)$address_id . "' WHERE customer_id = '" . (int)$customer_id . "'");

$this->db->query("UPDATE " . DB_PREFIX . "customer SET address_id = '" . (int)$address_id . "', newfield = 1 WHERE customer_id = '" . (int)$customer_id . "'");

 public function addCustomer($data) 

Qphoria wrote: But then how would you do the same thing for an order? You can "cheat" by using the email field for a customer because that is also unique per customer. But the order table has only one unique field.

<?php
class myaddon_ModelCheckoutOrder extends ModelCheckoutOrder {

	// override function
	public function addOrder($data) {
		$order_id = parent::addOrder($data);

		// add new field into order record
		$sql  = "UPDATE `".DB_PREFIX."order` SET newfield='".$data['newfield']."' ";
		$sql .= "WHERE order_id = '".(int)$order_id."'";
		$this->db->query( $sql );
		return $order_id;
	}
}
?>

JNeuhoff wrote:

Qphoria wrote: But then how would you do the same thing for an order? You can "cheat" by using the email field for a customer because that is also unique per customer. But the order table has only one unique field.

Easy enough again

Code: Select all

<?php
class myaddon_ModelCheckoutOrder extends ModelCheckoutOrder {

	// override function
	public function addOrder($data) {
		$order_id = parent::addOrder($data);

		// add new field into order record
		$sql  = "UPDATE `".DB_PREFIX."order` SET newfield='".$data['newfield']."' ";
		$sql .= "WHERE order_id = '".(int)$order_id."'";
		$this->db->query( $sql );
		return $order_id;
	}
}
?>

You have to think differently here. This is object oriented programming, in particular, extending classes and overrding methods to get an additional and/or modified behavior for the method. I have a few live sites now using this new Override Engine, with lots of modifications, no problems so far.

$order_download_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_download WHERE order_id = '" . (int)$order_id . "'");

$order_download_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_download LEFT JOIN order_download_master odm WHERE order_id = '" . (int)$order_id . "'");

Qphoria wrote: Yea i get what it is doing.. just wasn't sure where it comes in. I guess it depends on where you call the parent. In this case you are fortunate that addOrder returns the order_id, so I'll try something more difficult...

In the catalog/model/checkout/order.php
in the confirm() function
I want to change

Code: Select all

$order_download_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_download WHERE order_id = '" . (int)$order_id . "'");

to

Code: Select all

$order_download_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_download LEFT JOIN order_download_master odm WHERE order_id = '" . (int)$order_id . "'");

			$template = new Template();
			if ($order_download_query->num_rows) {
				$template->data['download'] = $order_info['store_url'] . 'index.php?route=account/download';
			} else {
				$template->data['download'] = '';
			}
			...
			$html = $template->fetch('default/template/mail/order.tpl');
			...

			if ($order_download_query->num_rows) {
				$text .= $language->get('text_new_download') . "\n";
				$text .= $order_info['store_url'] . 'index.php?route=account/download' . "\n\n";
			}

			$mail = new Mail(); 
			...
			$mail->setHtml($html);
			$mail->setText(html_entity_decode($text, ENT_QUOTES, 'UTF-8'));
			$mail->send();

			$template = $this->factory->newTemplate();
			...
			$mail = $this->factory->newMail();
			...

			$template = new Template();
			...
			$mail = new Mail();
			...

class myaddon_Mail extends Mail {

	// override method
	function setText( $text ) {
		parent::setText( $text );
		// run the modified order_download_query
		// change $this->text accordingly
		...
	}

	// override method
	function setHtml( $html ) {
		parent::setHtml( $html );
		// run the modified order_download_query
		// change $this->html accordingly	
		...
	}
}	

madimar wrote:Just to say... Really interesting topic... I will try to check the new override system soon. Thanks for your work jneuhoff.
M

JNeuhoff wrote: You are really trying to make my life miserable here

Well, Rome wasn't built in a day. My Override Engine may need some more refinement to cater for all these crazy cases, you got me there

Qphoria wrote: LOL I just wanted to press a little... maybe for being a bit dismissive of vQmod
Granted your way is indeed a much better programmatic way of proper modification. vQmod is just that little hack engine that could.

I'd still like to see your override engine in the core for larger mods, leaving vQmod for the smaller one line changes like this.

<?php
class myaddon_ModelCheckoutOrder extends ModelCheckoutOrder {

	// override function
	public function confirm($order_id, $order_status_id, $comment = '', $notify = false) { 

		// prevent parent function from sending mail, because we need some modifications
		$saved_mail_protocol = $this->config->get('config_mail_protocol');
		$this->config->set( 'config_mail_protocol', '' );

		// call parent method`
		parent::confirm( $order_id, $order_status_id, $comment, $notify );

		// let's use our modifified download_order_query
		$order_download_query = $this->db->query("SELECT * FROM " . DB_PREFIX . "order_download LEFT JOIN order_download_master odm WHERE order_id = '" . (int)$order_id . "'");
		$has_downloads = ($order_download_query->num_rows > 0);

		// use the modified order downloads query data for populating the mail message body, 
		// then send the confirmation mail
		$this->config->set( 'config_mail_protocol', $saved_mail_protocol );
		$mail = new Mail();
		// .....
		$mail->send();
	}
}
?>

straightlight wrote: Exactly as I pointed out from one of the topics last year; to use overrides.