Conversion Bug in ALL versions of OpenCart for ALL payments
Posted: Tue Dec 01, 2009 12:22 am
I believe there is a bug in ALL payment modules for when currency is forced to change.
In all payment module code where you find:
It should be:
When passing the "value" parameter, it forces the value to stay the same while the currency option only changes the symbols and decimal places.
So $50.00 ---> 50.00€
But really it should be $50.00 ---> 33.28€
It is not noticed normally because most payment modules support the main currencies they are used for. But that isn't always the case. In the case where there is a conversion done, it doesn't change the price properly.
In all payment module code where you find:
Code: Select all
$order_info['currency'], $order_info['value'], FALSE
Code: Select all
$order_info['currency'], FALSE, FALSE
So $50.00 ---> 50.00€
But really it should be $50.00 ---> 33.28€
It is not noticed normally because most payment modules support the main currencies they are used for. But that isn't always the case. In the case where there is a conversion done, it doesn't change the price properly.