Page 1 of 1
Get rid of layout?
Posted: Fri Jul 31, 2009 8:26 pm
by Daniel
Does any one think its a good idea to get rid of the controller layout class?
If you look at lot of other projects they seem to just have a header and footer class rather than a layout.
the header would be responsable for settign the title, descriptions and modules.
Does any one think this is a good idea?
it would mean none of the old templates would work.
Re: Get rid of layout?
Posted: Fri Jul 31, 2009 9:36 pm
by Qphoria
I know zencart does this on a per module basis... tho I find it somewhat unintuitive. but how about the sidebox layouts and such? would that also be set in the header?
Re: Get rid of layout?
Posted: Fri Jul 31, 2009 11:45 pm
by phpuk
Hmm,
Users already complain like hell about the lack of a seamless upgrade to the next version. Do you really want them to have to redesign all of their templates as well?
Just a thought...
Phil.
Re: Get rid of layout?
Posted: Sun Aug 02, 2009 8:29 am
by CodeBits
BAD Idea. To take away ability to create designs beyond a header and footer would suck big time. Don't even consider it PLEASE!!!
Re: Get rid of layout?
Posted: Mon Aug 03, 2009 5:02 pm
by gichuru
That is a very bad idea...
I would even suggest if Smarty tags can be used then it would even be much better , Users should be able to use their old template with new versions of Opencart... just my 2cents
Re: Get rid of layout?
Posted: Mon Aug 03, 2009 5:13 pm
by CodeBits
I personally don't care for programs like Smarty

, but that's me... just let me keep the flexibility and freedom to hand code a layout and I'm a happy camper. It is to bad the templates are not compatible with new versions, but I'd rather live with that than loose the ability to hand code a design.
Re: Get rid of layout?
Posted: Mon Aug 03, 2009 6:21 pm
by gichuru

thats why you are called codebit.. you can code to bits... the simpler the better for us with simpler names

Re: Get rid of layout?
Posted: Mon Aug 03, 2009 7:23 pm
by Qphoria
See here why smarty makes no sense:
http://forum.opencart.com/viewtopic.php ... rty#p24378
Also, why learn another language syntax when php is simpler yet more powerful, and applies to all php applications the same way.
Re: Get rid of layout?
Posted: Mon Aug 03, 2009 10:48 pm
by robbercrombie
will there be any improvements to the cart by doing so?
if not, i do not see why you should change it
and i totally agree with Phil
Re: Get rid of layout?
Posted: Tue Aug 04, 2009 5:35 pm
by orionweb
It really makes no difference in the end, and anyone who is making a hardcore theme will potentially modify and edit the entire layout code anyway, so I would just leave it!
Re: Get rid of layout?
Posted: Tue Aug 04, 2009 10:56 pm
by Daniel
I'm only thinking of doing for personal coding preference.
I prefer on having children and drilling down and not having parents e.g. layout.
Re: Get rid of layout?
Posted: Tue Aug 04, 2009 11:52 pm
by Qphoria
Well if you have a proof of concept working, that could be cool to see.
Re: Get rid of layout?
Posted: Wed Aug 05, 2009 12:06 am
by orionweb
It would just suck to have to re-do a whole template in order to update the cart software as well, unless you offered the template system update as an alternate download.
Re: Get rid of layout?
Posted: Wed Aug 05, 2009 12:07 am
by Qphoria
how many files of the template have you actually modified? mostly the css and a few placements maybe.. but most files are rarely touched anyway. First lets see what's involved with the new method to see if maybe its easier or more powerful
Perhaps make it a v130-nolayout.zip version that is no diff from the current v130.. then decide which is better and go that way.
Re: Get rid of layout?
Posted: Wed Aug 05, 2009 2:17 am
by Rich
Perhaps make it a v130-nolayout.zip version that is no diff from the current v130.. then decide which is better and go that way.
I agree with Qphoria. This will be probably the best way to find out what is the better way to go.
I am now working on template for OpenCart now ( it will be finish in couple days so I will post it here ) so I like to try out the version what you Daniel are proposing just to find out what takes more time and what you can do with it.
Re: Get rid of layout?
Posted: Wed Aug 05, 2009 5:05 am
by orionweb
It would be cool if you did this to include a small set of instructions for theme makers to update their templates so that they can be used in newer versions. I guess it would only be a paragraph or two, copy this paste it here... that sort of thing.
Re: Get rid of layout?
Posted: Wed Aug 05, 2009 7:13 am
by Daniel
you would only need to change about 4 files to upgrade.
Re: Get rid of layout?
Posted: Wed Aug 05, 2009 7:39 am
by orionweb
That's cool then, so long as I know which ones
