Post by BAJR » Thu Jul 16, 2009 1:02 am

no shipping session clear on adding new items to the cart

1. Add item to cart
2. Goto Checkout (shipping)
3. Add something else to cart
4. Goto Checkout (shipping)
5. Shipping is still using session. (BAD)

Only if something like cart "update" is clicked, or address is changed, then it will reset.
But adding new item to cart is bugged.

New member

Posts

Joined
Sun Jul 12, 2009 6:17 pm

Post by Daniel » Thu Jul 16, 2009 1:04 am

I have just confrimed this and it will be fixed in the next version.

I forgot to clear the shippign data when using the ajax cart.

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by BAJR » Thu Jul 16, 2009 4:14 am

Big thanks Daniel

any idea of next version time schedule.

New member

Posts

Joined
Sun Jul 12, 2009 6:17 pm

Post by creative1 » Sat Jul 25, 2009 12:33 am

Daniel,

Is there a quick fix we can "MOD" into existing installations? I've done quite a bit of modding in the current version (1.2.9), and I'd hate to lose all that / have to do it all again by updating.

This is quite a serious bug, as it could lead to huge over/under charges. In fact, I don't think I can launch our new store (otherwise working perfectly!) without a fix for this.

Thanks for any help you can provide.

Newbie

Posts

Joined
Tue Jul 21, 2009 12:07 am

Post by Qphoria » Sat Jul 25, 2009 12:41 am

If you pay me $10 you can use this fix :)


EDIT: catalog/controller/module/cart.php

FIND:

Code: Select all

$this->cart->add($this->request->post['product_id'], $this->request->post['quantity'], $option);
AFTER ADD:

Code: Select all

unset($this->session->data['shipping_methods']);
unset($this->session->data['shipping_method']);
unset($this->session->data['payment_methods']);
unset($this->session->data['payment_method']);

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Daniel » Sat Jul 25, 2009 12:49 am

the latest version has this fixed!

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by creative1 » Sat Jul 25, 2009 1:36 am

Qphoria wrote:If you pay me $10 you can use this fix :)


EDIT: catalog/controller/module/cart.php

FIND:

Code: Select all

$this->cart->add($this->request->post['product_id'], $this->request->post['quantity'], $option);
AFTER ADD:

Code: Select all

unset($this->session->data['shipping_methods']);
unset($this->session->data['shipping_method']);
unset($this->session->data['payment_methods']);
unset($this->session->data['payment_method']);
Hey! I just paid you $20 for the shipping mod - don't get greedy ;)

All kidding aside, thanks for posting this. I know the new version fixes it, but I've got a lot of custom code, and I need to get this store up soon without the risk of reinstalling everything.

Newbie

Posts

Joined
Tue Jul 21, 2009 12:07 am

Post by BAJR » Wed Jul 29, 2009 12:31 am

and by the way daniel, thank you

New member

Posts

Joined
Sun Jul 12, 2009 6:17 pm

Post by Qphoria » Wed Jul 29, 2009 1:41 am

what about me? I posted the fix :)

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by BAJR » Wed Jul 29, 2009 2:04 am

and... er you get a special hug!

ps... have not yet forgotten my contribution.. waiting to get some cash put into my Paypal -

New member

Posts

Joined
Sun Jul 12, 2009 6:17 pm
Who is online

Users browsing this forum: No registered users and 13 guests