OpenCart Community

Just as the title says: BankTransfer details are not sent to customer via email.
Doesn't work neither on 1.5.0 neither on 1.5.1.1

Does a comment get added to the order in your admin containing the bank details ?

Let me get this straight.

You want to send a customer's bank account details in a "plain text" email that can easily be read by any packet sniffer so the WHOLE WORLD can see it? Might as well put their credit card information in there as well.

It is standard practice to send bank details via email to your customers.

There's less information than there is on a cheque.

All they can do with the info is pay into the account.

I don't see the problem.

I believe the same thing is also happening with cheque payments, no info on who to make the cheque payable to etc is sent in the order confirmations.

The email already contains the customer's name and address, adding the bank account details (account number, BSB, etc) provides a scammer or hacker with enough information to wipe out that customer's bank account before they've even received the confirmation email.

It's not the customer's address we are referring to, it is the store holder's

I would like it to be so that MY bank account number (number to which customer will transfer money) would be emailed to the customer.

uksitebuilder wrote:Does a comment get added to the order in your admin containing the bank details ?

Yes

uksitebuilder wrote:It's not the customer's address we are referring to, it is the store holder's

You mean bank details.

I must admit that I haven't looked at a lot of the payment modules (only those that I use myself, ie. free checkout and paypal), so I guess I've shown my ignorance on this one.

Yes, uksitebuilder is right. There should be a comment in the email showing the "Bank Transfer Instructions" you entered in the admin. This should contain instructions for the customer on how to make the transfer, including your bank details (account number, BSB, etc).

add it to the bug tracker please.

Will add it to the tracker.

Just to note, the details are sent in the plain text email the admin receives.

I think I have narrowed it down to catalog/view/theme/default/template/mail/order.php not referencing the available comment data

Try this. In "catalog/model/checkout/order.php" (at around line 253), insert: Then, in "catalog/view/theme/default/template/mail/order.tpl", insert: before: Haven't tested it, but it looks like it should work.

fido-x wrote:Try this. In "catalog/model/checkout/order.php" (at around line 253), insert:

Code: Select all

$template->data['text_comment'] = $language->get('text_new_comment');
if ($order_info['comment']) {
    $template->data['comment'] = $order_info['comment'];
} 

Then, in "catalog/view/theme/default/template/mail/order.tpl", insert:

Code: Select all

<?php if ($comment) { ?>
<p><?php echo $text_comment; ?></p>
<p><?php echo $comment; ?></p>
<?php } ?>

before:

Code: Select all

<p><?php echo $text_footer; ?></p>

Haven't tested it, but it looks like it should work.

Thanks for fast reply, but i am now getting an error:

Notice: Undefined variable: comment in /home/dragonltu/domains/galidejas.lt/public_html/shop/catalog/view/theme/galidejas/template/mail/order.tpl on line 162

OK, change this bit that you added to "catalog/model/checkout/order.php" from: to:

Error disappeared, but the bank details are still missing in the email.

Now, I might be wrong, but maybe your last peace of code is missing language get?

Just had another look at the code in the checkout/order model and in the bank transfer module. Scrap what I told you before -- I got it wrong! I was looking at the wrong comment.

OK. In "catalog/model/checkout/order.php" replace the block of code I told you to insert at line 253, with: And, in "catalog/view/theme/default/template/mail/order.tpl", replace the code I gave you with:

fido-x wrote:Just had another look at the code in the checkout/order model and in the bank transfer module. Scrap what I told you before -- I got it wrong! I was looking at the wrong comment.

OK. In "catalog/model/checkout/order.php" replace the block of code I told you to insert at line 253, with:

Code: Select all

$template->data['comment'] = $comment; 

And, in "catalog/view/theme/default/template/mail/order.tpl", replace the code I gave you with:

Code: Select all

<?php if ($comment) { ?>
<p><?php echo $comment; ?></p>
<?php } ?>

Yes, this works perfectly! Thank you!

Thanks for the information, it solved this almost for me but maybe I lost something in the corrections or is my shop too customized but when I applied this fix, it overwrites the customer remarks in the e-mail.

So I added in catalog/model/checkout/order.php below: this new line: And in catalog/view/theme/default/template/mail/order.tpl above the $text_footer: Which solved my override in 1.5.0.5 with this extension: http://www.opencart.com/index.php?route ... order=DESC

Hi

I did this solution but when i do testing email. The comment become like this

Bank Transfer Instructions Thank you for buying with us. Please transfer the total amount to the following bank account. Maybank Acc# :xxx CIMB Acc# :xxx Kindly inform us reference number after payment. Email to xxxx or SMS to xxxxxx Your order will not ship until we receive payment. Your order will not ship until we receive payment.

The comment do not have any line.

While it should be like this

Please transfer the total amount to the following bank account.

Maybank Acc# : xxxx
CIMB Acc# : xxxxx

Kindly inform us reference number after payment. Email to xxx or SMS to xxxx

Your order will not ship until we receive payment.

Please help

Hanis wrote:Hi

I did this solution but when i do testing email. The comment become like this

Bank Transfer Instructions Thank you for buying with us. Please transfer the total amount to the following bank account. Maybank Acc# :xxx CIMB Acc# :xxx Kindly inform us reference number after payment. Email to xxxx or SMS to xxxxxx Your order will not ship until we receive payment. Your order will not ship until we receive payment.

The comment do not have any line.

While it should be like this

Please transfer the total amount to the following bank account.

Maybank Acc# : xxxx
CIMB Acc# : xxxxx

Kindly inform us reference number after payment. Email to xxx or SMS to xxxx

Your order will not ship until we receive payment.

Please help

Hi Hanis!

Were you able to solve this? I'm having the same problem thank you.

Regards.

@Hanis @Angeloop