Page 1 of 1
Currency Bug
Posted: Sat Mar 28, 2009 8:24 am
by fido-x
It's a wonder nobody else found this yet.
If you enter
http://www.yourshop.com or
http://www.yourdomain.com/shop (wherever you have your shop), then change the currency before doing anything else, the error page is returned. This can be fixed by changing line 24 in "catalog/controller/module/currency.php" from
Code: Select all
$this->data['redirect'] = $this->url->http(str_replace('route=', '', urldecode(http_build_query($this->request->get))));
to
Code: Select all
if (@!$this->request->get['route']) {
$this->data['redirect'] = $this->url->http('common/home');
} else {
$this->data['redirect'] = $this->url->http(str_replace('route=', '', urldecode(http_build_query($this->request->get))));
}
Re: Currency Bug
Posted: Sat Mar 28, 2009 9:20 am
by Daniel
Thanks!
I have just done the fix for this.
We should have a vote if I should release another version with all these fixes in.
Re: Currency Bug
Posted: Sat Mar 28, 2009 10:19 am
by Qphoria
I'd say just release weekly builds on fridays.. or every other friday until its more stable. It's already pretty close, but don't stop just because a few whining people are too eager to upgrade. Do the major development now, people will be happier later, even if they don't realize it now.
Re: Currency Bug
Posted: Sat Mar 28, 2009 11:13 pm
by iloveopencart
I agree with Qphoria. I love the growing improvements and bug fixes. I've learned to use SVN to compare differences between each old and new file and plug in the important changes manually. Never takes more than an hour to do. It's much easier than upgrading every new release and redoing all my hacks, which takes days.
Re: Currency Bug
Posted: Sat Mar 28, 2009 11:50 pm
by Daniel
So should I just keep releasing near daily or just leave it until the end of each week.
At some point I will run out of bugs and new features to add.
Re: Currency Bug
Posted: Sun Mar 29, 2009 12:08 am
by Qphoria
Daniel wrote:
At some point I will run out of bugs and new features to add.
And at that point, then you should slow down to every 2 weeks or once per month. But for now, keep chuggin
Re: Currency Bug
Posted: Sun Mar 29, 2009 2:28 am
by MarkF
but don't stop just because a few whining people are too eager to upgrade
Well I probably fall into the whining camp
but I've already posted on frequency & release notes and I still think that there are some valid points raised by a number of people which would help everyone.
Anyway, what would really help is a proper release note included in the download zip - a list of changes/fixes along with the associated files.
I'm quite happy to do some diffs on a few files, for the changes/fixes I want - but not wade through the whole lot or try and work out how SVN works!
Make it easy for people - whether you're a web developer or end user, time is precious!
Thanks
