Page 1 of 1

Double quote in product name causes name to be concatenated

Posted: Fri Jan 16, 2009 2:52 pm
by splach
if you have a double quote, say for inches, in the product name, when you go to edit the product the name is cut off at the double quote. I am assuming that there needs to be an extra escape added to the quote either when it is being stored or parsed.

Re: Double quote in product name causes name to be concatenated

Posted: Fri Jan 16, 2009 7:54 pm
by JNeuhoff
I can confirm this bug for 0.7.9RC6, and propose the following fix:

Replace line 452 in file /admin/controller/product.php

Old line:

Code: Select all

	    		'name'        => (isset($name[$result['language_id']]) ? $name[$result['language_id']] : @$product_description_info['name']),
New line:

Code: Select all

	    		'name'        => htmlentities((isset($name[$result['language_id']]) ? $name[$result['language_id']] : @$product_description_info['name'])),

Re: Double quote in product name causes name to be concatenated

Posted: Mon Jan 19, 2009 12:06 am
by hm2k
Proper fix in r343.