Post by fogma » Sun Dec 28, 2008 3:19 am

I've just upgraded 0.7.8 to RC5 and found that my modified offline (based on cheque) payment method is now broken. My hunting through the forum / bug list suggest this is the change that has done it:

http://forum.opencart.com/index.php/topic,2078.0.html
http://code.google.com/p/open-cart/issues/detail?id=109

However I've not managed to work out what change I need to make to check payment method to make it work again.

Any hints?

Cheers,

Gary

New member

Posts

Joined
Wed Aug 13, 2008 4:16 am

Post by Qphoria » Sun Dec 28, 2008 3:31 am

I'm not sure why it is breaking it, but I am actually removing that check with the new, new Paypal fix.
I should have it ready in about 30 min for people to try. This should also fix your module

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by fogma » Sun Dec 28, 2008 3:37 am

Hi Qphoria,

Thanks for coming back to me so quick.

I could be wrong about the reason the payment module has broken. All I know for certain is that when I add a DIE to checkout_process.php as follows:

Code: Select all

    function validate() {
        $language =& $this->locator->get('language');
        $request  =& $this->locator->get('request');
        $payment  =& $this->locator->get('payment');
        $response =& $this->locator->get('response');
        $session  =& $this->locator->get('session');
        $url      =& $this->locator->get('url');
        
        $language->load('controller/checkout_process.php');
        
        if ($request->isPost()) { // Prevent direct loading
             if ($session->get('confirm_id') != null) { //ignore validation if payment module doesn't support it (backward compatible)
                if ($request->gethtml('confirm_id') != session_id()) { //if it is set but doesn't match then error.
            				die('E');
                    $this->error['message'] = $language->get('error_confirm');
                }
            }
        } else {
            $this->error['message'] = $language->get('error_confirm');
        }
It dies with an 'E' which suggests its failing the "does the confirm id = the session id" test.

Cheers,

Gary

New member

Posts

Joined
Wed Aug 13, 2008 4:16 am

Post by Qphoria » Sun Dec 28, 2008 11:38 am

Ok.. install the new paypal here:
http://forum.opencart.com/index.php/topic,2570.0.html

This includes the fixes to remove the processing validation stuff.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am
Who is online

Users browsing this forum: No registered users and 1 guest