Page 1 of 1
Removing or Edit Address and Phone#
Posted: Mon Feb 17, 2025 8:58 am
by porter943
Hello All,
I'm trying to remove or edit the address and phone number on the Contact Us form, but I can't seem to find the right place or file to edit.
Please See Image.. I'm using OC ver 3.0.2.0
Thank You
Re: Removing or Edit Address and Phone#
Posted: Mon Feb 17, 2025 10:55 am
by by mona
No OC version
catalog/view/theme/*/information/contact.twig
admin => system => settings => stores => store tab
Re: Removing or Edit Address and Phone#
Posted: Mon Feb 17, 2025 10:57 am
by porter943
Ver 3.0.2.0
Re: Removing or Edit Address and Phone#
Posted: Mon Feb 17, 2025 3:41 pm
by OSWorX
Or use the internal Theme Editor.
Re: Removing or Edit Address and Phone#
Posted: Mon Feb 17, 2025 8:00 pm
by paulfeakins
OSWorX wrote: ↑Mon Feb 17, 2025 3:41 pm
Or use the internal Theme Editor.
That's best avoided in versions of OC where it makes a copy of the theme files in the database and prevents all extensions working on them. I'm not sure what version that was changed so I'm not sure if it applies to this version or not.
Re: Removing or Edit Address and Phone#
Posted: Mon Feb 17, 2025 8:35 pm
by JNeuhoff
paulfeakins wrote: ↑Mon Feb 17, 2025 8:00 pm
That's best avoided in versions of OC where it makes a copy of the theme files in the database and prevents all extensions working on them. I'm not sure what version that was changed so I'm not sure if it applies to this version or not.
This is a valid point. Perhaps it makes sense to fix this issue in the upcoming 3.0.4.1 and 4.1.0.1 versions . Basically, the order of modifications needs to be:
1) changes in theme editor
2) OCmod based changes
3) VQmod based changes
That is, before OCmod or VQmod get to do their bits, we need to make sure to grab the template file from the correct place: If it's in the database (because of theme editor changes), then take from there, otherwise take the twig file from the the template theme folder. And then go about to apply the subsequent changes from OCmod and VQmod.
Re: Removing or Edit Address and Phone#
Posted: Mon Feb 17, 2025 9:45 pm
by OSWorX
JNeuhoff wrote: ↑Mon Feb 17, 2025 8:35 pm
paulfeakins wrote: ↑Mon Feb 17, 2025 8:00 pm
That's best avoided in versions of OC where it makes a copy of the theme files in the database and prevents all extensions working on them. I'm not sure what version that was changed so I'm not sure if it applies to this version or not.
This is a valid point. Perhaps it makes sense to fix this issue in the upcoming 3.0.4.1 and 4.1.0.1 versions . Basically, the order of modifications needs to be:
1) changes in theme editor
2) OCmod based changes
3) VQmod based changes
That is, before OCmod or VQmod get to do their bits, we need to make sure to grab the template file from the correct place: If it's in the database (because of theme editor changes), then take from there, otherwise take the twig file from the the template theme folder. And then go about to apply the subsequent changes from OCmod and VQmod.
Correct @paulfeakins and valid @JNeuhoff
General it should be done via the internal thems editor - that's for he was added (a long time ago).
And since then, the bug exists!
It's highly recommended to fix that lousy bug, the more many users are reporting problems when using the theme editor in conjunction with OCMod and/or VQMod.
And it would be good if Daniel would hear what he has written by himself:
https://github.com/opencart/opencart/di ... t-11842747
i plan to start doing weekly releases.
Just wondering where are all those releases .. ?
Re: Removing or Edit Address and Phone#
Posted: Tue Feb 18, 2025 12:05 am
by nonnedelectari
JNeuhoff wrote: ↑Mon Feb 17, 2025 8:35 pm
paulfeakins wrote: ↑Mon Feb 17, 2025 8:00 pm
That's best avoided in versions of OC where it makes a copy of the theme files in the database and prevents all extensions working on them. I'm not sure what version that was changed so I'm not sure if it applies to this version or not.
This is a valid point. Perhaps it makes sense to fix this issue in the upcoming 3.0.4.1 and 4.1.0.1 versions . Basically, the order of modifications needs to be:
1) changes in theme editor
2) OCmod based changes
3) VQmod based changes
That is, before OCmod or VQmod get to do their bits, we need to make sure to grab the template file from the correct place: If it's in the database (because of theme editor changes), then take from there, otherwise take the twig file from the the template theme folder. And then go about to apply the subsequent changes from OCmod and VQmod.
I would at least give a warning when using the theme editor on a twig file which has an ocmod modification and visa versa, give a warning when applying an ocmod on a twig file when a theme editor change is in the database.
But personally I would leave the theme editor alone and just stick to OC or VQ MOD.
Re: Removing or Edit Address and Phone#
Posted: Tue Feb 18, 2025 1:04 am
by OSWorX
nonnedelectari wrote: ↑Tue Feb 18, 2025 12:05 am
But personally I would leave the theme editor alone and just stick to OC or VQ MOD.
Not really, because why installing anything else when the user wants to add or remove a few simple lines only?
No need to install or realize such via OC-/VQmod.
Re: Removing or Edit Address and Phone#
Posted: Tue Feb 18, 2025 11:30 pm
by paulfeakins
JNeuhoff wrote: ↑Mon Feb 17, 2025 8:35 pm
This is a valid point. Perhaps it makes sense to fix this issue in the upcoming 3.0.4.1 and 4.1.0.1 versions .
I believe it is fixed now, but I'm not sure which exact version it was fixed in.
Re: Removing or Edit Address and Phone#
Posted: Sun Feb 23, 2025 1:17 am
by JNeuhoff
paulfeakins wrote: ↑Tue Feb 18, 2025 11:30 pm
JNeuhoff wrote: ↑Mon Feb 17, 2025 8:35 pm
This is a valid point. Perhaps it makes sense to fix this issue in the upcoming 3.0.4.1 and 4.1.0.1 versions .
I believe it is fixed now, but I'm not sure which exact version it was fixed in.
It's not fixed. The biggest challenge with the theme editor is that it's store_id and theme specific, see DB table 'oc_theme', yet OCmod is store_id agnostic with regards to modified frontend templates. And even worse, if a frontend template was modified via the theme editor, OCmod simply ignores it and grabs the original file from the theme's template folder.
Perhaps a solution would be for the DIR_MODIFICATION to use a
store_id prefix or suffix for the modified frontend template file name. And of course OCmod needs to make sure to check the modification from the theme editor first when loading a frontend template content. This would require some changes to the
admin/controller/marketplace/modification.php and the
system/template/*.php files.