Hi all,
Can anyone help explain what the payment methods from front end account should do?
I see it works on the demo (v 4.0.0.0) but the links have been removed from latest versions (on the account.twig).
If i load the page (/index.php?route=account/payment_method) from version 4.0.2.2 i just get hit with errors:
Warning: Undefined variable $payment_method in /home/xxx/xxx/public_html/catalog/controller/account/payment_method.php on line 83
Should this page no longer be included, or am i missing a setting? I checked a fresh install.... same result.
I sent this to Craig privately but I thought I'd post it here as well:
I'm not 100% sure about the payment method files, but I believe it was intended to be a way to manage payment methods for subscriptions. However, it appears to be scrapped, since you're correct that it does not function (and is not accessible). I'm guessing Daniel left the files in there because he plans to work on it, but hasn't found time for it.
It's non-functional, so you'd be fine to delete those files. Someday there may be payment method saving in OpenCart, but given how slowly bugs are fixed, I'm guessing it's a few years off at best.
I'm not 100% sure about the payment method files, but I believe it was intended to be a way to manage payment methods for subscriptions. However, it appears to be scrapped, since you're correct that it does not function (and is not accessible). I'm guessing Daniel left the files in there because he plans to work on it, but hasn't found time for it.
It's non-functional, so you'd be fine to delete those files. Someday there may be payment method saving in OpenCart, but given how slowly bugs are fixed, I'm guessing it's a few years off at best.
craigbaines wrote: ↑Sat Sep 16, 2023 11:16 pmHi all,
Can anyone help explain what the payment methods from front end account should do?
I see it works on the demo (v 4.0.0.0) but the links have been removed from latest versions (on the account.twig).
If i load the page (/index.php?route=account/payment_method) from version 4.0.2.2 i just get hit with errors:
Warning: Undefined variable $payment_method in /home/xxx/xxx/public_html/catalog/controller/account/payment_method.php on line 83
Should this page no longer be included, or am i missing a setting? I checked a fresh install.... same result.
Hey all, I'm facing the same issue. Opencart v4.0.2.3 fresh install.
Any recommendation to fix this?
I already submitted a pull request on Github Opencart recently about clearing the customer_payment entries on the DB since it doesn't seem to be in-use anymore.jricky31 wrote: ↑Tue Dec 12, 2023 8:36 amcraigbaines wrote: ↑Sat Sep 16, 2023 11:16 pmHi all,
Can anyone help explain what the payment methods from front end account should do?
I see it works on the demo (v 4.0.0.0) but the links have been removed from latest versions (on the account.twig).
If i load the page (/index.php?route=account/payment_method) from version 4.0.2.2 i just get hit with errors:
Warning: Undefined variable $payment_method in /home/xxx/xxx/public_html/catalog/controller/account/payment_method.php on line 83
Should this page no longer be included, or am i missing a setting? I checked a fresh install.... same result.
Hey all, I'm facing the same issue. Opencart v4.0.2.3 fresh install.
Any recommendation to fix this?
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
straightlight wrote: ↑Wed Dec 13, 2023 10:57 pmI already submitted a pull request on Github Opencart recently about clearing the customer_payment entries on the DB since it doesn't seem to be in-use anymore.jricky31 wrote: ↑Tue Dec 12, 2023 8:36 amcraigbaines wrote: ↑Sat Sep 16, 2023 11:16 pmHi all,
Can anyone help explain what the payment methods from front end account should do?
I see it works on the demo (v 4.0.0.0) but the links have been removed from latest versions (on the account.twig).
If i load the page (/index.php?route=account/payment_method) from version 4.0.2.2 i just get hit with errors:
Warning: Undefined variable $payment_method in /home/xxx/xxx/public_html/catalog/controller/account/payment_method.php on line 83
Should this page no longer be included, or am i missing a setting? I checked a fresh install.... same result.
Hey all, I'm facing the same issue. Opencart v4.0.2.3 fresh install.
Any recommendation to fix this?
Could you please share the link of the PR?
Will this fix land in v4.0.2.4 or should be manually applied in v4.0.2.3?straightlight wrote: ↑Wed Dec 13, 2023 10:57 pmI already submitted a pull request on Github Opencart recently about clearing the customer_payment entries on the DB since it doesn't seem to be in-use anymore.jricky31 wrote: ↑Tue Dec 12, 2023 8:36 amcraigbaines wrote: ↑Sat Sep 16, 2023 11:16 pmHi all,
Can anyone help explain what the payment methods from front end account should do?
I see it works on the demo (v 4.0.0.0) but the links have been removed from latest versions (on the account.twig).
If i load the page (/index.php?route=account/payment_method) from version 4.0.2.2 i just get hit with errors:
Warning: Undefined variable $payment_method in /home/xxx/xxx/public_html/catalog/controller/account/payment_method.php on line 83
Should this page no longer be included, or am i missing a setting? I checked a fresh install.... same result.
Hey all, I'm facing the same issue. Opencart v4.0.2.3 fresh install.
Any recommendation to fix this?
It's always the current MB version that's being focused on. Passed releases are not being patched, whether it's passed series or current series. Only on upcoming releases.jricky31 wrote: ↑Thu Dec 14, 2023 1:26 amWill this fix land in v4.0.2.4 or should be manually applied in v4.0.2.3?straightlight wrote: ↑Wed Dec 13, 2023 10:57 pmI already submitted a pull request on Github Opencart recently about clearing the customer_payment entries on the DB since it doesn't seem to be in-use anymore.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
straightlight wrote: ↑Thu Dec 14, 2023 3:36 amIt's always the current MB version that's being focused on. Passed releases are not being patched, whether it's passed series or current series. Only on upcoming releases.jricky31 wrote: ↑Thu Dec 14, 2023 1:26 amWill this fix land in v4.0.2.4 or should be manually applied in v4.0.2.3?straightlight wrote: ↑Wed Dec 13, 2023 10:57 pm
I already submitted a pull request on Github Opencart recently about clearing the customer_payment entries on the DB since it doesn't seem to be in-use anymore.
Could you please share the link of the PR?
By ensuring you're synching the Opencart fork tree and up-to-date, currently, the following are the leftovers for: customer_payment entries:jricky31 wrote: ↑Thu Dec 14, 2023 4:41 amstraightlight wrote: ↑Thu Dec 14, 2023 3:36 amIt's always the current MB version that's being focused on. Passed releases are not being patched, whether it's passed series or current series. Only on upcoming releases.
Could you please share the link of the PR?
Code: Select all
admin/controller/customer/customer.php
admin/controller/mail/subscription.php
admin/controller/sale/subscription.php
admin/model/sale/subscription.php
catalog/controller/mail/subscription.php
install/controller/upgrade/upgrade_8.php
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
you mentioned a pull request was submitted.straightlight wrote: ↑Wed Dec 13, 2023 10:57 pmI already submitted a pull request on Github Opencart recently about clearing the customer_payment entries on the DB since it doesn't seem to be in-use anymore.jricky31 wrote: ↑Tue Dec 12, 2023 8:36 amcraigbaines wrote: ↑Sat Sep 16, 2023 11:16 pmHi all,
Can anyone help explain what the payment methods from front end account should do?
I see it works on the demo (v 4.0.0.0) but the links have been removed from latest versions (on the account.twig).
If i load the page (/index.php?route=account/payment_method) from version 4.0.2.2 i just get hit with errors:
Warning: Undefined variable $payment_method in /home/xxx/xxx/public_html/catalog/controller/account/payment_method.php on line 83
Should this page no longer be included, or am i missing a setting? I checked a fresh install.... same result.
Hey all, I'm facing the same issue. Opencart v4.0.2.3 fresh install.
Any recommendation to fix this?
could you please share the github link to the corresponding pull request so that I can see the change set?
thanks for your support!
Who is online
Users browsing this forum: No registered users and 1 guest
