OpenCart Community

Posted: **Thu May 02, 2019 7:55 am**

Hi guys,

I know this subject has been discussed before, but I would like to effectively contribute to the OC have less repetition and consequently less line of code, obviously without losing the simplicity and without causing errors.

I raised a discussion in Github on this topic. With only two simple classes, 340 lines of code were saved in the controller product, as well as eliminating repetition: https://github.com/opencart/opencart/pull/7398

Maybe the classes are not the most elegant, but the intention is to discuss this topic and do something effective to correct this problem (in my opinion).

Posted: **Thu May 02, 2019 8:46 am**

Code: Select all

 I would like to effectively contribute to the OC

Well, that's great.

But better don't expect anyone to praise you for that,
because OC is well known, to most likely 'follow' it's own strategy, when
it comes to such. And it might not be so easy, to convince them, and some
even left again, during the Years, after realizing, that their input has not
found open OC ears.

And you are new around here, meaning, that nobody is able to 'tax' your
OC Coder Knowledge, which does not make it easier for you as well. So,
better stay nice 'n easy at Github, and don't push anything and anyone,
then, you'll have a chance, to someday succeed, in one or the other way.

Just don't take anything personal, OC is a rough terrain, and all about
Competition too, so, don't expect it to be more, and you'll never be
disappointed.

Just to get you down to real Earth, where OC is part of, like it or not ...

Good Luck!
Ernie

Posted: **Thu May 02, 2019 9:19 am**

IP_CAM wrote: ↑
Thu May 02, 2019 8:46 am
Code: Select all
 I would like to effectively contribute to the OC
Well, that's great. But better don't expect anyone to praise you for that,
because OC is well known, to most likely 'follow' it's own strategy, when
it comes to such. And it might not be so easy, to convince them, and some
even left again, during the Years, after realizing, that their input has not
found open OC ears.

And you are new around here, meaning, that nobody is able to 'tax' your
OC Coder Knowledge, which does not make it easier for you as well. So,
better stay nice 'n easy at Github, and don't push anything and anyone,
then, you'll have a chance, to someday succeed, in one or the other way.

Just don't take anything personal, OC is a rough terrain, and all about
Competition too, so, don't expect it to be more, and you'll never be
disappointed.

Just to get you down to real Earth, where OC is part of, like it or not ...
Good Luck!
Ernie

I understood your position Ernie and thank you for your precious tip. I will not take it personal

Indeed, I'm not expecting anything in return, not even thanks. On the contrary, I'm grateful to the OC and the community for providing this excellent platform and sharing their expertise.

Although I'm new to comments and contributions, I accompany the OC for five years, but I did not have time to do what I am currently doing (contributing).

Just as the team has tilted and changed the rendering of the language, greatly reducing lines of code, I believe it can be done with the breadcrumbs and urls string.

OpenCart Community

Remove code repetition

Remove code repetition

Re: Remove code repetition

Re: Remove code repetition