Post by straightlight » Sun Mar 17, 2019 12:46 am

Several bug fixes have been applied to the PayPal Express Checkout files, since several users reported issues on the forum. Attached are the files to be replaced. First, take a screenshot of your PP Express admin configuration form and uninstall the extension. Then, replace the files. Then, reinstall the extension. Lastly, follow the FAQ: viewtopic.php?f=176&p=739789#p718325 .

This should resolved the issue with PayPal Express Checkout. A new topic will be addressed to the hollows team to confirm an on-going issue for this extension payment module.

After replacing the files: viewtopic.php?f=176&p=739789#p718325
Last edited by straightlight on Tue Mar 19, 2019 5:04 am, edited 1 time in total.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by blocks1 » Mon Mar 18, 2019 8:22 pm

Parse error: syntax error, unexpected 'protected' (T_PROTECTED) in /home/mysite.com/admin/controller/extension/payment/pp_express.php on line 408

just after install + cant view the extension

New member

Posts

Joined
Thu Feb 08, 2018 11:14 am

Post by chaminda » Mon Mar 18, 2019 9:34 pm

same problem don't try this, atleast anyway to restore to old extension ?

Newbie

Posts

Joined
Mon Mar 18, 2019 9:15 pm

Post by straightlight » Tue Mar 19, 2019 5:07 am

Package updated. The errors described above were about minor typos. They have now been fixed.

- Added error API messages on admin controller and TWIG file
- Replaced hardcoded text with language variables
- Added language text in language file
- Cleaned controller files
- Added more triggers to the PayPal Express Logs for troubleshooting
- Added error pages with error text so that merchants gets notified more in details of what is going on
- Reported most latest issues from the package on GitHub: https://github.com/opencart/opencart/issues/7272
same problem don't try this, atleast anyway to restore to old extension ?
Cheer up there. Once the end of the world will truly arrived, you'll know it! . That's what the forum is for; for the whole world to know about the product. Reverting back to the previous version of the extension definitely won't solved the issue. The reason why the problem was not fixed on a short basis is because we all have lives. I already make as much fix as I can and no reason for anyone to be told that these bugfixes should not be tried.

Thanks to: blocks1 for reporting the typos.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by blocks1 » Tue Mar 19, 2019 5:55 am

it works!,

i couldn't add a custom logo for paypal page unfortunately but its no biggy..
also during checkout i got one soft error type of thing, see screenshot.

great work, i was never going to downgrade opencart so very thankful for this contribution..

Attachments

cart.jpg

cart.jpg (16.91 KiB) Viewed 220 times


New member

Posts

Joined
Thu Feb 08, 2018 11:14 am

Post by straightlight » Tue Mar 19, 2019 6:09 am

For the custom logo, I did noticed the changes in the PayPal Express API's parameters from the controller which the imglogo no longer seem to be supported but rather the header image logo can be added from the OC admin-end in the extension form.

As for the error message you are having, ensure that the total amount of the selected products are not higher than your configured total for PayPal Express in the OC admin extension form. Also ensure that the geo zones are properly configured - both from your admin geo zones and admin settings for each stores. In addition, ensure that your geo zones are properly configured from the extension itself in the OC admin form.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by blocks1 » Tue Mar 19, 2019 7:31 am

managed to get a couple other snags,

it also says it is enabled even when it is disabled,

on the second screenshot, i had to ctrl, shift and R to reset the cache and then it worked until i went to pay then said the same thing, "Your payment has been completed. To continue shopping, please return to the merchant."

in the url bar for the pp popup window it has "genericError?code=" in the url string

i removed gzip compression from my htaccess file incase.. as i was experiencing issues with login on certain pages and things in the cart on the cart page even when logged out? doesnt seem to help the plugin

i will keep testing..

Attachments

success-weird.png

success-weird.png (27.58 KiB) Viewed 194 times

second-strange.jpg

second-strange.jpg (36.68 KiB) Viewed 194 times


New member

Posts

Joined
Thu Feb 08, 2018 11:14 am

Post by straightlight » Tue Mar 19, 2019 9:42 am

The main cause was that the previous PP Express extension before the fix that multiple users were reporting about on the forum lately was about a redirection issue. This part seem to have been resolved, however. It would require a second user to test this fix to see if on your end, it is simply a matter of settings that is affecting your domain as we speak.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by blocks1 » Tue Mar 19, 2019 9:21 pm

Hopefully chaminda can get the courage to update.. we'll see if someone else pops in.. i am currently investigating some errors with loading sourceguardian and imagick after upping my php version to 7.1 yesterday so i expect it is that..

cheers
A

New member

Posts

Joined
Thu Feb 08, 2018 11:14 am

Post by straightlight » Wed Mar 20, 2019 5:50 am

So far, there's nothing wrong with the code that would interfere with the features as compared to the original files. Feel free to try this fix with a solid PCI server.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by JNeuhoff » Wed Mar 20, 2019 11:18 pm

straightlight wrote:
Wed Mar 20, 2019 5:50 am
So far, there's nothing wrong with the code that would interfere with the features as compared to the original files. Feel free to try this fix with a solid PCI server.
Have you also had a chance to take a look at this PayPal Express issue?

MHC Web Design
Override Engine * Integrated VQMod * Multilingual SEO * Instant Option Price Calculator * TrustPilot Reviews * Google Rich Snippets * Google Tag Manager * Export/Import Tool * Template Switcher PHP/Twig


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by straightlight » Thu Mar 21, 2019 4:30 am

JNeuhoff wrote:
Wed Mar 20, 2019 11:18 pm
straightlight wrote:
Wed Mar 20, 2019 5:50 am
So far, there's nothing wrong with the code that would interfere with the features as compared to the original files. Feel free to try this fix with a solid PCI server.
Have you also had a chance to take a look at this PayPal Express issue?
Issue spotted about that field. I am currently working on it. I will update the package on the first post once finished and send an update on Github.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by chaminda » Thu Mar 21, 2019 6:21 am

Fatal error: Uncaught Exception: Error: Table 'domain.oc_paypal_order' doesn't exist
Error No: 1146
INSERT INTO `oc_paypal_order` SET `order_id` = '15', `date_added` = NOW(), `date_modified` = NOW(), `capture_status` = 'Complete', `currency_code` = 'AUD', `total` = '57', `authorization_id` = '123456789' in /hermes/bosnacweb01/bosnacweb01ad/b2265/account/domain/system/library/db/mysqli.php:40 Stack trace: #0 /hermes/bosnacweb01/bosnacweb01ad/b2265/..../storage-la/modification/system/library/db.php(58): DB\MySQLi->query('INSERT INTO `oc...') #1 /hermes/bosnacweb01/bosnacweb01ad/b2265/.../.../catalog/model/extension/payment/pp_express.php(44): DB->query('INSERT INTO `oc...') #2 /hermes/bosnacweb01/bosnacweb01ad/b2265/ipg.laodelph/storage-la/modification/system/engine/loader.php(256): ModelExtensionPaymentPPExpress->addOrder(Array) #3 /hermes/bosnacweb01/bosnacweb01ad/b2265/.../..../system/engine/proxy.php(47): Loader->{closure}(Array, Array) #4 /herme in /hermes/bosnacweb01/bosnacweb01ad/b2265/..../..../system/library/db/mysqli.php on line 40

Newbie

Posts

Joined
Mon Mar 18, 2019 9:15 pm

Post by straightlight » Thu Mar 21, 2019 6:58 am

chaminda wrote:
Thu Mar 21, 2019 6:21 am
Fatal error: Uncaught Exception: Error: Table 'domain.oc_paypal_order' doesn't exist
Error No: 1146
INSERT INTO `oc_paypal_order` SET `order_id` = '15', `date_added` = NOW(), `date_modified` = NOW(), `capture_status` = 'Complete', `currency_code` = 'AUD', `total` = '57', `authorization_id` = '123456789' in /hermes/bosnacweb01/bosnacweb01ad/b2265/account/domain/system/library/db/mysqli.php:40 Stack trace: #0 /hermes/bosnacweb01/bosnacweb01ad/b2265/..../storage-la/modification/system/library/db.php(58): DB\MySQLi->query('INSERT INTO `oc...') #1 /hermes/bosnacweb01/bosnacweb01ad/b2265/.../.../catalog/model/extension/payment/pp_express.php(44): DB->query('INSERT INTO `oc...') #2 /hermes/bosnacweb01/bosnacweb01ad/b2265/ipg.laodelph/storage-la/modification/system/engine/loader.php(256): ModelExtensionPaymentPPExpress->addOrder(Array) #3 /hermes/bosnacweb01/bosnacweb01ad/b2265/.../..../system/engine/proxy.php(47): Loader->{closure}(Array, Array) #4 /herme in /hermes/bosnacweb01/bosnacweb01ad/b2265/..../..../system/library/db/mysqli.php on line 40
The table should of been created at this point if you did followed the instructions properly from the first post. In your PHPMyAdmin, you can always run this query in your Opencart database:

Code: Select all

CREATE TABLE IF NOT EXISTS `oc_paypal_order` (
			  `paypal_order_id` int(11) NOT NULL AUTO_INCREMENT,
			  `order_id` int(11) NOT NULL,
			  `date_added` DATETIME NOT NULL,
			  `date_modified` DATETIME NOT NULL,
			  `capture_status` ENUM('Complete','NotComplete') DEFAULT NULL,
			  `currency_code` CHAR(3) NOT NULL,
			  `authorization_id` VARCHAR(30) NOT NULL,
			  `total` DECIMAL( 10, 2 ) NOT NULL,
			  PRIMARY KEY (`paypal_order_id`)
			) ENGINE=MyISAM DEFAULT COLLATE=utf8_general_ci

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by chaminda » Thu Mar 21, 2019 8:33 am

thank you very much. i test it and work but please try others as my files mess with restored old file so i don't know exactly what was fixed.

Newbie

Posts

Joined
Mon Mar 18, 2019 9:15 pm

Post by straightlight » Thu Mar 21, 2019 8:51 am

thank you very much. i test it and work but please try others as my files mess with restored old file so i don't know exactly what was fixed.
There's nothing wrong with this fix in order to create a crash as you described. The only leftovers are the zones to be fixed. I am currently working on it.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.

F. Rules:

- viewtopic.php?f=176&t=200480
- viewtopic.php?f=176&t=200804


Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 3 guests