Post by straightlight » Tue Aug 07, 2018 2:00 am

So pretend it’s stable....
Being pretentious before an official release is irrelevant, since the final release has not yet been released. Better to ask this question once the release will be stable period.

The most generated errors being found on Opencart forum originates from contributed programming.

Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by uksitebuilder » Tue Aug 07, 2018 2:35 pm

For those asking is it worth upgrading, then answer is definitely NO.

It is an ALPHA release and should only be used by developers and testers to find and report bugs.

Likewise when the BETA is released.

ImageImageImageImageImage

For Friendly Professional Support - Click Here


User avatar
Guru Member

Posts

Joined
Thu Jun 09, 2011 11:37 pm
Location - United Kindgom

Post by davidbfranks » Tue Aug 07, 2018 2:47 pm

uksitebuilder wrote:
Tue Aug 07, 2018 2:35 pm
For those asking is it worth upgrading, then answer is definitely NO.

It is an ALPHA release and should only be used by developers and testers to find and report bugs.

Likewise when the BETA is released.
I meant once it’s fully released and stable is there is any point upgrading....

Active Member

Posts

Joined
Mon Mar 04, 2013 10:31 pm
Location - London

Post by straightlight » Tue Aug 07, 2018 6:57 pm

Event has not arrived yet. Wait for that future to come before knowing the answer. Back to the future is only a movie.

The most generated errors being found on Opencart forum originates from contributed programming.

Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by davidbfranks » Tue Aug 07, 2018 7:33 pm

Well Daniel said
I plan for 1 week of alpha release while i fix bugs then 1 month of beta so extension developers have time to update their extensions.
It's been a week, no bug fix commits on GitHub,

So I won't hold my breath.....

Active Member

Posts

Joined
Mon Mar 04, 2013 10:31 pm
Location - London

Post by straightlight » Tue Aug 07, 2018 7:37 pm

Correct, it says: plan . Planning is only a pessimist time-period that has been defined. It is not official even though he is already behind schedule.

The most generated errors being found on Opencart forum originates from contributed programming.

Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by Richard Lee » Thu Aug 09, 2018 11:10 pm

What be changing in new version and previous version.

Newbie

Posts

Joined
Wed Dec 06, 2017 11:03 pm

Post by straightlight » Fri Aug 10, 2018 4:57 am

Read the previous replies about it. All the details are indicated already.

The most generated errors being found on Opencart forum originates from contributed programming.

Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by davidbfranks » Fri Aug 10, 2018 4:57 am

Richard Lee wrote:
Thu Aug 09, 2018 11:10 pm
What be changing in new version and previous version.
Not much, Daniel said:
Added
Bootstrap 4
Font Awesome 5
Jquery 3.3.1
Ability to have search engine index pages in multiple languages.
Added ckeditor back
Template code can now be edited before it processed using lamba functions.
All URL's generated in the catalog controller files now have language= appended to them.
SEO URL's can now replace any normal URL query and not just pre defind ones link product, category, manufacturer pages.
Added a CRON job system so no need for extension developers having to manually add this via the cpanel's.

Active Member

Posts

Joined
Mon Mar 04, 2013 10:31 pm
Location - London

Post by hydrowire » Fri Aug 10, 2018 1:38 pm

Template code can now be edited before it processed using lamba functions.
I'm still not able to get OCMOD to work on edited template code using the admin > Design > Theme Editor.

Someone else reported the same issue on github as well: #6758

The code in question is in /catalog/controller/event/theme.php on line 34:

Code: Select all

26: // If you want to modify the output of the template we add a
27:	$this->lambda = function (&$code) use (&$route, &$args, &$directory) {
28:		// If there is a theme override we should get it
29:		$this->load->model('design/theme');
30:
31:		$theme_info = $this->model_design_theme->getTheme($route, $directory);
32: 
33:		if ($theme_info) {
34:			$code = html_entity_decode($theme_info['code'], ENT_QUOTES, 'UTF-8');
35:		}
36:	};
It seems to override all modification code from the modification storage cache with edited code directly from the database, without any OCMOD modification that was previously applied.

I tried to make it work but failed. As edited template code with Theme Editor is per store based, OCMOD is file based, I can't find a solution to this.

Anyone knows how to get OCMOD modification and edited Template code to work well together using the lambda function as claimed?

Developing Quality OpenCart Extensions since 2011.
View my extensions


User avatar
Active Member

Posts

Joined
Wed Jan 26, 2011 5:41 pm


Post by straightlight » Fri Aug 10, 2018 8:05 pm

I did noticed that portion lately as it seem the system/library/template/Twig.php file has also been modified to confine the Twig extension by, instead, using extends. This was, however, discussed on GitHub but I do prefer the use of YAML files rather than the design/theme route since it can provide up to unlimited solutions with the Symphony Engine without interfering with other extension developers.

The most generated errors being found on Opencart forum originates from contributed programming.

Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by JNeuhoff » Mon Aug 13, 2018 6:43 pm

This is probably an old known issue, but it still hasn't been resolved:

Having turned off caching, and then changed the common/header.twig by the built-in theme editor, the change works fine. However, when I change the same file 'catalog/view/theme/default/template/common/header.twig' via OCmod, then only the latter change shows up, the first one done via the theme editor gets ignored.

The simple solution would be for the OCmod: When it loads the template file to be modified, it should also check whether there are other changes already done it from the theme editor, e.g. do a simple DB query first:

Code: Select all

$modified_template = $this->model_design_theme->getTheme( $route, $theme_directory )
If it detects prior changes, use the code from that DB query for further modification by OCmod, otherwise use the original template file for the modification by OCmod.

---------------------------------------

Actually, after having done some more tests, the template changes from the theme editor never appear to show up at all, regardless whether there are also OCmod changes or not.

This whole OpenCart theme fiasco gets increasingly messy with each new release.

MHC Web Design
Override Engine * Integrated VQMod * Multilingual SEO * Instant Option Price Calculator * TrustPilot Reviews * Download Options * Free Download Buttons * Export/Import Tool * Template Switcher PHP/Twig


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by davidbfranks » Tue Aug 14, 2018 10:09 pm

Daniel wrote:
Wed Jul 25, 2018 9:02 pm

I plan for 1 week of alpha release while i fix bugs then 1 month of beta so extension developers have time to update their extensions.
So 3 weeks later almost no progress by the looks of things.....

Active Member

Posts

Joined
Mon Mar 04, 2013 10:31 pm
Location - London

Post by MonolithForge » Wed Aug 15, 2018 8:04 am

Thanks for waiting on php 7. We're running Slackware 14.2 and are stuck with 5.6 at the moment ;-)

Newbie

Posts

Joined
Sat Jul 14, 2018 3:13 am

Post by mag-developer » Fri Aug 17, 2018 11:55 am

Daniel wrote:
Wed Jul 25, 2018 9:02 pm
...
Added
Bootstrap 4
Font Awesome 5
Jquery 3.3.1
...
Great news!
It would be nice to have an updated version of the Swiper in the distribution, since version 3.x is no longer supported and the API was changed by the developer.
and Magnific Popup as well.

User avatar
Newbie

Posts

Joined
Sat Mar 18, 2017 12:19 am
Who is online

Users browsing this forum: No registered users and 12 guests