Page 1 of 1

[v3.0.2.0 - Fix] - catalog/controller/extension/payment/nochex.php file

Posted: Tue Oct 31, 2017 9:36 pm
by straightlight
In that file,

find:

Code: Select all

if (isset($this->request->get['method']) && $this->request->get['method'] == 'decline') {
add above:

Code: Select all

if (empty($this->session->data['order_id'])) {
	$this->session->data['error'] = $this->language->get('error_declined');

	$this->response->redirect($this->url->link('checkout/cart'));
}

Re: [v3.0.2.0 - Fix] - catalog/controller/extension/payment/nochex.php file

Posted: Wed Nov 01, 2017 5:09 am
by yodapt
In the same file, find these two occurrences :

Code: Select all

$this->currency->getCode()

Code: Select all

$currency
replace with

Code: Select all

$order_info['currency_code']

Re: [v3.0.2.0 - Fix] - catalog/controller/extension/payment/nochex.php file

Posted: Wed Nov 01, 2017 7:00 am
by straightlight
On that file, the only line I can see regarding the currency steps you provided is this one:

Code: Select all

$data['amount'] = $this->currency->format($order_info['total'], 'GBP', false, false);
The same at: https://raw.githubusercontent.com/openc ... nochex.php

Re: [v3.0.2.0 - Fix] - catalog/controller/extension/payment/nochex.php file

Posted: Wed Nov 01, 2017 9:47 pm
by yodapt
Hmm, I was thinking of this file : https://support.nochex.com/kb/faq.php?id=146

If you download the v3 package, you'll find what I ment, and also some other issues. This was after a client tried to install that extension and couldnt get it to work.

Re: [v3.0.2.0 - Fix] - catalog/controller/extension/payment/nochex.php file

Posted: Wed Nov 01, 2017 9:51 pm
by straightlight
The URL should of been posted with your last correction. At least, now, we have both versions posted.

Re: [v3.0.2.0 - Fix] - catalog/controller/extension/payment/nochex.php file

Posted: Wed Nov 01, 2017 10:11 pm
by yodapt
I didnt noticed that module was already included in v3. I guess those changes I mentioned can be discarded then, and rather a notice about the module from the official website not being ready for production?

Re: [v3.0.2.0 - Fix] - catalog/controller/extension/payment/nochex.php file

Posted: Wed Nov 01, 2017 10:25 pm
by straightlight
I am currently investigating these comparisons.