[v3.0.2.0 - Issue] - google base plugin MPN vs EAN

Post Reply

3 posts Page 1 of 1

[v3.0.2.0 - Issue] - google base plugin MPN vs EAN

halbot

Newbie

Posts

Joined

Wed Sep 20, 2017 5:35 pm

Post by halbot » Fri Oct 06, 2017 7:56 pm

Hi, catalog\controller\extension\feed\catalog.php contains this code:

Code: Select all

						if ($product['mpn']) {
							$output .= '  <g:mpn><![CDATA[' . $product['mpn'] . ']]></g:mpn>' ;
						} else {
							$output .= '  <g:identifier_exists>false</g:identifier_exists>';
						}

						if ($product['upc']) {
							$output .= '  <g:upc>' . $product['upc'] . '</g:upc>';
						}

						if ($product['ean']) {
							$output .= '  <g:ean>' . $product['ean'] . '</g:ean>';
						}

Thus it adds identifier_exists>false to the feed unless MPN is set. However EAN, UPC, ISBN, JAN are all valid identifiers to Google. Therefore the code should only output identifier_exists>false if all of them are not set. Otherwise it tells Google that there is no identifier where there is one, and there are errors when google base imports the feed.

halbot

Newbie

Posts

Joined

Wed Sep 20, 2017 5:35 pm