Page 1 of 2
[1.4.8]Tax Added and Showing Before Checkout
Posted: Fri Jun 11, 2010 2:27 pm
by djcxm
Hi All,
I recently upgraded to 1.4.8 and the only mod I had installed was Options Plus.
Currently I am experiencing an issue in which after a product is added to the shopping cart.
The side shopping cart totals included Taxes prior to ever asking for the customers address which would trigger the geozone.
I also notice that the tax is automatically removed once the customer makes an account and their state is selected.
however For example a customer is shown CA Sales Tax in the image which would cause people to think they are being charged by default prior to creating an account.
I would like to make it so that taxes are only displayed on the Checkout Confirmation page.
Any help is greatly appreciated
-Christian
Re: Tax Added and Showing Before Checkout
Posted: Mon Jun 14, 2010 1:39 am
by Qphoria
The fix:
1. EDIT: system/library/tax.php
2. FIND:
Code: Select all
if (isset($this->session->data['country_id']) && isset($this->session->data['zone_id'])) {
$country_id = $this->session->data['country_id'];
$zone_id = $this->session->data['zone_id'];
} else {
$country_id = $this->config->get('config_country_id');
$zone_id = $this->config->get('config_zone_id');
}
3. REPLACE WITH:
Code: Select all
if (isset($this->session->data['country_id']) && isset($this->session->data['zone_id'])) {
$country_id = $this->session->data['country_id'];
$zone_id = $this->session->data['zone_id'];
} else {
if ($this->config->get('config_tax')) {
$country_id = $this->config->get('config_country_id');
$zone_id = $this->config->get('config_zone_id');
} else {
$country_id = 0;
$zone_id = 0;
}
}
4. EDIT: system/library/customer.php
5. FIND:
6. AFTER, ADD:
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 2:59 am
by Qphoria
Updated the post above with the new fix that should shut everyone up for a while.
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 4:18 am
by i2Paq
Qphoria wrote:Updated the post above with the new fix that should shut everyone up for a while.
Thank you for you kind words
Your not quit there yet
When I log in, as a customer with a Tax class different then the default one of the Store/Item, it will change Tax class only after I add an item to the cart and choose Checkout.
Before it will show prices with the default Store/Item Tax.
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 4:26 am
by Qphoria
i2Paq wrote:Qphoria wrote:Updated the post above with the new fix that should shut everyone up for a while.
Thank you for you kind words
Your not quit there yet
When I log in, as a customer with a Tax class different then the default one of the Store/Item, it will change Tax class only after I add an item to the cart and choose Checkout.
Before it will show prices with the default Store/Item Tax.
You mean if you have "display prices with tax" set to YES correct?
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 4:28 am
by i2Paq
Qphoria wrote:You mean if you have "display prices with tax" set to YES correct?
Correct.
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 4:32 am
by Qphoria
Be sure you made all the changes above, including the change in the tax file.
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 5:02 am
by i2Paq
Qphoria wrote:Be sure you made all the changes above, including the change in the tax file.
Looking at the system/library/tax.php from the 1.4.8b patch I see:
Code: Select all
if (isset($this->session->data['country_id']) && isset($this->session->data['zone_id'])) {
$country_id = $this->session->data['country_id'];
$zone_id = $this->session->data['zone_id'];
} else {
if ($this->config->get('config_tax')) {
$country_id = $this->config->get('config_country_id');
$zone_id = $this->config->get('config_zone_id');
} else {
$country_id = 0;
$zone_id = 0;
}
}
That differs from that what you posted in #2, it looks like a combination of those 2.
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 5:05 am
by Qphoria
correct.. replace that chunk with the above
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 5:08 am
by i2Paq
Qphoria wrote:correct.. replace that chunk with the above
Edit:
I replaced mine part with the one from #2, Tax stopped working completely.
It only shows tax on the checkout page when logged on, otherwise it is without tax.
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 3:29 pm
by adrunkentheory
Where is this setting... Display Prices with Tax?
Qphoria wrote:i2Paq wrote:Qphoria wrote:Updated the post above with the new fix that should shut everyone up for a while.
Thank you for you kind words
Your not quit there yet
When I log in, as a customer with a Tax class different then the default one of the Store/Item, it will change Tax class only after I add an item to the cart and choose Checkout.
Before it will show prices with the default Store/Item Tax.
You mean if you have "display prices with tax" set to YES correct?
Re: Tax Added and Showing Before Checkout
Posted: Sat Jun 19, 2010 4:53 pm
by i2Paq
adrunkentheory wrote:Where is this setting... Display Prices with Tax?
In the BO goto: System -> Settings -> Tab: Option -> Display Prices With Tax:
Re: Tax Added and Showing Before Checkout
Posted: Tue Jun 29, 2010 11:54 am
by vkaltchev
djcxm wrote:Tax Added and Showing Before Checkout
by djcxm » Fri Jun 11, 2010 7:27 am
Hi All,
I recently upgraded to 1.4.8 and the only mod I had installed was Options Plus.
Currently I am experiencing an issue in which after a product is added to the shopping cart.
The side shopping cart totals included Taxes prior to ever asking for the customers address which would trigger the geozone.
I have the same problem but only in the second store; my default store calculates the sales tax just fine. Can somebody please summarize what should I do to fix it. I read the discussion but there were a lot of corrections and going back and forth, so I am not sure what I should do and in what order.
Thanks for helping.
Cheers,
Valentina
Re: Tax Added and Showing Before Checkout
Posted: Tue Jun 29, 2010 9:28 pm
by Qphoria
Re: Tax Added and Showing Before Checkout
Posted: Sun Jul 11, 2010 11:26 am
by kwasini
I followed the fix provided by Qphoria, but I still have the same problem with the cart showing sales tax, which is set for NY only, when the customer adds an item to the shopping cart. The tax goes away when the customer keys in their non-New York address. I am not sure if the fix worked for others, but it has not worked in my case, provided I followed them correctly.
Re: Tax Added and Showing Before Checkout
Posted: Sun Jul 11, 2010 4:42 pm
by i2Paq
Topic moved to Bug forum.
Re: Tax Added and Showing Before Checkout
Posted: Mon Jul 12, 2010 3:05 am
by Moggin
kwasini wrote:I followed the fix provided by Qphoria, but I still have the same problem with the cart showing sales tax, which is set for NY only, when the customer adds an item to the shopping cart. The tax goes away when the customer keys in their non-New York address. I am not sure if the fix worked for others, but it has not worked in my case, provided I followed them correctly.
Is the store set to 'Display tax= No' in the admin panel? ..I am no expert, but spent some time trying to achieve the opposite effect (show tax before shipping is known).
Re: Tax Added and Showing Before Checkout
Posted: Mon Jul 12, 2010 1:22 pm
by kwasini
Moggin wrote:kwasini wrote:I followed the fix provided by Qphoria, but I still have the same problem with the cart showing sales tax, which is set for NY only, when the customer adds an item to the shopping cart. The tax goes away when the customer keys in their non-New York address. I am not sure if the fix worked for others, but it has not worked in my case, provided I followed them correctly.
Is the store set to 'Display tax= No' in the admin panel? ..I am no expert, but spent some time trying to achieve the opposite effect (show tax before shipping is known).
Yes, I did set "Display tax=no" (and I also had on "yes" with similar results). I appreciate the help.
Re: [1.4.8]Tax Added and Showing Before Checkout
Posted: Wed Jul 14, 2010 5:12 am
by vkaltchev
I don't know what I did right or wrong but the Qphoria fix worked for me.
Valentina
Re: Tax Added and Showing Before Checkout
Posted: Thu Sep 23, 2010 4:03 am
by sds
kwasini wrote:I followed the fix provided by Qphoria, but I still have the same problem with the cart showing sales tax, which is set for NY only, when the customer adds an item to the shopping cart. The tax goes away when the customer keys in their non-New York address. I am not sure if the fix worked for others, but it has not worked in my case, provided I followed them correctly.
What this guy said. I have 1.4.9 where this fix is already applied and the taxes will not go away until the customer types in his nontaxable address. Is this bug now considered "will not fix"?